From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float. To: Laszlo Ersek ,devel@edk2.groups.io From: "Matthew Carlson" X-Originating-Location: Everett, Washington, US (50.34.40.43) X-Originating-Platform: Windows Chrome 81 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Mon, 30 Mar 2020 14:27:42 -0700 References: <03f18a49-6bd6-e753-e1bf-7e061d13f200@redhat.com> In-Reply-To: <03f18a49-6bd6-e753-e1bf-7e061d13f200@redhat.com> Message-ID: <14537.1585603662366515487@groups.io> Content-Type: multipart/alternative; boundary="8EfLLLPeYBISW45EHAmT" --8EfLLLPeYBISW45EHAmT Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable So it's not required by OpenSSL, it's required by the compiler whenever flo= ating point is used, which can be in multiple places. For example, this is = used in mu_plus (the Microsoft UEFI value add to EDK2) by the OnScreenKeybo= ard driver as well as the UiToolKit driver. If you happen to use BaseCryptL= ib or the intrinsic in a driver that happens to need crypto as well, it can= break due to multiple. I do agree, this only applies to MSVC and requiring every platform to add = a line in their DSC would be a situation I would prefer to avoid if possibl= e. Is there a way to specify a library dependency only if a toolchain is be= ing used? -- - Matthew Carlson --8EfLLLPeYBISW45EHAmT Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable So it's not required by OpenSSL, it's required by the compiler whenever flo= ating point is used, which can be in multiple places. For example, this is = used in mu_plus (the Microsoft UEFI value add to EDK2) by the OnScreenKeybo= ard driver as well as the UiToolKit driver. If you happen to use BaseCryptL= ib or the intrinsic in a driver that happens to need crypto as well, it can= break due to multiple.

I do agree, this only applies to MSVC an= d requiring every platform to add a line in their DSC would be a situation = I would prefer to avoid if possible. Is there a way to specify a library de= pendency only if a toolchain is being used?
--
- Matthew Carlson --8EfLLLPeYBISW45EHAmT--