From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pcacjr@zytor.com>
Received: from mail.zytor.com (terminus.zytor.com [65.50.211.136])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 4AC2520945B77
 for <edk2-devel@lists.01.org>; Fri, 15 Sep 2017 14:46:18 -0700 (PDT)
Received: from [IPv6:2804:7f4:c480:33c7::2] ([IPv6:2804:7f4:c480:33c7:0:0:0:2])
 (authenticated bits=0)
 by mail.zytor.com (8.15.2/8.15.2) with ESMTPSA id v8FLl3cE032086
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO);
 Fri, 15 Sep 2017 14:47:06 -0700
To: Hao Wu <hao.a.wu@intel.com>, edk2-devel@lists.01.org
Cc: Ruiyu Ni <ruiyu.ni@intel.com>, Star Zeng <star.zeng@intel.com>,
 Eric Dong <eric.dong@intel.com>, Dandan Bi <dandan.bi@intel.com>
References: <20170915045753.588-1-hao.a.wu@intel.com>
From: Paulo Alcantara <pcacjr@zytor.com>
Message-ID: <145c5cd2-580d-6692-3397-c7eb4564ec0d@zytor.com>
Date: Fri, 15 Sep 2017 18:47:00 -0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20170915045753.588-1-hao.a.wu@intel.com>
Subject: Re: [PATCH 0/7] MdeModulePkg/Udf: Code refinements
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Sep 2017 21:46:18 -0000
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Hao,

On 15/09/2017 01:57, Hao Wu wrote:
> The series introduces the following code refinements for UdfDxe &
> PartitionDxe:
> 
> a. Add checks to ensure no possible NULL pointer dereference
> b. Reslove operands of different size in bitwise operations
> c. Use compare operator for non-boolean comparisons
> d. Refine function description comments
> e. Refine local variable initialization
> f. Refine enum members naming style
> 
> Cc: Paulo Alcantara <pcacjr@zytor.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> 
> Hao Wu (7):
>    MdeModulePkg/UdfDxe: Add checks to ensure no possible NULL ptr deref
>    MdeModulePkg/UdfDxe: Fix operands of different size in bitwise OP
>    MdeModulePkg/UdfDxe: Use compare operator for non-boolean comparisons
>    MdeModulePkg/Udf: Refine function description comments
>    MdeModulePkg/UdfDxe: Avoid short (single character) variable name
>    MdeModulePkg/Udf: Avoid declaring and initializing local GUID variable
>    MdeModulePkg/UdfDxe: Refine enum member naming style
> 
>   MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c            |  20 +-
>   MdeModulePkg/Universal/Disk/UdfDxe/File.c                 |   5 +-
>   MdeModulePkg/Universal/Disk/UdfDxe/FileName.c             |  27 +-
>   MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 483 +++++++++++++++-----
>   MdeModulePkg/Universal/Disk/UdfDxe/Udf.h                  |  49 +-
>   5 files changed, 432 insertions(+), 152 deletions(-)
Looks good to me. Also tested it with OVMF X64. Thanks!

Reviewed-by: Paulo Alcantara <pcacjr@zytor.com>

Paulo