From: "Rebecca Cran" <quic_rcran@quicinc.com>
To: Pedro Falcato <pedro.falcato@gmail.com>, <devel@edk2.groups.io>
Cc: "Marvin Häuser" <mhaeuser@posteo.de>
Subject: Re: [PATCH 1/1] Ext4Pkg: Fix broken stack protector-enabled builds
Date: Thu, 15 Sep 2022 17:10:02 -0600 [thread overview]
Message-ID: <145f8944-f4b4-a94a-571a-d58ed26761dc@quicinc.com> (raw)
In-Reply-To: <20220915230609.228037-1-pedro.falcato@gmail.com>
Reviewed-by: Rebecca Cran <rebecca@quicinc.com>
On 9/15/22 17:06, Pedro Falcato wrote:
> As reported by Rebecca Cran, there was some build breakage when
> compiling with stack-protector-on-by-default toolchains. Adding the
> proper library to the DSC should fix it.
>
> Cc: Rebecca Cran <rebecca@quicinc.com>
> Cc: Marvin Häuser <mhaeuser@posteo.de>
> Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
> ---
> Features/Ext4Pkg/Ext4Pkg.dsc | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Features/Ext4Pkg/Ext4Pkg.dsc b/Features/Ext4Pkg/Ext4Pkg.dsc
> index 57f279a4d918..59bc327ebf6e 100644
> --- a/Features/Ext4Pkg/Ext4Pkg.dsc
> +++ b/Features/Ext4Pkg/Ext4Pkg.dsc
> @@ -46,6 +46,11 @@
> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> BaseUcs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf
> +
> + #
> + # Required for stack protector support
> + #
> + NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
>
> ###################################################################################################
> #
next prev parent reply other threads:[~2022-09-15 23:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 23:06 [PATCH 1/1] Ext4Pkg: Fix broken stack protector-enabled builds Pedro Falcato
2022-09-15 23:10 ` Rebecca Cran [this message]
2022-09-16 6:51 ` Marvin Häuser
2022-09-16 10:00 ` Pedro Falcato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=145f8944-f4b4-a94a-571a-d58ed26761dc@quicinc.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox