From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web08.17163.1663283404644990136 for ; Thu, 15 Sep 2022 16:10:04 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@quicinc.com header.s=qcppdkim1 header.b=K/yjWKnV; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.168.131, mailfrom: quic_rcran@quicinc.com) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28FM9vFo003405; Thu, 15 Sep 2022 23:10:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=7qNLxr1luqEt4OdtGr279pCY2KF247fQafAP65ZkglA=; b=K/yjWKnVOk+6pu+X7b1VjYX2VK7W9fQNyHCHDWvtFLM3jLxzfE9denMOVNPo59QkJ1GH R4DchoVTVUlJvI3/PAYnueQFKOljvXtDj5WUXfYE8+r19jKXBKd65QC7Aiu4wA3T7zgK 4rVUdOEV3SXI9xTM3/4nbgfryQaZ95r/KC9dB/aDpEX8M3TLacpy+thvTSRvQXiO7U33 bUKre6Fvz/jFFNBaddVpt0uLjdQXCQd0VQ4cBkGabp4H+jzWwdPHX1SKE+eMY2AD6TSP PEsGbS1SpVffm89LqEBjKzRLkw3je70M4mUpYMwrXXPnxPO6gsBorhWAE4kOK2sf9Sri 3w== Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3jm8xmrwhw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Sep 2022 23:10:04 +0000 Received: from nasanex01b.na.qualcomm.com (corens_vlan604_snip.qualcomm.com [10.53.140.1]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 28FNA3ID025045 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Sep 2022 23:10:03 GMT Received: from [10.110.78.15] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Thu, 15 Sep 2022 16:10:03 -0700 Message-ID: <145f8944-f4b4-a94a-571a-d58ed26761dc@quicinc.com> Date: Thu, 15 Sep 2022 17:10:02 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 1/1] Ext4Pkg: Fix broken stack protector-enabled builds To: Pedro Falcato , CC: =?UTF-8?Q?Marvin_H=c3=a4user?= References: <20220915230609.228037-1-pedro.falcato@gmail.com> From: "Rebecca Cran" In-Reply-To: <20220915230609.228037-1-pedro.falcato@gmail.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: B64M1m48E_j813je1eRS-tL77hoc3FcU X-Proofpoint-ORIG-GUID: B64M1m48E_j813je1eRS-tL77hoc3FcU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-15_10,2022-09-14_04,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 suspectscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 mlxlogscore=999 priorityscore=1501 clxscore=1011 impostorscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2209150147 X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-0031df01.pphosted.com id 28FM9vFo003405 Content-Language: en-US Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable Reviewed-by: Rebecca Cran On 9/15/22 17:06, Pedro Falcato wrote: > As reported by Rebecca Cran, there was some build breakage when > compiling with stack-protector-on-by-default toolchains. Adding the > proper library to the DSC should fix it. > > Cc: Rebecca Cran > Cc: Marvin H=C3=A4user > Signed-off-by: Pedro Falcato > --- > Features/Ext4Pkg/Ext4Pkg.dsc | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Features/Ext4Pkg/Ext4Pkg.dsc b/Features/Ext4Pkg/Ext4Pkg.ds= c > index 57f279a4d918..59bc327ebf6e 100644 > --- a/Features/Ext4Pkg/Ext4Pkg.dsc > +++ b/Features/Ext4Pkg/Ext4Pkg.dsc > @@ -46,6 +46,11 @@ > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.in= f > OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTr= eeLib/BaseOrderedCollectionRedBlackTreeLib.inf > BaseUcs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.= inf > + > + # > + # Required for stack protector support > + # > + NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf > =20 > #####################################################################= ############################## > #