Re: [PATCH v2 3/3] DynamicTablesPkg: SSDT CPU _CPC generator

["PierreGondois" <pierre.gondois@arm.com>]

Hello Jeff,
Just one remark:

On 9/14/22 23:34, Jeff Brasen wrote:
> Add code to use a token attached to GICC to generate _CPC object on cpus.
> 
> Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> ---
>   .../SsdtCpuTopologyGenerator.c                | 223 +++++++++++++++++-
>   1 file changed, 217 insertions(+), 6 deletions(-)
> 
> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
> index 8561f48e1f..56741e7b58 100644

[snip]

> @@ -934,10 +1134,11 @@ CreateTopologyFromGicC (
>     IN        AML_OBJECT_NODE_HANDLE                        ScopeNode
>     )
>   {
> -  EFI_STATUS        Status;
> -  CM_ARM_GICC_INFO  *GicCInfo;
> -  UINT32            GicCInfoCount;
> -  UINT32            Index;
> +  EFI_STATUS              Status;
> +  CM_ARM_GICC_INFO        *GicCInfo;
> +  UINT32                  GicCInfoCount;
> +  UINT32                  Index;
> +  AML_OBJECT_NODE_HANDLE  CpuNode;
>   
>     ASSERT (Generator != NULL);
>     ASSERT (CfgMgrProtocol != NULL);
> @@ -961,12 +1162,22 @@ CreateTopologyFromGicC (
>                  ScopeNode,
>                  &GicCInfo[Index],
>                  Index,
> -               NULL
> +               &CpuNode
>                  );
>       if (EFI_ERROR (Status)) {
>         ASSERT (0);
>         break;
>       }
> +
> +    // If a CPC info is associated with the
> +    // GicCinfo, create an _CPC method returning them.
> +    if (GicCInfo->CpcToken != CM_NULL_TOKEN) {
> +      Status = CreateAmlCpcNode (Generator, CfgMgrProtocol, &GicCInfo[Index], CpuNode);
> +      if (EFI_ERROR (Status)) {
> +        ASSERT_EFI_ERROR (Status);
> +        return Status;

Could it be replaced with a 'break' just to be consistent in the loop ?

> +      }
> +    }
>     } // for
>   
>     return Status;