Re: [PATCH 0/3] OvmfPkg: broadcast SMIs and revert to traditional AP sync mode

[Laszlo Ersek <lersek@redhat.com>]

On 11/15/16 03:43, Laszlo Ersek wrote:
> Spurred by Jiewen's and Jeff's recent SMM-related work, Paolo and I
> stress-tested OVMF's SMM a little bit, and with S3 it turns out to be
> less stable than ideal.
> 
> Paolo agreed / suggested that we add a broadcast SMI mode to QEMU, and
> utilize it from OVMF:
> 
>   https://www.mail-archive.com/edk2-devel@lists.01.org/msg19669.html
> 
> I sent the QEMU patch a few minutes (or hours?) ago:
> 
>   http://lists.nongnu.org/archive/html/qemu-devel/2016-11/msg02687.html
> 
> and these are the OVMF patches that put the QEMU functionality to use.
> 
> With these patches (and with Jeff's just-committed series for
> <https://bugzilla.tianocore.org/show_bug.cgi?id=216>) I see stable and
> reliable behavior with SMM+S3. Please see
> 
>   https://lists.01.org/pipermail/edk2-devel/2016-November/004682.html
> 
> for details.
> 
> Repo:   https://github.com/lersek/edk2/
> Branch: broadcast_smi
> BZ:     https://bugzilla.tianocore.org/show_bug.cgi?id=230
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> 
> Thanks
> Laszlo
> 
> Laszlo Ersek (3):
>   OvmfPkg/SmmControl2Dxe: select broadcast SMI
>   OvmfPkg: revert "any AP in SMM should not wait for the BSP for more
>     than 100 ms"
>   OvmfPkg: revert "use relaxed AP SMM synchronization mode"
> 
>  OvmfPkg/OvmfPkgIa32.dsc                       |  2 --
>  OvmfPkg/OvmfPkgIa32X64.dsc                    |  2 --
>  OvmfPkg/OvmfPkgX64.dsc                        |  2 --
>  OvmfPkg/Include/IndustryStandard/Q35MchIch9.h |  6 ++++--
>  OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c       | 18 +++++++++++++++++-
>  5 files changed, 21 insertions(+), 9 deletions(-)
> 

Self-NAK, will send a new version.