public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Dandan Bi <dandan.bi@intel.com>
To: edk2-devel@lists.01.org
Cc: Liming Gao <liming.gao@intel.com>, Eric Dong <eric.dong@intel.com>
Subject: [patch 1/2] BaseTool/VfrCompile: Add missing question opcode
Date: Mon,  1 Aug 2016 19:18:30 +0800	[thread overview]
Message-ID: <1470050311-68144-2-git-send-email-dandan.bi@intel.com> (raw)
In-Reply-To: <1470050311-68144-1-git-send-email-dandan.bi@intel.com>

The function CheckQuestionOpCode is to check whether the opcode
is question opcode, but it misses two question opcodes:
'EFI_IFR_REF_OP' and 'EFI_IFR_RESET_BUTTON'. Now add them.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
---
 BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp b/BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp
index 1612217..892b7b8 100644
--- a/BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp
+++ b/BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp
@@ -1,10 +1,10 @@
 /** @file
   
   The definition of CFormPkg's member function
 
-Copyright (c) 2004 - 2013, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2004 - 2016, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials                          
 are licensed and made available under the terms and conditions of the BSD License         
 which accompanies this distribution.  The full text of the license may be found at        
 http://opensource.org/licenses/bsd-license.php                                            
                                                                                           
@@ -1179,10 +1179,12 @@ CIfrRecordInfoDB::CheckQuestionOpCode (
   case EFI_IFR_ACTION_OP:
   case EFI_IFR_STRING_OP:
   case EFI_IFR_DATE_OP:
   case EFI_IFR_TIME_OP:
   case EFI_IFR_ORDERED_LIST_OP:
+  case EFI_IFR_REF_OP:
+  case EFI_IFR_RESET_BUTTON_OP:
     return TRUE;
   default:
     return FALSE;
   }
 }
-- 
1.9.5.msysgit.1



  reply	other threads:[~2016-08-01 11:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-01 11:18 [patch 0/2] BaseTools/VfrCompile: Add two new option for VfrCompile Dandan Bi
2016-08-01 11:18 ` Dandan Bi [this message]
2016-08-01 11:18 ` [patch 2/2] " Dandan Bi
2016-08-08  2:21 ` [patch 0/2] " Zhu, Yonghong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1470050311-68144-2-git-send-email-dandan.bi@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox