public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Shi, Steven" <steven.shi@intel.com>
To: edk2-devel@lists.01.org, liming.gao@intel.com, jaben.carsey@intel.com
Cc: afish@apple.com, michael.d.kinney@intel.com,
	ard.biesheuvel@linaro.org, Steven Shi <steven.shi@intel.com>
Subject: [PATCH v5 1/4] BaseTools-Conf:Remove short dash in ar flag for LLVM
Date: Wed,  3 Aug 2016 17:43:03 +0800	[thread overview]
Message-ID: <1470217386-20676-2-git-send-email-steven.shi@intel.com> (raw)
In-Reply-To: <1470217386-20676-1-git-send-email-steven.shi@intel.com>

Both binutils ar and LLVM ar support "cr", but LLVM ar doens't
support add "-" in the flags, and llvm-ar cannot accept "-cr".
So remove the short dash "-" to make llvm archives work.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Steven Shi <steven.shi@intel.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 BaseTools/Conf/build_rule.template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 mode change 100644 => 100755 BaseTools/Conf/build_rule.template

diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template
old mode 100644
new mode 100755
index 9adf391..6e7b7d4
--- a/BaseTools/Conf/build_rule.template
+++ b/BaseTools/Conf/build_rule.template
@@ -266,7 +266,7 @@
         "$(SLINK)" $(SLINK_FLAGS) /OUT:${dst} @$(OBJECT_FILES_LIST)
 
     <Command.GCC, Command.GCCLD>
-        "$(SLINK)" -cr ${dst} $(SLINK_FLAGS) @$(OBJECT_FILES_LIST)
+        "$(SLINK)" cr ${dst} $(SLINK_FLAGS) @$(OBJECT_FILES_LIST)
     
     <Command.RVCT>
         "$(SLINK)" $(SLINK_FLAGS) ${dst} --via $(OBJECT_FILES_LIST)
-- 
2.7.4



  reply	other threads:[~2016-08-03  9:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-03  9:43 [PATCH v5 0/4] Introduce CLANG38 toolchain in edk2 Shi, Steven
2016-08-03  9:43 ` Shi, Steven [this message]
2016-08-03  9:43 ` [PATCH v5 2/4] BaseTools-Conf:Introduce CLANG38 new toolchain for x86 Shi, Steven
2016-08-10  4:54   ` Gao, Liming
2016-08-03  9:43 ` [PATCH v5 3/4] ShellPkg-UefiShellTftpCommandLib: Replace compiler builtin Shi, Steven
2016-08-03  9:43 ` [PATCH v5 4/4] ShellPkg-UefiShellCommandLib: Add EFIAPI in VA_List library function Shi, Steven
2016-08-03 16:56 ` [PATCH v5 0/4] Introduce CLANG38 toolchain in edk2 Carsey, Jaben

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1470217386-20676-2-git-send-email-steven.shi@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox