public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] PcdBdsLinuxSupport default value
@ 2016-08-03 23:10 Daniil Egranov
  2016-08-04 13:51 ` Leif Lindholm
  0 siblings, 1 reply; 2+ messages in thread
From: Daniil Egranov @ 2016-08-03 23:10 UTC (permalink / raw)
  To: edk2-devel; +Cc: leif.lindholm, Daniil Egranov

The built-in Linux Loader is obsolete and not included in most builds.
The patch sets the PcdBdsLinuxSupport default value to FALSE and prevents
ArmBds from looking for built-in Linux Loader by default and ASSERTing 
when it cannot be found. Platforms which still using built-in loader have
to set this PCD in their platform description file.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Daniil Egranov <daniil.egranov@arm.com>
---
 ArmPlatformPkg/ArmPlatformPkg.dec | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec
index 5864d98..d756fd2 100644
--- a/ArmPlatformPkg/ArmPlatformPkg.dec
+++ b/ArmPlatformPkg/ArmPlatformPkg.dec
@@ -55,7 +55,7 @@
   gArmPlatformTokenSpaceGuid.PcdGopDisableOnExitBootServices|FALSE|BOOLEAN|0x0000003D

   # Enable Legacy Linux support in the BDS
-  gArmPlatformTokenSpaceGuid.PcdBdsLinuxSupport|TRUE|BOOLEAN|0x0000002E
+  gArmPlatformTokenSpaceGuid.PcdBdsLinuxSupport|FALSE|BOOLEAN|0x0000002E

 [PcdsFixedAtBuild.common]
   gArmPlatformTokenSpaceGuid.PcdCoreCount|1|UINT32|0x00000039
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] PcdBdsLinuxSupport default value
  2016-08-03 23:10 [PATCH] PcdBdsLinuxSupport default value Daniil Egranov
@ 2016-08-04 13:51 ` Leif Lindholm
  0 siblings, 0 replies; 2+ messages in thread
From: Leif Lindholm @ 2016-08-04 13:51 UTC (permalink / raw)
  To: Daniil Egranov; +Cc: edk2-devel

On Wed, Aug 03, 2016 at 06:10:48PM -0500, Daniil Egranov wrote:
> The built-in Linux Loader is obsolete and not included in most builds.
> The patch sets the PcdBdsLinuxSupport default value to FALSE and prevents
> ArmBds from looking for built-in Linux Loader by default and ASSERTing 
> when it cannot be found. Platforms which still using built-in loader have
> to set this PCD in their platform description file.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Daniil Egranov <daniil.egranov@arm.com>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed (with a tweak to the subject line), thanks!

> ---
>  ArmPlatformPkg/ArmPlatformPkg.dec | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec
> index 5864d98..d756fd2 100644
> --- a/ArmPlatformPkg/ArmPlatformPkg.dec
> +++ b/ArmPlatformPkg/ArmPlatformPkg.dec
> @@ -55,7 +55,7 @@
>    gArmPlatformTokenSpaceGuid.PcdGopDisableOnExitBootServices|FALSE|BOOLEAN|0x0000003D
> 
>    # Enable Legacy Linux support in the BDS
> -  gArmPlatformTokenSpaceGuid.PcdBdsLinuxSupport|TRUE|BOOLEAN|0x0000002E
> +  gArmPlatformTokenSpaceGuid.PcdBdsLinuxSupport|FALSE|BOOLEAN|0x0000002E
> 
>  [PcdsFixedAtBuild.common]
>    gArmPlatformTokenSpaceGuid.PcdCoreCount|1|UINT32|0x00000039
> -- 
> 2.7.4
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-08-04 13:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-03 23:10 [PATCH] PcdBdsLinuxSupport default value Daniil Egranov
2016-08-04 13:51 ` Leif Lindholm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox