public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [patch] MdeModulePkg/DriverSample: Skip the character "&" before "OFFSET="
@ 2016-08-10  3:10 Dandan Bi
  2016-08-10 10:02 ` Gao, Liming
  0 siblings, 1 reply; 2+ messages in thread
From: Dandan Bi @ 2016-08-10  3:10 UTC (permalink / raw)
  To: edk2-devel; +Cc: Liming Gao, Eric Dong

When comparing the L"OFFSET=" with the ConfigResp string to find
all the "OFFSET=" in ConfigResp, should skip the character "&"
before "OFFSET=" in ConfigResp string.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
---
 MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c b/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c
index 9c5d4bb..ea6b124 100644
--- a/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c
+++ b/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c
@@ -776,10 +776,15 @@ AppendAltCfgString (
       return;
     }
     StringPtr += Length;
 
     //
+    // Skip the character "&" before "OFFSET".
+    //
+    StringPtr ++;
+
+    //
     // Calculate Value and convert it to hex string.
     //
     if (Offset + Width > BlockSize) {
       return;
     }
-- 
1.9.5.msysgit.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [patch] MdeModulePkg/DriverSample: Skip the character "&" before "OFFSET="
  2016-08-10  3:10 [patch] MdeModulePkg/DriverSample: Skip the character "&" before "OFFSET=" Dandan Bi
@ 2016-08-10 10:02 ` Gao, Liming
  0 siblings, 0 replies; 2+ messages in thread
From: Gao, Liming @ 2016-08-10 10:02 UTC (permalink / raw)
  To: Bi, Dandan, edk2-devel@lists.01.org; +Cc: Dong, Eric

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Bi, Dandan
> Sent: Wednesday, August 10, 2016 11:11 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>; Dong, Eric <eric.dong@intel.com>
> Subject: [patch] MdeModulePkg/DriverSample: Skip the character "&"
> before "OFFSET="
> 
> When comparing the L"OFFSET=" with the ConfigResp string to find
> all the "OFFSET=" in ConfigResp, should skip the character "&"
> before "OFFSET=" in ConfigResp string.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> Reviewed-by: Eric Dong <eric.dong@intel.com>
> ---
>  MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c
> b/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c
> index 9c5d4bb..ea6b124 100644
> --- a/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c
> +++ b/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c
> @@ -776,10 +776,15 @@ AppendAltCfgString (
>        return;
>      }
>      StringPtr += Length;
> 
>      //
> +    // Skip the character "&" before "OFFSET".
> +    //
> +    StringPtr ++;
> +
> +    //
>      // Calculate Value and convert it to hex string.
>      //
>      if (Offset + Width > BlockSize) {
>        return;
>      }
> --
> 1.9.5.msysgit.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-08-10 10:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-10  3:10 [patch] MdeModulePkg/DriverSample: Skip the character "&" before "OFFSET=" Dandan Bi
2016-08-10 10:02 ` Gao, Liming

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox