* [patch] BaseTool/VfrCompile: Remove reset button opcode in CheckQuestionOpCode
@ 2016-08-10 8:53 Dandan Bi
2016-08-11 7:16 ` Dong, Eric
0 siblings, 1 reply; 2+ messages in thread
From: Dandan Bi @ 2016-08-10 8:53 UTC (permalink / raw)
To: edk2-devel; +Cc: Liming Gao, Eric Dong
"EFI_IFR_RESET_BUTTON_OP" is a statement, not a question,
so remove it from function CheckQuestionOpCode.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp | 1 -
1 file changed, 1 deletion(-)
diff --git a/BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp b/BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp
index db1e4bd..0b7b8b1 100644
--- a/BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp
+++ b/BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp
@@ -1199,11 +1199,10 @@ CIfrRecordInfoDB::CheckQuestionOpCode (
case EFI_IFR_STRING_OP:
case EFI_IFR_DATE_OP:
case EFI_IFR_TIME_OP:
case EFI_IFR_ORDERED_LIST_OP:
case EFI_IFR_REF_OP:
- case EFI_IFR_RESET_BUTTON_OP:
return TRUE;
default:
return FALSE;
}
}
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] BaseTool/VfrCompile: Remove reset button opcode in CheckQuestionOpCode
2016-08-10 8:53 [patch] BaseTool/VfrCompile: Remove reset button opcode in CheckQuestionOpCode Dandan Bi
@ 2016-08-11 7:16 ` Dong, Eric
0 siblings, 0 replies; 2+ messages in thread
From: Dong, Eric @ 2016-08-11 7:16 UTC (permalink / raw)
To: Bi, Dandan, edk2-devel@lists.01.org; +Cc: Gao, Liming
Reviewed-by: Eric Dong <eric.dong@intel.com>
> -----Original Message-----
> From: Bi, Dandan
> Sent: Wednesday, August 10, 2016 4:54 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming; Dong, Eric
> Subject: [patch] BaseTool/VfrCompile: Remove reset button opcode in CheckQuestionOpCode
>
> "EFI_IFR_RESET_BUTTON_OP" is a statement, not a question,
> so remove it from function CheckQuestionOpCode.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp b/BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp
> index db1e4bd..0b7b8b1 100644
> --- a/BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp
> +++ b/BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp
> @@ -1199,11 +1199,10 @@ CIfrRecordInfoDB::CheckQuestionOpCode (
> case EFI_IFR_STRING_OP:
> case EFI_IFR_DATE_OP:
> case EFI_IFR_TIME_OP:
> case EFI_IFR_ORDERED_LIST_OP:
> case EFI_IFR_REF_OP:
> - case EFI_IFR_RESET_BUTTON_OP:
> return TRUE;
> default:
> return FALSE;
> }
> }
> --
> 1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-11 7:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-10 8:53 [patch] BaseTool/VfrCompile: Remove reset button opcode in CheckQuestionOpCode Dandan Bi
2016-08-11 7:16 ` Dong, Eric
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox