From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by ml01.01.org (Postfix) with ESMTP id 212A71A1E29 for ; Wed, 10 Aug 2016 10:33:03 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP; 10 Aug 2016 10:33:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,501,1464678000"; d="scan'208";a="153758925" Received: from jlkim-mobl.amr.corp.intel.com (HELO localhost) ([10.252.133.128]) by fmsmga004.fm.intel.com with ESMTP; 10 Aug 2016 10:33:02 -0700 MIME-Version: 1.0 To: Ruiyu Ni , edk2-devel@lists.01.org Message-ID: <147085038216.19680.17963102819835257407@jljusten-ivb> From: Jordan Justen In-Reply-To: <20160810055611.266232-12-ruiyu.ni@intel.com> Cc: "Feng Tian" , "Amy Chan" References: <20160810055611.266232-1-ruiyu.ni@intel.com> <20160810055611.266232-12-ruiyu.ni@intel.com> User-Agent: alot/0.3.7 Date: Wed, 10 Aug 2016 10:33:02 -0700 Subject: Re: [PATCH 11/11] MdeModulePkg/ResetSystemRuntimeDxe: Support EfiResetPlatformSpecific X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Aug 2016 17:33:03 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2016-08-09 22:56:11, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni > Cc: Feng Tian > Cc: Amy Chan > --- > MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c | 14 ++++++++= +++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > = > diff --git a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c b= /MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > index aa1ca16..f61e65e 100644 > --- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > +++ b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > @@ -1,7 +1,7 @@ > /** @file > Reset Architectural Protocol implementation > = > - Copyright (c) 2006 - 2012, Intel Corporation. All rights reserved.
> + Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
> = > This program and the accompanying materials > are licensed and made available under the terms and conditions of the = BSD License > @@ -86,11 +86,15 @@ DoS3 ( > = > @param[in] ResetType The type of reset to perform. > @param[in] ResetStatus The status code for the reset. > - @param[in] DataSize The size, in bytes, of WatchdogData. > + @param[in] DataSize The size, in bytes, of ResetData. > @param[in] ResetData For a ResetType of EfiResetCold, EfiRese= tWarm, or > EfiResetShutdown the data buffer starts = with a Null-terminated > string, optionally followed by additiona= l binary data. > - > + The string is a description that the cal= ler may use to further > + indicate the reason for the system reset= . ResetData is only > + valid if ResetStatus is something other = than EFI_SUCCESS > + unless the ResetType is EfiResetPlatform= Specific > + where a minimum amount of ResetData is a= lways required. Most of the patches in this series have lines that are longer than 80 columns. Can you fix that? I think you should move patch 11 before patch 09 "OvmfPkg: Use MdeModulePkg/ResetSystemRuntimeDxe". I think this should allow reset to continue working through the entire series for OVMF. (right?) With those changes, Series Reviewed-by: Jordan Justen > **/ > VOID > EFIAPI > @@ -144,6 +148,10 @@ ResetSystem ( > ResetShutdown (); > return ; > = > + case EfiResetPlatformSpecific: > + ResetPlatformSpecific (DataSize, ResetData); > + return; > + > default: > return ; > } > -- = > 2.9.0.windows.1 > = > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel