From: Jordan Justen <jordan.l.justen@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Tian, Feng" <feng.tian@intel.com>, "Chan, Amy" <amy.chan@intel.com>
Subject: Re: [PATCH 11/11] MdeModulePkg/ResetSystemRuntimeDxe: Support EfiResetPlatformSpecific
Date: Wed, 10 Aug 2016 23:05:38 -0700 [thread overview]
Message-ID: <147089553827.3499.1443547713216811039@jljusten-ivb> (raw)
In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D1ADB687A@SHSMSX103.ccr.corp.intel.com>
On 2016-08-10 19:43:03, Ni, Ruiyu wrote:
>
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Jordan Justen
> >
> > On 2016-08-09 22:56:11, Ruiyu Ni wrote:
> > > + indicate the reason for the system reset. ResetData is only
> > > + valid if ResetStatus is something other than EFI_SUCCESS
> > > + unless the ResetType is EfiResetPlatformSpecific
> > > + where a minimum amount of ResetData is always
> > required.
> >
> > Most of the patches in this series have lines that are longer than 80 columns.
> > Can you fix that?
>
> Do we have rule to limit the line to 80 columns? I saw many files have long
> lines.
> Or I can change OvmfPkg changes to follow the 80 rule. What do you think?
Yes, it is in the code style document. You should update all patches
for it. It looks like most of them will just be copy/paste.
>
> >
> > I think you should move patch 11 before patch 09 "OvmfPkg: Use
> > MdeModulePkg/ResetSystemRuntimeDxe". I think this should allow reset to
> > continue working through the entire series for OVMF. (right?)
>
> Reset works using my current order.
> But I agree moving #11 before #9 can move ResetPlatformSpecific support
> earilier, and group the ResetPlatformSpecific patches together. I will do that.
Oh, I see. I guess this patch updates the ResetPlatformSpecific type,
so it probably won't be too important for OVMF. I think it might be a
little better earlier, but you can decide if you want to move it or
not.
-Jordan
prev parent reply other threads:[~2016-08-11 6:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 5:56 [PATCH 00/11] Add ResetPlatformSpecific() to ResetSystemLib Ruiyu Ni
2016-08-10 5:56 ` [PATCH 01/11] MdePkg/UefiSpec.h: Align function header of ResetSystem to UEFI Spec Ruiyu Ni
2016-08-16 4:49 ` Gao, Liming
2016-08-10 5:56 ` [PATCH 02/11] MdeModulePkg: Add API ResetPlatformSpecific() to ResetSystemLib.h Ruiyu Ni
2016-08-10 5:56 ` [PATCH 03/11] MdeModulePkg/BaseResetSystemLibNull: Implement ResetPlatformSpecific Ruiyu Ni
2016-08-23 3:21 ` Tian, Feng
2016-08-23 4:56 ` Ni, Ruiyu
2016-08-10 5:56 ` [PATCH 04/11] CorebootPayloadPkg/ResetSystemLib: " Ruiyu Ni
2016-08-11 16:09 ` Ma, Maurice
2016-08-10 5:56 ` [PATCH 05/11] OvmfPkg/ResetSystemLib: " Ruiyu Ni
2016-08-10 5:56 ` [PATCH 06/11] PcAtChipsetPkg/ResetSystemLib: " Ruiyu Ni
2016-08-10 5:56 ` [PATCH 07/11] QuarkSocPkg/ResetSystemLib: " Ruiyu Ni
2016-08-10 16:28 ` Kinney, Michael D
2016-08-10 5:56 ` [PATCH 08/11] Vlv2TbltDevicePkg/ResetSystemLib: " Ruiyu Ni
2016-08-11 2:22 ` Wei, David
2016-08-10 5:56 ` [PATCH 09/11] OvmfPkg: Use MdeModulePkg/ResetSystemRuntimeDxe Ruiyu Ni
2016-08-10 5:56 ` [PATCH 10/11] PcAtChipsetPkg: Remove KbcResetDxe Ruiyu Ni
2016-08-10 5:56 ` [PATCH 11/11] MdeModulePkg/ResetSystemRuntimeDxe: Support EfiResetPlatformSpecific Ruiyu Ni
2016-08-10 17:33 ` Jordan Justen
2016-08-11 2:43 ` Ni, Ruiyu
2016-08-11 6:05 ` Jordan Justen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=147089553827.3499.1443547713216811039@jljusten-ivb \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox