public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Jordan Justen <jordan.l.justen@intel.com>
To: Eric Dong <eric.dong@intel.com>,  edk2-devel@lists.01.org
Cc: "Cecil Sheng" <cecil.sheng@hpe.com>, "Liming Gao" <liming.gao@intel.com>
Subject: Re: [Patch] MdePkg: Fix guid conflict.
Date: Tue, 16 Aug 2016 00:04:16 -0700	[thread overview]
Message-ID: <147133105679.1449.12789083525217772059@jljusten-ivb> (raw)
In-Reply-To: <1470967788-23324-1-git-send-email-eric.dong@intel.com>

Some notes for future reference, since this is already committed.

I think subject should have been something like:

MdePkg/ImageDecoder: Fix GUID conflict with PCI Root Bridge Protocol

When browsing commits with just the subject line, you should have a
good idea of what the commit is about. (For example: gitk, or tig, or
git log --oneline)

On 2016-08-11 19:09:48, Eric Dong wrote:
> -  { 0x2f707ebb, 0x4a1a, 0x11d4, {0x9a,0x38,0x00,0x90,0x27,0x3f,0xc1,0x4d}}
> +  {0x9e66f251, 0x727c, 0x418c, { 0xbf, 0xd6, 0xc2, 0xb4, 0x25, 0x28, 0x18, 0xea }}

Should have a space before 0x9e66f251.

>    ## Include/Guid/MemoryOverwriteControl.h
>    gEfiMemoryOverwriteControlDataGuid = { 0xe20939be, 0x32d4, 0x41be, {0xa1, 0x50, 0x89, 0x7f, 0x85, 0xd4, 0x98, 0x29 }}
> -  
> +
>    ## Include/IndustryStandard/MemoryOverwriteRequestControlLock.h
>    gEfiMemoryOverwriteRequestControlLockGuid = { 0xBB983CCF, 0x151D, 0x40E1, {0xA0, 0x7B, 0x4A, 0x17, 0xBE, 0x16, 0x82, 0x92}}
>  
> @@ -1384,7 +1384,7 @@
>  
>    ## Include/Protocol/TrEEProtocol.h
>    gEfiTrEEProtocolGuid           = {0x607f766c, 0x7455, 0x42be, { 0x93, 0x0b, 0xe4, 0xd7, 0x6d, 0xb2, 0x72, 0x0f }}
> -  
> +

I don't think we need to update lines that are unrelated to the patch.
It just distracts from the change.

-Jordan


      parent reply	other threads:[~2016-08-16  7:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-12  2:09 [Patch] MdePkg: Fix guid conflict Eric Dong
2016-08-16  2:03 ` Gao, Liming
2016-08-16  7:04 ` Jordan Justen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=147133105679.1449.12789083525217772059@jljusten-ivb \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox