[patch] ShellPkg: Fix the incorrect return status in function FindFiles()

[patch] ShellPkg: Fix the incorrect return status in function FindFiles()

[Dandan Bi]

According to the latest shell spec, in function FindFiles(),
when no files were found, it should return EFI_NOT_FOUND.
But current codes don't follow the spec.
This patch is to fix this issue.

Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 ShellPkg/Application/Shell/ShellProtocol.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/ShellPkg/Application/Shell/ShellProtocol.c b/ShellPkg/Application/Shell/ShellProtocol.c
index 0e5d954..6f29250 100644
--- a/ShellPkg/Application/Shell/ShellProtocol.c
+++ b/ShellPkg/Application/Shell/ShellProtocol.c
@@ -2507,10 +2507,14 @@ ShellSearchHandle(
         Status = EfiShellFreeFileList(&ShellInfo);
       }
     }
   }
 
+  if (*FileList == NULL || (*FileList != NULL && IsListEmpty(&(*FileList)->Link))) {
+    Status = EFI_NOT_FOUND;
+  }
+
   FreePool(CurrentFilePattern);
   return (Status);
 }
 
 /**
-- 
1.9.5.msysgit.1

Re: [patch] ShellPkg: Fix the incorrect return status in function FindFiles()

[Ni, Ruiyu]

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> -----Original Message-----
> From: Bi, Dandan
> Sent: Wednesday, August 24, 2016 11:13 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>
> Subject: [patch] ShellPkg: Fix the incorrect return status in function FindFiles()
> 
> According to the latest shell spec, in function FindFiles(), when no files were
> found, it should return EFI_NOT_FOUND.
> But current codes don't follow the spec.
> This patch is to fix this issue.
> 
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  ShellPkg/Application/Shell/ShellProtocol.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/ShellPkg/Application/Shell/ShellProtocol.c
> b/ShellPkg/Application/Shell/ShellProtocol.c
> index 0e5d954..6f29250 100644
> --- a/ShellPkg/Application/Shell/ShellProtocol.c
> +++ b/ShellPkg/Application/Shell/ShellProtocol.c
> @@ -2507,10 +2507,14 @@ ShellSearchHandle(
>          Status = EfiShellFreeFileList(&ShellInfo);
>        }
>      }
>    }
> 
> +  if (*FileList == NULL || (*FileList != NULL && IsListEmpty(&(*FileList)-
> >Link))) {
> +    Status = EFI_NOT_FOUND;
> +  }
> +
>    FreePool(CurrentFilePattern);
>    return (Status);
>  }
> 
>  /**
> --
> 1.9.5.msysgit.1