Re: [PATCH] Platforms/ARM/Juno: limit ACPI support to v5.0 and higher

Re: [PATCH] Platforms/ARM/Juno: limit ACPI support to v5.0 and higher

[Sudeep Holla]

Hi Evan,

On 27/07/16 15:23, Leif Lindholm wrote:
> Looks sensible to me.
>
> Unless Evan has any objections?
>
> On 27 July 2016 at 10:53, Sudeep Holla <sudeep.holla@arm.com> wrote:
>> The ACPI spec predates the AARCH64 architecture by 5 versions, so there
>> is no point in supporting anything below v5.0. So set the PCD that
>> controls the ACPI table generation to the appropriate value.
>>
>> Based on the commit e0692789058e ("ArmVirtPkg/ArmVirtQemu: limit ACPI
>> support to v5.0 and higher") in the upstream TianoCore by Ard Biesheuvel
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org>
>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>> ---
>>  Platforms/ARM/Juno/ArmJuno.dsc | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/Platforms/ARM/Juno/ArmJuno.dsc b/Platforms/ARM/Juno/ArmJuno.dsc
>> index 45d9950decba..2e9ccfbad396 100644
>> --- a/Platforms/ARM/Juno/ArmJuno.dsc
>> +++ b/Platforms/ARM/Juno/ArmJuno.dsc
>> @@ -174,6 +174,8 @@
>>    gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
>>    gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 }
>>
>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20
>> +
>>  [PcdsPatchableInModule]
>>    # Console Resolution (Full HD)
>>    gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|1920


And any feedback on this too ?

-- 
Regards,
Sudeep

[PATCH] Platforms/ARM/Juno: limit ACPI support to v5.0 and higher

[Sudeep Holla]

The ACPI spec predates the AARCH64 architecture by 5 versions, so there
is no point in supporting anything below v5.0. So set the PCD that
controls the ACPI table generation to the appropriate value.

Based on the commit e0692789058e ("ArmVirtPkg/ArmVirtQemu: limit ACPI
support to v5.0 and higher") in the upstream TianoCore by Ard Biesheuvel

Contributed-under: TianoCore Contribution Agreement 1.0
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Evan Lloyd <Evan.Lloyd@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 Platforms/ARM/Juno/ArmJuno.dsc | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Platforms/ARM/Juno/ArmJuno.dsc b/Platforms/ARM/Juno/ArmJuno.dsc
index c51d8f2e21ab..3029999bc66f 100644
--- a/Platforms/ARM/Juno/ArmJuno.dsc
+++ b/Platforms/ARM/Juno/ArmJuno.dsc
@@ -183,6 +183,10 @@
   #
   gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosVersion|0x0300
   gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosDocRev|0x0
+  #
+  # ACPI Table Version
+  #
+  gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20
 
 [PcdsPatchableInModule]
   # Console Resolution (Full HD)
-- 
2.7.4

Re: [PATCH] Platforms/ARM/Juno: limit ACPI support to v5.0 and higher

[Evan Lloyd]

>-----Original Message-----
>From: Sudeep Holla [mailto:sudeep.holla@arm.com]
>Sent: 25 August 2016 18:09
>To: edk2-devel@lists.01.org; Linaro UEFI; Evan Lloyd; Leif Lindholm
>Cc: Sudeep Holla; ard.biesheuvel@linaro.org
>Subject: [PATCH] Platforms/ARM/Juno: limit ACPI support to v5.0 and higher
>
>The ACPI spec predates the AARCH64 architecture by 5 versions, so there
>is no point in supporting anything below v5.0. So set the PCD that
>controls the ACPI table generation to the appropriate value.
>
>Based on the commit e0692789058e ("ArmVirtPkg/ArmVirtQemu: limit ACPI
>support to v5.0 and higher") in the upstream TianoCore by Ard Biesheuvel
>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>Cc: Leif Lindholm <leif.lindholm@linaro.org>
>Cc: Evan Lloyd <Evan.Lloyd@arm.com>
>Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>---
> Platforms/ARM/Juno/ArmJuno.dsc | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/Platforms/ARM/Juno/ArmJuno.dsc
>b/Platforms/ARM/Juno/ArmJuno.dsc
>index c51d8f2e21ab..3029999bc66f 100644
>--- a/Platforms/ARM/Juno/ArmJuno.dsc
>+++ b/Platforms/ARM/Juno/ArmJuno.dsc
>@@ -183,6 +183,10 @@
>   #
>   gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosVersion|0x0300
>   gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosDocRev|0x0
>+  #
>+  # ACPI Table Version
>+  #
>+  gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20
>
> [PcdsPatchableInModule]
>   # Console Resolution (Full HD)
>--
>2.7.4
Reviewed-by: Evan Lloyd <Evan.Lloyd@arm.com>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: [PATCH] Platforms/ARM/Juno: limit ACPI support to v5.0 and higher

[Ard Biesheuvel]

On 31 August 2016 at 11:29, Evan Lloyd <Evan.Lloyd@arm.com> wrote:
>
>>-----Original Message-----
>>From: Sudeep Holla [mailto:sudeep.holla@arm.com]
>>Sent: 25 August 2016 18:09
>>To: edk2-devel@lists.01.org; Linaro UEFI; Evan Lloyd; Leif Lindholm
>>Cc: Sudeep Holla; ard.biesheuvel@linaro.org
>>Subject: [PATCH] Platforms/ARM/Juno: limit ACPI support to v5.0 and higher
>>
>>The ACPI spec predates the AARCH64 architecture by 5 versions, so there
>>is no point in supporting anything below v5.0. So set the PCD that
>>controls the ACPI table generation to the appropriate value.
>>
>>Based on the commit e0692789058e ("ArmVirtPkg/ArmVirtQemu: limit ACPI
>>support to v5.0 and higher") in the upstream TianoCore by Ard Biesheuvel
>>
>>Contributed-under: TianoCore Contribution Agreement 1.0
>>Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>Cc: Leif Lindholm <leif.lindholm@linaro.org>
>>Cc: Evan Lloyd <Evan.Lloyd@arm.com>
>>Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>>---
>> Platforms/ARM/Juno/ArmJuno.dsc | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>>diff --git a/Platforms/ARM/Juno/ArmJuno.dsc
>>b/Platforms/ARM/Juno/ArmJuno.dsc
>>index c51d8f2e21ab..3029999bc66f 100644
>>--- a/Platforms/ARM/Juno/ArmJuno.dsc
>>+++ b/Platforms/ARM/Juno/ArmJuno.dsc
>>@@ -183,6 +183,10 @@
>>   #
>>   gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosVersion|0x0300
>>   gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosDocRev|0x0
>>+  #
>>+  # ACPI Table Version
>>+  #
>>+  gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20
>>
>> [PcdsPatchableInModule]
>>   # Console Resolution (Full HD)
>>--
>>2.7.4
> Reviewed-by: Evan Lloyd <Evan.Lloyd@arm.com>
>

Pushed, thanks.