* [PATCH 0/3] Use IsZeroGuid API for zero GUID checking
@ 2016-08-30 2:36 Hao Wu
2016-08-30 2:36 ` [PATCH 1/3] IntelFrameworkModulePkg: " Hao Wu
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Hao Wu @ 2016-08-30 2:36 UTC (permalink / raw)
To: edk2-devel, liming.gao; +Cc: Hao Wu
To check if the given GUID is a zero GUID, current codes use the
CompareGuid() API (from BaseMemoryLib) with gZeroGuid.
This series will use the IsZeroGuid() API (also from BaseMemoryLib)
instead to do this check.
Hao Wu (3):
IntelFrameworkModulePkg: Use IsZeroGuid API for zero GUID checking
MdeModulePkg: Use IsZeroGuid API for zero GUID checking
SecurityPkg: Use IsZeroGuid API for zero GUID checking
IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.c | 4 ++--
IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.h | 4 +---
IntelFrameworkModulePkg/Universal/DataHubDxe/DataHubDxe.inf | 6 +-----
MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c | 3 +--
MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.inf | 1 -
MdeModulePkg/Core/Dxe/DxeMain.h | 1 -
MdeModulePkg/Core/Dxe/DxeMain.inf | 1 -
MdeModulePkg/Core/PiSmmCore/PiSmmCore.h | 1 -
MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf | 1 -
MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c | 4 ++--
MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h | 1 -
MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 -
MdeModulePkg/Library/VarCheckHiiLib/VarCheckHii.h | 4 +---
MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiGenFromFv.c | 6 +++---
MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiLib.inf | 3 ---
MdeModulePkg/Universal/SetupBrowserDxe/Expression.c | 2 +-
MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c | 8 ++++----
MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 4 ++--
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c | 5 ++---
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf | 1 -
SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c | 7 +++----
.../Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.inf | 3 +--
SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c | 5 ++---
SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.inf | 3 +--
24 files changed, 27 insertions(+), 52 deletions(-)
--
1.9.5.msysgit.0
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 1/3] IntelFrameworkModulePkg: Use IsZeroGuid API for zero GUID checking 2016-08-30 2:36 [PATCH 0/3] Use IsZeroGuid API for zero GUID checking Hao Wu @ 2016-08-30 2:36 ` Hao Wu 2016-08-30 5:54 ` Fan, Jeff 2016-08-30 2:36 ` [PATCH 2/3] MdeModulePkg: " Hao Wu 2016-08-30 2:36 ` [PATCH 3/3] SecurityPkg: " Hao Wu 2 siblings, 1 reply; 7+ messages in thread From: Hao Wu @ 2016-08-30 2:36 UTC (permalink / raw) To: edk2-devel, liming.gao; +Cc: Hao Wu, Jeff Fan Instead of comparing a GUID with gZeroGuid via the CompareGuid API, the commit uses the IsZeroGuid API to check if the given GUID is a zero GUID. Cc: Jeff Fan <jeff.fan@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu <hao.a.wu@intel.com> --- IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.c | 4 ++-- IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.h | 4 +--- IntelFrameworkModulePkg/Universal/DataHubDxe/DataHubDxe.inf | 6 +----- 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.c b/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.c index 91f7c7e..916586f 100644 --- a/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.c +++ b/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.c @@ -2,7 +2,7 @@ This code produces the Data Hub protocol. It preloads the data hub with status information copied in from PEI HOBs. -Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR> +Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -139,7 +139,7 @@ DataHubLogData ( for (Link = GetFirstNode(Head); Link != Head; Link = GetNextNode(Head, Link)) { FilterEntry = FILTER_ENTRY_FROM_LINK (Link); if (((FilterEntry->ClassFilter & DataRecordClass) != 0) && - (CompareGuid (&FilterEntry->FilterDataRecordGuid, &gZeroGuid) || + (IsZeroGuid (&FilterEntry->FilterDataRecordGuid) || CompareGuid (&FilterEntry->FilterDataRecordGuid, DataRecordGuid))) { gBS->SignalEvent (FilterEntry->Event); } diff --git a/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.h b/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.h index de2e3f3..7770c43 100644 --- a/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.h +++ b/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.h @@ -2,7 +2,7 @@ This code supports a the private implementation of the Data Hub protocol -Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR> +Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -21,8 +21,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #include <Protocol/DataHub.h> -#include <Guid/ZeroGuid.h> - #include <Library/DebugLib.h> #include <Library/UefiDriverEntryPoint.h> #include <Library/UefiLib.h> diff --git a/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHubDxe.inf b/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHubDxe.inf index 834c3b3..0b93f71 100644 --- a/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHubDxe.inf +++ b/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHubDxe.inf @@ -21,7 +21,7 @@ # drivers to be aware of all reporting formats. # For more information, please ref http://www.intel.com/technology/framework/ # -# Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR> +# Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR> # # This program and the accompanying materials # are licensed and made available under the terms and conditions of the BSD License @@ -70,10 +70,6 @@ DebugLib -[Guids] - gZeroGuid ## SOMETIMES_CONSUMES ## GUID - - [Protocols] gEfiDataHubProtocolGuid ## PRODUCES -- 1.9.5.msysgit.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] IntelFrameworkModulePkg: Use IsZeroGuid API for zero GUID checking 2016-08-30 2:36 ` [PATCH 1/3] IntelFrameworkModulePkg: " Hao Wu @ 2016-08-30 5:54 ` Fan, Jeff 0 siblings, 0 replies; 7+ messages in thread From: Fan, Jeff @ 2016-08-30 5:54 UTC (permalink / raw) To: Wu, Hao A, edk2-devel@lists.01.org, Gao, Liming Reviewed-by: Jeff Fan <jeff.fan@intel.com> -----Original Message----- From: Wu, Hao A Sent: Tuesday, August 30, 2016 10:36 AM To: edk2-devel@lists.01.org; Gao, Liming Cc: Wu, Hao A; Fan, Jeff Subject: [PATCH 1/3] IntelFrameworkModulePkg: Use IsZeroGuid API for zero GUID checking Instead of comparing a GUID with gZeroGuid via the CompareGuid API, the commit uses the IsZeroGuid API to check if the given GUID is a zero GUID. Cc: Jeff Fan <jeff.fan@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu <hao.a.wu@intel.com> --- IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.c | 4 ++-- IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.h | 4 +--- IntelFrameworkModulePkg/Universal/DataHubDxe/DataHubDxe.inf | 6 +----- 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.c b/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.c index 91f7c7e..916586f 100644 --- a/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.c +++ b/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.c @@ -2,7 +2,7 @@ This code produces the Data Hub protocol. It preloads the data hub with status information copied in from PEI HOBs. -Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR> +Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -139,7 +139,7 @@ DataHubLogData ( for (Link = GetFirstNode(Head); Link != Head; Link = GetNextNode(Head, Link)) { FilterEntry = FILTER_ENTRY_FROM_LINK (Link); if (((FilterEntry->ClassFilter & DataRecordClass) != 0) && - (CompareGuid (&FilterEntry->FilterDataRecordGuid, &gZeroGuid) || + (IsZeroGuid (&FilterEntry->FilterDataRecordGuid) || CompareGuid (&FilterEntry->FilterDataRecordGuid, DataRecordGuid))) { gBS->SignalEvent (FilterEntry->Event); } diff --git a/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.h b/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.h index de2e3f3..7770c43 100644 --- a/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.h +++ b/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.h @@ -2,7 +2,7 @@ This code supports a the private implementation of the Data Hub protocol -Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR> +Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -21,8 +21,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #include <Protocol/DataHub.h> -#include <Guid/ZeroGuid.h> - #include <Library/DebugLib.h> #include <Library/UefiDriverEntryPoint.h> #include <Library/UefiLib.h> diff --git a/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHubDxe.inf b/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHubDxe.inf index 834c3b3..0b93f71 100644 --- a/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHubDxe.inf +++ b/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHubDxe.inf @@ -21,7 +21,7 @@ # drivers to be aware of all reporting formats. # For more information, please ref http://www.intel.com/technology/framework/ # -# Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR> +# Copyright (c) 2006 - 2016, Intel Corporation. All rights +reserved.<BR> # # This program and the accompanying materials # are licensed and made available under the terms and conditions of the BSD License @@ -70,10 +70,6 @@ DebugLib -[Guids] - gZeroGuid ## SOMETIMES_CONSUMES ## GUID - - [Protocols] gEfiDataHubProtocolGuid ## PRODUCES -- 1.9.5.msysgit.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/3] MdeModulePkg: Use IsZeroGuid API for zero GUID checking 2016-08-30 2:36 [PATCH 0/3] Use IsZeroGuid API for zero GUID checking Hao Wu 2016-08-30 2:36 ` [PATCH 1/3] IntelFrameworkModulePkg: " Hao Wu @ 2016-08-30 2:36 ` Hao Wu 2016-08-30 2:43 ` Tian, Feng 2016-08-30 2:36 ` [PATCH 3/3] SecurityPkg: " Hao Wu 2 siblings, 1 reply; 7+ messages in thread From: Hao Wu @ 2016-08-30 2:36 UTC (permalink / raw) To: edk2-devel, liming.gao; +Cc: Hao Wu, Feng Tian, Star Zeng Instead of comparing a GUID with gZeroGuid via the CompareGuid API, the commit uses the IsZeroGuid API to check if the given GUID is a zero GUID. Cc: Feng Tian <feng.tian@intel.com> Cc: Star Zeng <star.zeng@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu <hao.a.wu@intel.com> --- MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c | 3 +-- MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.inf | 1 - MdeModulePkg/Core/Dxe/DxeMain.h | 1 - MdeModulePkg/Core/Dxe/DxeMain.inf | 1 - MdeModulePkg/Core/PiSmmCore/PiSmmCore.h | 1 - MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf | 1 - MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c | 4 ++-- MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h | 1 - MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 - MdeModulePkg/Library/VarCheckHiiLib/VarCheckHii.h | 4 +--- MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiGenFromFv.c | 6 +++--- MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiLib.inf | 3 --- MdeModulePkg/Universal/SetupBrowserDxe/Expression.c | 2 +- MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c | 8 ++++---- MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 4 ++-- MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c | 5 ++--- MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf | 1 - 17 files changed, 16 insertions(+), 31 deletions(-) diff --git a/MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c b/MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c index e82ee9c..14e8934 100644 --- a/MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c +++ b/MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c @@ -27,7 +27,6 @@ #include <Protocol/SmmCommunication.h> #include <Protocol/SmmAccess2.h> -#include <Guid/ZeroGuid.h> #include <Guid/MemoryProfile.h> #include <Guid/PiSmmCommunicationRegionTable.h> @@ -255,7 +254,7 @@ GetDriverNameString ( return mNameString; } - if (!CompareGuid (&DriverInfo->FileName, &gZeroGuid)) { + if (!IsZeroGuid (&DriverInfo->FileName)) { // // Try to get the image's FFS UI section by image GUID // diff --git a/MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.inf b/MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.inf index c512a3f..4bb7a9d 100644 --- a/MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.inf +++ b/MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.inf @@ -52,7 +52,6 @@ ## SOMETIMES_CONSUMES ## GUID # Locate protocol ## SOMETIMES_CONSUMES ## GUID # SmiHandlerRegister gEdkiiMemoryProfileGuid - gZeroGuid ## SOMETIMES_CONSUMES ## GUID gEdkiiPiSmmCommunicationRegionTableGuid ## SOMETIMES_CONSUMES ## SystemTable [Protocols] diff --git a/MdeModulePkg/Core/Dxe/DxeMain.h b/MdeModulePkg/Core/Dxe/DxeMain.h index 60d85f0..aefeeb7 100644 --- a/MdeModulePkg/Core/Dxe/DxeMain.h +++ b/MdeModulePkg/Core/Dxe/DxeMain.h @@ -69,7 +69,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #include <Guid/IdleLoopEvent.h> #include <Guid/VectorHandoffTable.h> #include <Ppi/VectorHandoffInfo.h> -#include <Guid/ZeroGuid.h> #include <Guid/MemoryProfile.h> #include <Library/DxeCoreEntryPoint.h> diff --git a/MdeModulePkg/Core/Dxe/DxeMain.inf b/MdeModulePkg/Core/Dxe/DxeMain.inf index 450da57..13a2381 100644 --- a/MdeModulePkg/Core/Dxe/DxeMain.inf +++ b/MdeModulePkg/Core/Dxe/DxeMain.inf @@ -124,7 +124,6 @@ gEventExitBootServicesFailedGuid ## SOMETIMES_PRODUCES ## Event gEfiVectorHandoffTableGuid ## SOMETIMES_PRODUCES ## SystemTable gEdkiiMemoryProfileGuid ## SOMETIMES_PRODUCES ## GUID # Install protocol - gZeroGuid ## SOMETIMES_CONSUMES ## GUID gEfiPropertiesTableGuid ## SOMETIMES_PRODUCES ## SystemTable gEfiMemoryAttributesTableGuid ## SOMETIMES_PRODUCES ## SystemTable gEfiEndOfDxeEventGroupGuid ## SOMETIMES_CONSUMES ## Event diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.h b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.h index 000864d..f46ee72 100644 --- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.h +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.h @@ -36,7 +36,6 @@ #include <Guid/Apriori.h> #include <Guid/EventGroup.h> #include <Guid/EventLegacyBios.h> -#include <Guid/ZeroGuid.h> #include <Guid/MemoryProfile.h> #include <Library/BaseLib.h> diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf index f7e32c4..1f73cbb 100644 --- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf @@ -96,7 +96,6 @@ gEdkiiMemoryProfileGuid ## SOMETIMES_PRODUCES ## GUID # Install protocol gEdkiiSmmMemoryProfileGuid - gZeroGuid ## SOMETIMES_CONSUMES ## GUID [UserExtensions.TianoCore."ExtraFiles"] PiSmmCoreExtra.uni diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c b/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c index 1e68cbc..ddcee8b 100644 --- a/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c @@ -1,7 +1,7 @@ /** @file Library functions which relates with driver health. -Copyright (c) 2011 - 2015, Intel Corporation. All rights reserved.<BR> +Copyright (c) 2011 - 2016, Intel Corporation. All rights reserved.<BR> (C) Copyright 2015 Hewlett-Packard Development Company, L.P.<BR> (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR> This program and the accompanying materials @@ -446,7 +446,7 @@ BmRepairAllControllers ( // // Configure PcdDriverHealthConfigureForm to ZeroGuid to disable driver health check. // - if (CompareGuid (PcdGetPtr (PcdDriverHealthConfigureForm), &gZeroGuid)) { + if (IsZeroGuid (PcdGetPtr (PcdDriverHealthConfigureForm))) { return; } diff --git a/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h b/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h index 07ee45b..cb719e9 100644 --- a/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h +++ b/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h @@ -45,7 +45,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #include <Protocol/VariableLock.h> #include <Protocol/RamDisk.h> -#include <Guid/ZeroGuid.h> #include <Guid/MemoryTypeInformation.h> #include <Guid/FileInfo.h> #include <Guid/GlobalVariable.h> diff --git a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf index 5d0bd1d..8c3fd7f 100644 --- a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf +++ b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf @@ -87,7 +87,6 @@ gEfiDiskInfoAhciInterfaceGuid ## SOMETIMES_CONSUMES ## GUID gEfiDiskInfoIdeInterfaceGuid ## SOMETIMES_CONSUMES ## GUID gEfiDiskInfoScsiInterfaceGuid ## SOMETIMES_CONSUMES ## GUID - gZeroGuid ## CONSUMES ## GUID [Protocols] gEfiPciRootBridgeIoProtocolGuid ## CONSUMES diff --git a/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHii.h b/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHii.h index d770785..a54b867 100644 --- a/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHii.h +++ b/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHii.h @@ -1,7 +1,7 @@ /** @file Include file for Var Check Hii handler and bin. -Copyright (c) 2015, Intel Corporation. All rights reserved.<BR> +Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -22,8 +22,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #include <Library/UefiBootServicesTableLib.h> #include <Library/MemoryAllocationLib.h> -#include <Guid/ZeroGuid.h> - #include <Protocol/HiiDatabase.h> #include <Protocol/FirmwareVolume2.h> #include <Protocol/FirmwareVolumeBlock.h> diff --git a/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiGenFromFv.c b/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiGenFromFv.c index 21fc80e..71ece27 100644 --- a/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiGenFromFv.c +++ b/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiGenFromFv.c @@ -1,7 +1,7 @@ /** @file Var Check Hii generation from FV. -Copyright (c) 2015, Intel Corporation. All rights reserved.<BR> +Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -372,7 +372,7 @@ CreateVfrDriverList ( UINTN Index; VAR_CHECK_VFR_DRIVER_INFO *VfrDriverInfo; - for (Index = 0; !CompareGuid (&DriverGuidArray[Index], &gZeroGuid); Index++) { + for (Index = 0; !IsZeroGuid (&DriverGuidArray[Index]); Index++) { DEBUG ((EFI_D_INFO, "CreateVfrDriverList: %g\n", &DriverGuidArray[Index])); VfrDriverInfo = InternalVarCheckAllocateZeroPool (sizeof (*VfrDriverInfo)); ASSERT (VfrDriverInfo != NULL); @@ -421,7 +421,7 @@ VarCheckHiiGenFromFv ( // DriverGuidArray = (EFI_GUID *) PcdGetPtr (PcdVarCheckVfrDriverGuidArray); - if (CompareGuid (&DriverGuidArray[0], &gZeroGuid)) { + if (IsZeroGuid (&DriverGuidArray[0])) { // // No VFR driver will be parsed from FVs. // diff --git a/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiLib.inf b/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiLib.inf index 24d24c5..98e6983 100644 --- a/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiLib.inf +++ b/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiLib.inf @@ -46,9 +46,6 @@ PcdLib VarCheckLib -[Guids] - gZeroGuid ## SOMETIMES_CONSUMES ## GUID - [Protocols] gEfiFirmwareVolume2ProtocolGuid ## SOMETIMES_CONSUMES gEfiFirmwareVolumeBlock2ProtocolGuid ## SOMETIMES_CONSUMES diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c b/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c index 1938ff2..ec4d285 100644 --- a/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c @@ -2829,7 +2829,7 @@ EvaluateExpression ( if (StrPtr != NULL) { FreePool (StrPtr); } - } else if (CompareGuid (&OpCode->Guid, &gZeroGuid) != 0) { + } else if (IsZeroGuid (&OpCode->Guid)) { if (!GetQuestionValueFromForm(NULL, FormSet->HiiHandle, &OpCode->Guid, Value->Value.u16, &QuestionVal)){ Value->Type = EFI_IFR_TYPE_UNDEFINED; break; diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c index 56ae7b0..6856cc5 100644 --- a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c @@ -358,7 +358,7 @@ InitializeDisplayStatement ( // // Create the refresh event process function. // - if (!CompareGuid (&Statement->RefreshGuid, &gZeroGuid)) { + if (!IsZeroGuid (&Statement->RefreshGuid)) { CreateRefreshEventForStatement (Statement); } @@ -373,7 +373,7 @@ InitializeDisplayStatement ( // Create the refresh guid hook event. // If the statement in this form has refresh event or refresh interval, browser will create this event for display engine. // - if ((!CompareGuid (&Statement->RefreshGuid, &gZeroGuid)) || (Statement->RefreshInterval != 0)) { + if ((!IsZeroGuid (&Statement->RefreshGuid)) || (Statement->RefreshInterval != 0)) { gDisplayFormData.FormRefreshEvent = mValueChangedEvent; } @@ -628,7 +628,7 @@ AddStatementToDisplayForm ( // // Create the refresh event process function for Form. // - if (!CompareGuid (&gCurrentSelection->Form->RefreshGuid, &gZeroGuid)) { + if (!IsZeroGuid (&gCurrentSelection->Form->RefreshGuid)) { CreateRefreshEventForForm (gCurrentSelection->Form); if (gDisplayFormData.FormRefreshEvent == NULL) { gDisplayFormData.FormRefreshEvent = mValueChangedEvent; @@ -1410,7 +1410,7 @@ ProcessGotoOpCode ( CopyMem (&Selection->FormSetGuid,&Statement->HiiValue.Value.ref.FormSetGuid, sizeof (EFI_GUID)); Selection->FormId = Statement->HiiValue.Value.ref.FormId; Selection->QuestionId = Statement->HiiValue.Value.ref.QuestionId; - } else if (!CompareGuid (&Statement->HiiValue.Value.ref.FormSetGuid, &gZeroGuid)) { + } else if (!IsZeroGuid (&Statement->HiiValue.Value.ref.FormSetGuid)) { if (Selection->Form->ModalForm) { return Status; } diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c index 00f4b41..3f368b5 100644 --- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c @@ -181,7 +181,7 @@ UiFindMenuList ( // Find the same FromSet. // if (MenuList->HiiHandle == HiiHandle) { - if (CompareGuid (&MenuList->FormSetGuid, &gZeroGuid)) { + if (IsZeroGuid (&MenuList->FormSetGuid)) { // // FormSetGuid is not specified. // @@ -5689,7 +5689,7 @@ GetIfrBinaryData ( // // Try to compare against formset GUID // - if (CompareGuid (FormSetGuid, &gZeroGuid) || + if (IsZeroGuid (FormSetGuid) || CompareGuid (ComparingGuid, (EFI_GUID *)(OpCodeData + sizeof (EFI_IFR_OP_HEADER)))) { break; } diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c index fb16af3..2ceba37 100644 --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c @@ -14,7 +14,7 @@ VariableServiceSetVariable(), VariableServiceQueryVariableInfo(), ReclaimForOS(), SmmVariableGetStatistics() should also do validation based on its own knowledge. -Copyright (c) 2010 - 2015, Intel Corporation. All rights reserved.<BR> +Copyright (c) 2010 - 2016, Intel Corporation. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -35,7 +35,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #include <Library/SmmMemLib.h> #include <Guid/SmmVariableCommon.h> -#include <Guid/ZeroGuid.h> #include "Variable.h" extern VARIABLE_INFO_ENTRY *gVariableInfo; @@ -373,7 +372,7 @@ SmmVariableGetStatistics ( CopyGuid (&VendorGuid, &InfoEntry->VendorGuid); - if (CompareGuid (&VendorGuid, &gZeroGuid)) { + if (IsZeroGuid (&VendorGuid)) { // // Return the first variable info // diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf index 5f90172..ccfb6fc 100644 --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf @@ -114,7 +114,6 @@ ## SOMETIMES_CONSUMES ## Variable:L"VarErrorFlag" ## SOMETIMES_PRODUCES ## Variable:L"VarErrorFlag" gEdkiiVarErrorFlagGuid - gZeroGuid ## SOMETIMES_CONSUMES ## GUID [Pcd] gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize ## CONSUMES -- 1.9.5.msysgit.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/3] MdeModulePkg: Use IsZeroGuid API for zero GUID checking 2016-08-30 2:36 ` [PATCH 2/3] MdeModulePkg: " Hao Wu @ 2016-08-30 2:43 ` Tian, Feng 0 siblings, 0 replies; 7+ messages in thread From: Tian, Feng @ 2016-08-30 2:43 UTC (permalink / raw) To: Wu, Hao A, edk2-devel@lists.01.org, Gao, Liming; +Cc: Zeng, Star, Tian, Feng Reviewed-by: Feng Tian <feng.tian@Intel.com> Thanks Feng -----Original Message----- From: Wu, Hao A Sent: Tuesday, August 30, 2016 10:36 AM To: edk2-devel@lists.01.org; Gao, Liming <liming.gao@intel.com> Cc: Wu, Hao A <hao.a.wu@intel.com>; Tian, Feng <feng.tian@intel.com>; Zeng, Star <star.zeng@intel.com> Subject: [PATCH 2/3] MdeModulePkg: Use IsZeroGuid API for zero GUID checking Instead of comparing a GUID with gZeroGuid via the CompareGuid API, the commit uses the IsZeroGuid API to check if the given GUID is a zero GUID. Cc: Feng Tian <feng.tian@intel.com> Cc: Star Zeng <star.zeng@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu <hao.a.wu@intel.com> --- MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c | 3 +-- MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.inf | 1 - MdeModulePkg/Core/Dxe/DxeMain.h | 1 - MdeModulePkg/Core/Dxe/DxeMain.inf | 1 - MdeModulePkg/Core/PiSmmCore/PiSmmCore.h | 1 - MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf | 1 - MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c | 4 ++-- MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h | 1 - MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 - MdeModulePkg/Library/VarCheckHiiLib/VarCheckHii.h | 4 +--- MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiGenFromFv.c | 6 +++--- MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiLib.inf | 3 --- MdeModulePkg/Universal/SetupBrowserDxe/Expression.c | 2 +- MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c | 8 ++++---- MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 4 ++-- MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c | 5 ++--- MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf | 1 - 17 files changed, 16 insertions(+), 31 deletions(-) diff --git a/MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c b/MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c index e82ee9c..14e8934 100644 --- a/MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c +++ b/MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c @@ -27,7 +27,6 @@ #include <Protocol/SmmCommunication.h> #include <Protocol/SmmAccess2.h> -#include <Guid/ZeroGuid.h> #include <Guid/MemoryProfile.h> #include <Guid/PiSmmCommunicationRegionTable.h> @@ -255,7 +254,7 @@ GetDriverNameString ( return mNameString; } - if (!CompareGuid (&DriverInfo->FileName, &gZeroGuid)) { + if (!IsZeroGuid (&DriverInfo->FileName)) { // // Try to get the image's FFS UI section by image GUID // diff --git a/MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.inf b/MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.inf index c512a3f..4bb7a9d 100644 --- a/MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.inf +++ b/MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.inf @@ -52,7 +52,6 @@ ## SOMETIMES_CONSUMES ## GUID # Locate protocol ## SOMETIMES_CONSUMES ## GUID # SmiHandlerRegister gEdkiiMemoryProfileGuid - gZeroGuid ## SOMETIMES_CONSUMES ## GUID gEdkiiPiSmmCommunicationRegionTableGuid ## SOMETIMES_CONSUMES ## SystemTable [Protocols] diff --git a/MdeModulePkg/Core/Dxe/DxeMain.h b/MdeModulePkg/Core/Dxe/DxeMain.h index 60d85f0..aefeeb7 100644 --- a/MdeModulePkg/Core/Dxe/DxeMain.h +++ b/MdeModulePkg/Core/Dxe/DxeMain.h @@ -69,7 +69,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #include <Guid/IdleLoopEvent.h> #include <Guid/VectorHandoffTable.h> #include <Ppi/VectorHandoffInfo.h> -#include <Guid/ZeroGuid.h> #include <Guid/MemoryProfile.h> #include <Library/DxeCoreEntryPoint.h> diff --git a/MdeModulePkg/Core/Dxe/DxeMain.inf b/MdeModulePkg/Core/Dxe/DxeMain.inf index 450da57..13a2381 100644 --- a/MdeModulePkg/Core/Dxe/DxeMain.inf +++ b/MdeModulePkg/Core/Dxe/DxeMain.inf @@ -124,7 +124,6 @@ gEventExitBootServicesFailedGuid ## SOMETIMES_PRODUCES ## Event gEfiVectorHandoffTableGuid ## SOMETIMES_PRODUCES ## SystemTable gEdkiiMemoryProfileGuid ## SOMETIMES_PRODUCES ## GUID # Install protocol - gZeroGuid ## SOMETIMES_CONSUMES ## GUID gEfiPropertiesTableGuid ## SOMETIMES_PRODUCES ## SystemTable gEfiMemoryAttributesTableGuid ## SOMETIMES_PRODUCES ## SystemTable gEfiEndOfDxeEventGroupGuid ## SOMETIMES_CONSUMES ## Event diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.h b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.h index 000864d..f46ee72 100644 --- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.h +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.h @@ -36,7 +36,6 @@ #include <Guid/Apriori.h> #include <Guid/EventGroup.h> #include <Guid/EventLegacyBios.h> -#include <Guid/ZeroGuid.h> #include <Guid/MemoryProfile.h> #include <Library/BaseLib.h> diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf index f7e32c4..1f73cbb 100644 --- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf @@ -96,7 +96,6 @@ gEdkiiMemoryProfileGuid ## SOMETIMES_PRODUCES ## GUID # Install protocol gEdkiiSmmMemoryProfileGuid - gZeroGuid ## SOMETIMES_CONSUMES ## GUID [UserExtensions.TianoCore."ExtraFiles"] PiSmmCoreExtra.uni diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c b/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c index 1e68cbc..ddcee8b 100644 --- a/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c @@ -1,7 +1,7 @@ /** @file Library functions which relates with driver health. -Copyright (c) 2011 - 2015, Intel Corporation. All rights reserved.<BR> +Copyright (c) 2011 - 2016, Intel Corporation. All rights reserved.<BR> (C) Copyright 2015 Hewlett-Packard Development Company, L.P.<BR> (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR> This program and the accompanying materials @@ -446,7 +446,7 @@ BmRepairAllControllers ( // // Configure PcdDriverHealthConfigureForm to ZeroGuid to disable driver health check. // - if (CompareGuid (PcdGetPtr (PcdDriverHealthConfigureForm), &gZeroGuid)) { + if (IsZeroGuid (PcdGetPtr (PcdDriverHealthConfigureForm))) { return; } diff --git a/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h b/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h index 07ee45b..cb719e9 100644 --- a/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h +++ b/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h @@ -45,7 +45,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #include <Protocol/VariableLock.h> #include <Protocol/RamDisk.h> -#include <Guid/ZeroGuid.h> #include <Guid/MemoryTypeInformation.h> #include <Guid/FileInfo.h> #include <Guid/GlobalVariable.h> diff --git a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf index 5d0bd1d..8c3fd7f 100644 --- a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf +++ b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf @@ -87,7 +87,6 @@ gEfiDiskInfoAhciInterfaceGuid ## SOMETIMES_CONSUMES ## GUID gEfiDiskInfoIdeInterfaceGuid ## SOMETIMES_CONSUMES ## GUID gEfiDiskInfoScsiInterfaceGuid ## SOMETIMES_CONSUMES ## GUID - gZeroGuid ## CONSUMES ## GUID [Protocols] gEfiPciRootBridgeIoProtocolGuid ## CONSUMES diff --git a/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHii.h b/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHii.h index d770785..a54b867 100644 --- a/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHii.h +++ b/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHii.h @@ -1,7 +1,7 @@ /** @file Include file for Var Check Hii handler and bin. -Copyright (c) 2015, Intel Corporation. All rights reserved.<BR> +Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -22,8 +22,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #include <Library/UefiBootServicesTableLib.h> #include <Library/MemoryAllocationLib.h> -#include <Guid/ZeroGuid.h> - #include <Protocol/HiiDatabase.h> #include <Protocol/FirmwareVolume2.h> #include <Protocol/FirmwareVolumeBlock.h> diff --git a/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiGenFromFv.c b/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiGenFromFv.c index 21fc80e..71ece27 100644 --- a/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiGenFromFv.c +++ b/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiGenFromFv.c @@ -1,7 +1,7 @@ /** @file Var Check Hii generation from FV. -Copyright (c) 2015, Intel Corporation. All rights reserved.<BR> +Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -372,7 +372,7 @@ CreateVfrDriverList ( UINTN Index; VAR_CHECK_VFR_DRIVER_INFO *VfrDriverInfo; - for (Index = 0; !CompareGuid (&DriverGuidArray[Index], &gZeroGuid); Index++) { + for (Index = 0; !IsZeroGuid (&DriverGuidArray[Index]); Index++) { DEBUG ((EFI_D_INFO, "CreateVfrDriverList: %g\n", &DriverGuidArray[Index])); VfrDriverInfo = InternalVarCheckAllocateZeroPool (sizeof (*VfrDriverInfo)); ASSERT (VfrDriverInfo != NULL); @@ -421,7 +421,7 @@ VarCheckHiiGenFromFv ( // DriverGuidArray = (EFI_GUID *) PcdGetPtr (PcdVarCheckVfrDriverGuidArray); - if (CompareGuid (&DriverGuidArray[0], &gZeroGuid)) { + if (IsZeroGuid (&DriverGuidArray[0])) { // // No VFR driver will be parsed from FVs. // diff --git a/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiLib.inf b/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiLib.inf index 24d24c5..98e6983 100644 --- a/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiLib.inf +++ b/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiLib.inf @@ -46,9 +46,6 @@ PcdLib VarCheckLib -[Guids] - gZeroGuid ## SOMETIMES_CONSUMES ## GUID - [Protocols] gEfiFirmwareVolume2ProtocolGuid ## SOMETIMES_CONSUMES gEfiFirmwareVolumeBlock2ProtocolGuid ## SOMETIMES_CONSUMES diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c b/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c index 1938ff2..ec4d285 100644 --- a/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c @@ -2829,7 +2829,7 @@ EvaluateExpression ( if (StrPtr != NULL) { FreePool (StrPtr); } - } else if (CompareGuid (&OpCode->Guid, &gZeroGuid) != 0) { + } else if (IsZeroGuid (&OpCode->Guid)) { if (!GetQuestionValueFromForm(NULL, FormSet->HiiHandle, &OpCode->Guid, Value->Value.u16, &QuestionVal)){ Value->Type = EFI_IFR_TYPE_UNDEFINED; break; diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c index 56ae7b0..6856cc5 100644 --- a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c @@ -358,7 +358,7 @@ InitializeDisplayStatement ( // // Create the refresh event process function. // - if (!CompareGuid (&Statement->RefreshGuid, &gZeroGuid)) { + if (!IsZeroGuid (&Statement->RefreshGuid)) { CreateRefreshEventForStatement (Statement); } @@ -373,7 +373,7 @@ InitializeDisplayStatement ( // Create the refresh guid hook event. // If the statement in this form has refresh event or refresh interval, browser will create this event for display engine. // - if ((!CompareGuid (&Statement->RefreshGuid, &gZeroGuid)) || (Statement->RefreshInterval != 0)) { + if ((!IsZeroGuid (&Statement->RefreshGuid)) || + (Statement->RefreshInterval != 0)) { gDisplayFormData.FormRefreshEvent = mValueChangedEvent; } @@ -628,7 +628,7 @@ AddStatementToDisplayForm ( // // Create the refresh event process function for Form. // - if (!CompareGuid (&gCurrentSelection->Form->RefreshGuid, &gZeroGuid)) { + if (!IsZeroGuid (&gCurrentSelection->Form->RefreshGuid)) { CreateRefreshEventForForm (gCurrentSelection->Form); if (gDisplayFormData.FormRefreshEvent == NULL) { gDisplayFormData.FormRefreshEvent = mValueChangedEvent; @@ -1410,7 +1410,7 @@ ProcessGotoOpCode ( CopyMem (&Selection->FormSetGuid,&Statement->HiiValue.Value.ref.FormSetGuid, sizeof (EFI_GUID)); Selection->FormId = Statement->HiiValue.Value.ref.FormId; Selection->QuestionId = Statement->HiiValue.Value.ref.QuestionId; - } else if (!CompareGuid (&Statement->HiiValue.Value.ref.FormSetGuid, &gZeroGuid)) { + } else if (!IsZeroGuid (&Statement->HiiValue.Value.ref.FormSetGuid)) + { if (Selection->Form->ModalForm) { return Status; } diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c index 00f4b41..3f368b5 100644 --- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c @@ -181,7 +181,7 @@ UiFindMenuList ( // Find the same FromSet. // if (MenuList->HiiHandle == HiiHandle) { - if (CompareGuid (&MenuList->FormSetGuid, &gZeroGuid)) { + if (IsZeroGuid (&MenuList->FormSetGuid)) { // // FormSetGuid is not specified. // @@ -5689,7 +5689,7 @@ GetIfrBinaryData ( // // Try to compare against formset GUID // - if (CompareGuid (FormSetGuid, &gZeroGuid) || + if (IsZeroGuid (FormSetGuid) || CompareGuid (ComparingGuid, (EFI_GUID *)(OpCodeData + sizeof (EFI_IFR_OP_HEADER)))) { break; } diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c index fb16af3..2ceba37 100644 --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c @@ -14,7 +14,7 @@ VariableServiceSetVariable(), VariableServiceQueryVariableInfo(), ReclaimForOS(), SmmVariableGetStatistics() should also do validation based on its own knowledge. -Copyright (c) 2010 - 2015, Intel Corporation. All rights reserved.<BR> +Copyright (c) 2010 - 2016, Intel Corporation. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -35,7 +35,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #include <Library/SmmMemLib.h> #include <Guid/SmmVariableCommon.h> -#include <Guid/ZeroGuid.h> #include "Variable.h" extern VARIABLE_INFO_ENTRY *gVariableInfo; @@ -373,7 +372,7 @@ SmmVariableGetStatistics ( CopyGuid (&VendorGuid, &InfoEntry->VendorGuid); - if (CompareGuid (&VendorGuid, &gZeroGuid)) { + if (IsZeroGuid (&VendorGuid)) { // // Return the first variable info // diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf index 5f90172..ccfb6fc 100644 --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf @@ -114,7 +114,6 @@ ## SOMETIMES_CONSUMES ## Variable:L"VarErrorFlag" ## SOMETIMES_PRODUCES ## Variable:L"VarErrorFlag" gEdkiiVarErrorFlagGuid - gZeroGuid ## SOMETIMES_CONSUMES ## GUID [Pcd] gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize ## CONSUMES -- 1.9.5.msysgit.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/3] SecurityPkg: Use IsZeroGuid API for zero GUID checking 2016-08-30 2:36 [PATCH 0/3] Use IsZeroGuid API for zero GUID checking Hao Wu 2016-08-30 2:36 ` [PATCH 1/3] IntelFrameworkModulePkg: " Hao Wu 2016-08-30 2:36 ` [PATCH 2/3] MdeModulePkg: " Hao Wu @ 2016-08-30 2:36 ` Hao Wu 2016-08-30 3:21 ` Zhang, Chao B 2 siblings, 1 reply; 7+ messages in thread From: Hao Wu @ 2016-08-30 2:36 UTC (permalink / raw) To: edk2-devel, liming.gao; +Cc: Hao Wu, Chao Zhang Instead of comparing a GUID with gZeroGuid via the CompareGuid API, the commit uses the IsZeroGuid API to check if the given GUID is a zero GUID. Cc: Chao Zhang <chao.b.zhang@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu <hao.a.wu@intel.com> --- SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c | 7 +++---- .../Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.inf | 3 +-- SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c | 5 ++--- SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.inf | 3 +-- 4 files changed, 7 insertions(+), 11 deletions(-) diff --git a/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c b/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c index 1f2574e..aacafa8 100644 --- a/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c +++ b/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c @@ -15,7 +15,7 @@ Tcg2MeasureGptTable() function will receive untrusted GPT partition table, and parse partition data carefully. -Copyright (c) 2013 - 2015, Intel Corporation. All rights reserved.<BR> +Copyright (c) 2013 - 2016, Intel Corporation. All rights reserved.<BR> (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License @@ -36,7 +36,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #include <Protocol/FirmwareVolumeBlock.h> #include <Guid/MeasuredFvHob.h> -#include <Guid/ZeroGuid.h> #include <Library/BaseLib.h> #include <Library/DebugLib.h> @@ -202,7 +201,7 @@ Tcg2MeasureGptTable ( PartitionEntry = (EFI_PARTITION_ENTRY *)EntryPtr; NumberOfPartition = 0; for (Index = 0; Index < PrimaryHeader->NumberOfPartitionEntries; Index++) { - if (!CompareGuid (&PartitionEntry->PartitionTypeGUID, &gZeroGuid)) { + if (!IsZeroGuid (&PartitionEntry->PartitionTypeGUID)) { NumberOfPartition++; } PartitionEntry = (EFI_PARTITION_ENTRY *)((UINT8 *)PartitionEntry + PrimaryHeader->SizeOfPartitionEntry); @@ -238,7 +237,7 @@ Tcg2MeasureGptTable ( PartitionEntry = (EFI_PARTITION_ENTRY*)EntryPtr; NumberOfPartition = 0; for (Index = 0; Index < PrimaryHeader->NumberOfPartitionEntries; Index++) { - if (!CompareGuid (&PartitionEntry->PartitionTypeGUID, &gZeroGuid)) { + if (!IsZeroGuid (&PartitionEntry->PartitionTypeGUID)) { CopyMem ( (UINT8 *)&GptData->Partitions + NumberOfPartition * PrimaryHeader->SizeOfPartitionEntry, (UINT8 *)PartitionEntry, diff --git a/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.inf b/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.inf index 1296c97..a11988e 100644 --- a/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.inf +++ b/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.inf @@ -9,7 +9,7 @@ # This external input must be validated carefully to avoid security issues such # as buffer overflow or integer overflow. # -# Copyright (c) 2013 - 2015, Intel Corporation. All rights reserved.<BR> +# Copyright (c) 2013 - 2016, Intel Corporation. All rights reserved.<BR> # This program and the accompanying materials # are licensed and made available under the terms and conditions of the BSD License # which accompanies this distribution. The full text of the license may be found at @@ -58,7 +58,6 @@ [Guids] gMeasuredFvHobGuid ## SOMETIMES_CONSUMES ## HOB - gZeroGuid ## SOMETIMES_CONSUMES ## GUID [Protocols] gEfiTcg2ProtocolGuid ## SOMETIMES_CONSUMES diff --git a/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c b/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c index 8ab60d8..52bf582 100644 --- a/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c +++ b/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c @@ -34,7 +34,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #include <Protocol/FirmwareVolumeBlock.h> #include <Guid/MeasuredFvHob.h> -#include <Guid/ZeroGuid.h> #include <Library/BaseLib.h> #include <Library/DebugLib.h> @@ -202,7 +201,7 @@ TcgMeasureGptTable ( PartitionEntry = (EFI_PARTITION_ENTRY *)EntryPtr; NumberOfPartition = 0; for (Index = 0; Index < PrimaryHeader->NumberOfPartitionEntries; Index++) { - if (!CompareGuid (&PartitionEntry->PartitionTypeGUID, &gZeroGuid)) { + if (!IsZeroGuid (&PartitionEntry->PartitionTypeGUID)) { NumberOfPartition++; } PartitionEntry = (EFI_PARTITION_ENTRY *)((UINT8 *)PartitionEntry + PrimaryHeader->SizeOfPartitionEntry); @@ -236,7 +235,7 @@ TcgMeasureGptTable ( PartitionEntry = (EFI_PARTITION_ENTRY*)EntryPtr; NumberOfPartition = 0; for (Index = 0; Index < PrimaryHeader->NumberOfPartitionEntries; Index++) { - if (!CompareGuid (&PartitionEntry->PartitionTypeGUID, &gZeroGuid)) { + if (!IsZeroGuid (&PartitionEntry->PartitionTypeGUID)) { CopyMem ( (UINT8 *)&GptData->Partitions + NumberOfPartition * PrimaryHeader->SizeOfPartitionEntry, (UINT8 *)PartitionEntry, diff --git a/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.inf b/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.inf index 0d58eec..553e683 100644 --- a/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.inf +++ b/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.inf @@ -9,7 +9,7 @@ # This external input must be validated carefully to avoid security issues such # as buffer overflow or integer overflow. # -# Copyright (c) 2009 - 2015, Intel Corporation. All rights reserved.<BR> +# Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.<BR> # This program and the accompanying materials # are licensed and made available under the terms and conditions of the BSD License # which accompanies this distribution. The full text of the license may be found at @@ -58,7 +58,6 @@ [Guids] gMeasuredFvHobGuid ## SOMETIMES_CONSUMES ## HOB - gZeroGuid ## SOMETIMES_CONSUMES ## GUID [Protocols] gEfiTcgProtocolGuid ## SOMETIMES_CONSUMES -- 1.9.5.msysgit.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 3/3] SecurityPkg: Use IsZeroGuid API for zero GUID checking 2016-08-30 2:36 ` [PATCH 3/3] SecurityPkg: " Hao Wu @ 2016-08-30 3:21 ` Zhang, Chao B 0 siblings, 0 replies; 7+ messages in thread From: Zhang, Chao B @ 2016-08-30 3:21 UTC (permalink / raw) To: Wu, Hao A, edk2-devel@lists.01.org, Gao, Liming Reviewed-by: Chao Zhang<chao.b.zhang@intel.com> Thanks & Best regards Chao Zhang -----Original Message----- From: Wu, Hao A Sent: Tuesday, August 30, 2016 10:36 AM To: edk2-devel@lists.01.org; Gao, Liming Cc: Wu, Hao A; Zhang, Chao B Subject: [PATCH 3/3] SecurityPkg: Use IsZeroGuid API for zero GUID checking Instead of comparing a GUID with gZeroGuid via the CompareGuid API, the commit uses the IsZeroGuid API to check if the given GUID is a zero GUID. Cc: Chao Zhang <chao.b.zhang@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu <hao.a.wu@intel.com> --- SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c | 7 +++---- .../Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.inf | 3 +-- SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c | 5 ++--- SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.inf | 3 +-- 4 files changed, 7 insertions(+), 11 deletions(-) diff --git a/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c b/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c index 1f2574e..aacafa8 100644 --- a/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c +++ b/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c @@ -15,7 +15,7 @@ Tcg2MeasureGptTable() function will receive untrusted GPT partition table, and parse partition data carefully. -Copyright (c) 2013 - 2015, Intel Corporation. All rights reserved.<BR> +Copyright (c) 2013 - 2016, Intel Corporation. All rights reserved.<BR> (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License @@ -36,7 +36,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #include <Protocol/FirmwareVolumeBlock.h> #include <Guid/MeasuredFvHob.h> -#include <Guid/ZeroGuid.h> #include <Library/BaseLib.h> #include <Library/DebugLib.h> @@ -202,7 +201,7 @@ Tcg2MeasureGptTable ( PartitionEntry = (EFI_PARTITION_ENTRY *)EntryPtr; NumberOfPartition = 0; for (Index = 0; Index < PrimaryHeader->NumberOfPartitionEntries; Index++) { - if (!CompareGuid (&PartitionEntry->PartitionTypeGUID, &gZeroGuid)) { + if (!IsZeroGuid (&PartitionEntry->PartitionTypeGUID)) { NumberOfPartition++; } PartitionEntry = (EFI_PARTITION_ENTRY *)((UINT8 *)PartitionEntry + PrimaryHeader->SizeOfPartitionEntry); @@ -238,7 +237,7 @@ Tcg2MeasureGptTable ( PartitionEntry = (EFI_PARTITION_ENTRY*)EntryPtr; NumberOfPartition = 0; for (Index = 0; Index < PrimaryHeader->NumberOfPartitionEntries; Index++) { - if (!CompareGuid (&PartitionEntry->PartitionTypeGUID, &gZeroGuid)) { + if (!IsZeroGuid (&PartitionEntry->PartitionTypeGUID)) { CopyMem ( (UINT8 *)&GptData->Partitions + NumberOfPartition * PrimaryHeader->SizeOfPartitionEntry, (UINT8 *)PartitionEntry, diff --git a/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.inf b/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.inf index 1296c97..a11988e 100644 --- a/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.inf +++ b/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.inf @@ -9,7 +9,7 @@ # This external input must be validated carefully to avoid security issues such # as buffer overflow or integer overflow. # -# Copyright (c) 2013 - 2015, Intel Corporation. All rights reserved.<BR> +# Copyright (c) 2013 - 2016, Intel Corporation. All rights reserved.<BR> # This program and the accompanying materials # are licensed and made available under the terms and conditions of the BSD License # which accompanies this distribution. The full text of the license may be found at @@ -58,7 +58,6 @@ [Guids] gMeasuredFvHobGuid ## SOMETIMES_CONSUMES ## HOB - gZeroGuid ## SOMETIMES_CONSUMES ## GUID [Protocols] gEfiTcg2ProtocolGuid ## SOMETIMES_CONSUMES diff --git a/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c b/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c index 8ab60d8..52bf582 100644 --- a/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c +++ b/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c @@ -34,7 +34,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #include <Protocol/FirmwareVolumeBlock.h> #include <Guid/MeasuredFvHob.h> -#include <Guid/ZeroGuid.h> #include <Library/BaseLib.h> #include <Library/DebugLib.h> @@ -202,7 +201,7 @@ TcgMeasureGptTable ( PartitionEntry = (EFI_PARTITION_ENTRY *)EntryPtr; NumberOfPartition = 0; for (Index = 0; Index < PrimaryHeader->NumberOfPartitionEntries; Index++) { - if (!CompareGuid (&PartitionEntry->PartitionTypeGUID, &gZeroGuid)) { + if (!IsZeroGuid (&PartitionEntry->PartitionTypeGUID)) { NumberOfPartition++; } PartitionEntry = (EFI_PARTITION_ENTRY *)((UINT8 *)PartitionEntry + PrimaryHeader->SizeOfPartitionEntry); @@ -236,7 +235,7 @@ TcgMeasureGptTable ( PartitionEntry = (EFI_PARTITION_ENTRY*)EntryPtr; NumberOfPartition = 0; for (Index = 0; Index < PrimaryHeader->NumberOfPartitionEntries; Index++) { - if (!CompareGuid (&PartitionEntry->PartitionTypeGUID, &gZeroGuid)) { + if (!IsZeroGuid (&PartitionEntry->PartitionTypeGUID)) { CopyMem ( (UINT8 *)&GptData->Partitions + NumberOfPartition * PrimaryHeader->SizeOfPartitionEntry, (UINT8 *)PartitionEntry, diff --git a/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.inf b/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.inf index 0d58eec..553e683 100644 --- a/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.inf +++ b/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.inf @@ -9,7 +9,7 @@ # This external input must be validated carefully to avoid security issues such # as buffer overflow or integer overflow. # -# Copyright (c) 2009 - 2015, Intel Corporation. All rights reserved.<BR> +# Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.<BR> # This program and the accompanying materials # are licensed and made available under the terms and conditions of the BSD License # which accompanies this distribution. The full text of the license may be found at @@ -58,7 +58,6 @@ [Guids] gMeasuredFvHobGuid ## SOMETIMES_CONSUMES ## HOB - gZeroGuid ## SOMETIMES_CONSUMES ## GUID [Protocols] gEfiTcgProtocolGuid ## SOMETIMES_CONSUMES -- 1.9.5.msysgit.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-08-30 5:55 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-08-30 2:36 [PATCH 0/3] Use IsZeroGuid API for zero GUID checking Hao Wu 2016-08-30 2:36 ` [PATCH 1/3] IntelFrameworkModulePkg: " Hao Wu 2016-08-30 5:54 ` Fan, Jeff 2016-08-30 2:36 ` [PATCH 2/3] MdeModulePkg: " Hao Wu 2016-08-30 2:43 ` Tian, Feng 2016-08-30 2:36 ` [PATCH 3/3] SecurityPkg: " Hao Wu 2016-08-30 3:21 ` Zhang, Chao B
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox