From: Vikas C Sajjan <vikas.cha.sajjan@hpe.com>
To: edk2-devel@lists.01.org, lersek@redhat.com,
ard.biesheuvel@linaro.org, leif.lindholm@linaro.org
Subject: [PATCH] ArmPkg: Add IsZeroGuid() API support for ArmPkg
Date: Thu, 1 Sep 2016 17:41:03 +0530 [thread overview]
Message-ID: <1472731863-21633-1-git-send-email-vikas.cha.sajjan@hpe.com> (raw)
The commit "965268e SecurityPkg: Use IsZeroGuid API for zero GUID checking"
breaks the ArmPkg build as below.
edk2/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c:184: undefined reference to `IsZeroGuid'
edk2/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c:5692: undefined reference to `IsZeroGuid'
edk2/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c:2832: undefined reference to `IsZeroGuid'
edk2/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c:361: undefined reference to `IsZeroGuid'
edk2/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c:376: undefined reference to `IsZeroGuid'
Since it introduced the use of IsZeroGuid() instead
CompareGuid(). And the IsZeroGuid() support was missing in ArmPkg.
Contributed-under: TianoCore Contribution Agreement 1.0
Reported-by: Mohan Parthasarathy <mohan_parthasarathy@hpe.com>
Signed-off-by: Vikas C Sajjan <vikas.cha.sajjan@hpe.com>
---
ArmPkg/Library/BaseMemoryLibStm/MemLibGuid.c | 29 ++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/ArmPkg/Library/BaseMemoryLibStm/MemLibGuid.c b/ArmPkg/Library/BaseMemoryLibStm/MemLibGuid.c
index 2b4ed57..36d42d7 100644
--- a/ArmPkg/Library/BaseMemoryLibStm/MemLibGuid.c
+++ b/ArmPkg/Library/BaseMemoryLibStm/MemLibGuid.c
@@ -130,3 +130,32 @@ ScanGuid (
}
return NULL;
}
+
+/**
+ Checks if the given GUID is a zero GUID.
+
+ This function checks whether the given GUID is a zero GUID. If the GUID is
+ identical to a zero GUID then TRUE is returned. Otherwise, FALSE is returned.
+
+ If Guid is NULL, then ASSERT().
+
+ @param Guid The pointer to a 128 bit GUID.
+
+ @retval TRUE Guid is a zero GUID.
+ @retval FALSE Guid is not a zero GUID.
+
+**/
+BOOLEAN
+EFIAPI
+IsZeroGuid (
+ IN CONST GUID *Guid
+ )
+{
+ UINT64 LowPartOfGuid;
+ UINT64 HighPartOfGuid;
+
+ LowPartOfGuid = ReadUnaligned64 ((CONST UINT64*) Guid);
+ HighPartOfGuid = ReadUnaligned64 ((CONST UINT64*) Guid + 1);
+
+ return (BOOLEAN) (LowPartOfGuid == 0 && HighPartOfGuid == 0);
+}
--
1.9.1
next reply other threads:[~2016-09-01 12:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 12:11 Vikas C Sajjan [this message]
2016-09-01 12:26 ` [PATCH] ArmPkg: Add IsZeroGuid() API support for ArmPkg Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472731863-21633-1-git-send-email-vikas.cha.sajjan@hpe.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox