From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x232.google.com (mail-wm0-x232.google.com [IPv6:2a00:1450:400c:c09::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ED9B91A1EC1 for ; Wed, 7 Sep 2016 00:04:56 -0700 (PDT) Received: by mail-wm0-x232.google.com with SMTP id 1so14150532wmz.1 for ; Wed, 07 Sep 2016 00:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=9wjmq08ewuJG+T0HxQHTSV7yr4aFVTM99aCiNnkgQtk=; b=M5kMbIT2mmk7PxQN76wY7TxtuARSKvebORVJ7Opkg96K0Lmn91HbLrwmZD5DzIcpcJ 4FAraXnPyF5GJpVw6AJF3Mkd9+7CUCtRM214BOpJ0dYGkIbGUge1t0WE9sGV/gOzrwFm UokYdZFc7QvBHIzH995Yp4Dr0BAdfWNicrrYA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=9wjmq08ewuJG+T0HxQHTSV7yr4aFVTM99aCiNnkgQtk=; b=bc6k5v8hHmWTur7zHX/2/zVF6kn31jgJePtajV9zl4hZCbaTodfJeR5gnSXQf3r+lm KAXSSj5MUuzvUoyLxJhewmjmL+iJEswwG8ChfRJNAyuoCrlIDeEvVKND0AFf8QB+SbJG OkGnUBrQ7ocnnR6NIWsFBhqhlotAVRD2HgveuH7c9Tyb/xb1HdsF03IGfU9LW+nFgjUh 1ZQdtpu5sh+iV2OoUMtz4NgbMW8cQXKFUuRCtnPL13aMIpffMGYELNlkt2UUrxsZXt07 FrDEZyosJjG/AhcKkxrIGTppV6w8dd/UvTeiIJ+5yNhj0ZINkdm8eADzWllPLgrgLpg/ SUDQ== X-Gm-Message-State: AE9vXwNvyY06QmiwClsouHaN1QvuALNUIK4tpLMgIMqjyMty3f6y2qi2m9sX6xcNRnRJnPP9 X-Received: by 10.28.125.80 with SMTP id y77mr2338498wmc.25.1473231895585; Wed, 07 Sep 2016 00:04:55 -0700 (PDT) Received: from localhost.localdomain ([197.130.133.164]) by smtp.gmail.com with ESMTPSA id f4sm2617936wmf.8.2016.09.07.00.04.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 07 Sep 2016 00:04:54 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org, leif.lindholm@linaro.org Cc: vishalo@qti.qualcomm.com, Ard Biesheuvel Date: Wed, 7 Sep 2016 08:04:50 +0100 Message-Id: <1473231890-23205-1-git-send-email-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.7.4 Subject: [PATCH] ArmPkg/ArmGicLib: use correct loop variable X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Sep 2016 07:04:57 -0000 The ArmGicLib API function GicGetCpuRedistributorBase () declares GicCpuRedistributorBase to iterate over the redistributors of all CPUs, but then inadvertently advances GicRedistributorBase instead. Reported-by: "Oliyil Kunnil, Vishal" Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPkg/Drivers/ArmGic/ArmGicLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmPkg/Drivers/ArmGic/ArmGicLib.c b/ArmPkg/Drivers/ArmGic/ArmGicLib.c index 73795ed4e56c..e658e9bff5d8 100644 --- a/ArmPkg/Drivers/ArmGic/ArmGicLib.c +++ b/ArmPkg/Drivers/ArmGic/ArmGicLib.c @@ -76,7 +76,7 @@ GicGetCpuRedistributorBase ( } // Move to the next GIC Redistributor frame - GicRedistributorBase += GicRedistributorGranularity; + GicCpuRedistributorBase += GicRedistributorGranularity; } // The Redistributor has not been found for the current CPU -- 2.7.4