public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] OvmfPkg: Fix typing errors
@ 2016-09-09 20:32 Thomas Huth
  2016-09-09 23:02 ` Laszlo Ersek
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2016-09-09 20:32 UTC (permalink / raw)
  To: edk2-devel; +Cc: Jordan Justen, Laszlo Ersek

Correct some typos (discovered with the codespell utility)

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c              | 2 +-
 OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c           | 4 ++--
 OvmfPkg/Library/NvVarsFileLib/FsAccess.c             | 4 ++--
 OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 8 ++++----
 OvmfPkg/PlatformPei/MemDetect.c                      | 2 +-
 OvmfPkg/QemuVideoDxe/VbeShim.c                       | 2 +-
 OvmfPkg/XenBusDxe/EventChannel.c                     | 2 +-
 OvmfPkg/XenBusDxe/XenStore.c                         | 2 +-
 OvmfPkg/XenPvBlkDxe/BlockIo.c                        | 2 +-
 9 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c b/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c
index faaff37..deaf14c 100644
--- a/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c
+++ b/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c
@@ -363,7 +363,7 @@ ProcessCmdAddChecksum (
   array is an ACPI table, and if so, install it.
 
   This function assumes that the entire QEMU linker/loader command file has
-  been processed successfuly in a prior first pass.
+  been processed successfully in a prior first pass.
 
   @param[in] AddPointer        The QEMU_LOADER_ADD_POINTER command to process.
 
diff --git a/OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c b/OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c
index 0ccfa97..dd75be0 100644
--- a/OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c
+++ b/OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c
@@ -256,8 +256,8 @@ GetSelectedVgaDeviceInfo (
   *VgaHandle = NULL;
 
   //
-  // Initialize variable states.  Ths is important for selecting the VGA device
-  // if multiple devices exist behind a single bridge.
+  // Initialize variable states.  This is important for selecting the VGA
+  // device if multiple devices exist behind a single bridge.
   //
   HandleCount = 0;
   HandleBuffer = NULL;
diff --git a/OvmfPkg/Library/NvVarsFileLib/FsAccess.c b/OvmfPkg/Library/NvVarsFileLib/FsAccess.c
index 5df8de4..884ce2a 100644
--- a/OvmfPkg/Library/NvVarsFileLib/FsAccess.c
+++ b/OvmfPkg/Library/NvVarsFileLib/FsAccess.c
@@ -184,7 +184,7 @@ FileHandleEmpty (
   @param[in]  ReadSize - The size of data to read from the file
 
   @return     Pointer to buffer allocated to hold the file
-              contents.  NULL if an error occured.
+              contents.  NULL if an error occurred.
 
 **/
 VOID*
@@ -332,7 +332,7 @@ LoadNvVarsFromFs (
   // We write a variable to indicate we've already loaded the
   // variable data.  If it is found, we skip the loading.
   //
-  // This is relevent if the non-volatile variable have been
+  // This is relevant if the non-volatile variable have been
   // able to survive a reboot operation.  In that case, we don't
   // want to re-load the file as it would overwrite newer changes
   // made to the variables.
diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
index 8741259..7cd547e 100644
--- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
+++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
@@ -1255,8 +1255,8 @@ ConnectRecursivelyIfPciMassStorage (
   This notification function is invoked when the
   EMU Variable FVB has been changed.
 
-  @param  Event                 The event that occured
-  @param  Context               For EFI compatiblity.  Not used.
+  @param  Event                 The event that occurred
+  @param  Context               For EFI compatibility.  Not used.
 
 **/
 VOID
@@ -1480,8 +1480,8 @@ Routine Description:
   This notification function is invoked when an instance of the
   EFI_DEVICE_PATH_PROTOCOL is produced.
 
-  @param  Event                 The event that occured
-  @param  Context               For EFI compatiblity.  Not used.
+  @param  Event                 The event that occurred
+  @param  Context               For EFI compatibility.  Not used.
 
 **/
 VOID
diff --git a/OvmfPkg/PlatformPei/MemDetect.c b/OvmfPkg/PlatformPei/MemDetect.c
index 8f66412..4863eb1 100644
--- a/OvmfPkg/PlatformPei/MemDetect.c
+++ b/OvmfPkg/PlatformPei/MemDetect.c
@@ -433,7 +433,7 @@ QemuInitializeRam (
     // PEI RAM, in a backup buffer allocated with the normal PEI services.
     // CpuMpPei restores the original contents ("returns" the borrowed area) at
     // End-of-PEI. End-of-PEI in turn is emitted by S3Resume2Pei before
-    // transfering control to the OS's wakeup vector in the FACS.
+    // transferring control to the OS's wakeup vector in the FACS.
     //
     // We expect any other PEIMs that "borrow" memory similarly to CpuMpPei to
     // restore the original contents. Furthermore, we expect all such PEIMs
diff --git a/OvmfPkg/QemuVideoDxe/VbeShim.c b/OvmfPkg/QemuVideoDxe/VbeShim.c
index 6bb175b..6a569f6 100644
--- a/OvmfPkg/QemuVideoDxe/VbeShim.c
+++ b/OvmfPkg/QemuVideoDxe/VbeShim.c
@@ -134,7 +134,7 @@ InstallVbeShim (
   PciWrite8 (Pam1Address, Pam1 | (BIT1 | BIT0));
 
   //
-  // We never added memory space durig PEI or DXE for the C segment, so we
+  // We never added memory space during PEI or DXE for the C segment, so we
   // don't need to (and can't) allocate from there. Also, guest operating
   // systems will see a hole in the UEFI memory map there.
   //
diff --git a/OvmfPkg/XenBusDxe/EventChannel.c b/OvmfPkg/XenBusDxe/EventChannel.c
index 6a36dca..490ca58 100644
--- a/OvmfPkg/XenBusDxe/EventChannel.c
+++ b/OvmfPkg/XenBusDxe/EventChannel.c
@@ -1,7 +1,7 @@
 /** @file
   Event Channel function implementation.
 
-  Event channel are use to notify of an event that happend in a shared
+  Event channel are use to notify of an event that happened in a shared
   structure for example.
 
   Copyright (C) 2014, Citrix Ltd.
diff --git a/OvmfPkg/XenBusDxe/XenStore.c b/OvmfPkg/XenBusDxe/XenStore.c
index 5757e78..fb00e73 100644
--- a/OvmfPkg/XenBusDxe/XenStore.c
+++ b/OvmfPkg/XenBusDxe/XenStore.c
@@ -10,7 +10,7 @@
 
   The XenStore is ASCII string based, and has a structure and semantics
   similar to a filesystem.  There are files and directories, the directories
-  able to contain files or other directories.  The depth of the hierachy
+  able to contain files or other directories.  The depth of the hierarchy
   is only limited by the XenStore's maximum path length.
 
   The communication channel between the XenStore service and other
diff --git a/OvmfPkg/XenPvBlkDxe/BlockIo.c b/OvmfPkg/XenPvBlkDxe/BlockIo.c
index ae6aa62..70bf32c 100644
--- a/OvmfPkg/XenPvBlkDxe/BlockIo.c
+++ b/OvmfPkg/XenPvBlkDxe/BlockIo.c
@@ -156,7 +156,7 @@ XenPvBlkDxeBlockIoReadWriteBlocks (
     Sector += IoData.Size / 512;
     Status = XenPvBlockIo (&IoData, IsWrite);
     if (EFI_ERROR (Status)) {
-      DEBUG ((EFI_D_ERROR, "XenPvBlkDxe: Error durring %a operation.\n",
+      DEBUG ((EFI_D_ERROR, "XenPvBlkDxe: Error during %a operation.\n",
               IsWrite ? "write" : "read"));
       return Status;
     }
-- 
1.8.3.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] OvmfPkg: Fix typing errors
  2016-09-09 20:32 [PATCH] OvmfPkg: Fix typing errors Thomas Huth
@ 2016-09-09 23:02 ` Laszlo Ersek
  0 siblings, 0 replies; 2+ messages in thread
From: Laszlo Ersek @ 2016-09-09 23:02 UTC (permalink / raw)
  To: Thomas Huth; +Cc: edk2-devel, Jordan Justen

Hi Thomas,

On 09/09/16 22:32, Thomas Huth wrote:
> Correct some typos (discovered with the codespell utility)
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c              | 2 +-
>  OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c           | 4 ++--
>  OvmfPkg/Library/NvVarsFileLib/FsAccess.c             | 4 ++--
>  OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 8 ++++----
>  OvmfPkg/PlatformPei/MemDetect.c                      | 2 +-
>  OvmfPkg/QemuVideoDxe/VbeShim.c                       | 2 +-
>  OvmfPkg/XenBusDxe/EventChannel.c                     | 2 +-
>  OvmfPkg/XenBusDxe/XenStore.c                         | 2 +-
>  OvmfPkg/XenPvBlkDxe/BlockIo.c                        | 2 +-
>  9 files changed, 14 insertions(+), 14 deletions(-)

thank you for the contribution. The patch is good (I verified it with
"git show --word-diff" as well; that helps a lot).

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

However, applying the patch exposed a preexistent LF/CRLF issue in
"OvmfPkg/Library/NvVarsFileLib/FsAccess.c". So, I will send a
three-patch series in a minute; the first two patches will clean up the
problems I found, and then the third patch will be yours (carrying my R-b).

Thanks!
Laszlo


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-09-09 23:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-09 20:32 [PATCH] OvmfPkg: Fix typing errors Thomas Huth
2016-09-09 23:02 ` Laszlo Ersek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox