Re: [PATCH 0/3] OvmfPkg: cosmetic fixes

[Jordan Justen <jordan.l.justen@intel.com>]

Thanks Thomas and Laszlo.

Series Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

On 2016-09-09 16:28:37, Laszlo Ersek wrote:
> Patch #3 was submitted by Thomas originally, and it was good, but it
> showed me that "OvmfPkg/Library/NvVarsFileLib/FsAccess.c" had LF line
> terminators actually. So I ran the following command, and went through
> the output:
> 
>   file $(find OvmfPkg/ -type f) | sort -t : -k 2b
> 
> The command found the following types:
> 
>   #1  ASCII text, with CRLF line terminators
>   #2  C source, ASCII text
>   #3  C source, ASCII text, with CRLF line terminators
>   #4  C source, UTF-8 Unicode text, with CRLF line terminators
>   #5  POSIX shell script, ASCII text executable
>   #6  Python script, ASCII text executable, with CRLF line terminators
>   #7  a /usr/bin/env bash script, ASCII text executable
> 
> From these, types #2 and #4 are problematic, so I added two patches in
> front of Thomas's to eliminate those file types (by converting the
> files).
> 
> (I also ran the command on ArmVirtPkg, it was fine.)
> 
> Public branch: <https://github.com/lersek/edk2/commits/cosmetic_fixes>.
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Thomas Huth <thuth@redhat.com>
> 
> Thanks
> Laszlo
> 
> Laszlo Ersek (2):
>   OvmfPkg/IndustryStandard: make "Xen/grant_table.h" pure ASCII
>   OvmfPkg: convert C files with LF line terminators to CRLF
> 
> Thomas Huth (1):
>   OvmfPkg: Fix typing errors
> 
>  OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c              |    2 +-
>  OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c           |    4 +-
>  OvmfPkg/Include/IndustryStandard/Xen/grant_table.h   |    2 +-
>  OvmfPkg/Library/NvVarsFileLib/FsAccess.c             | 1034 ++++++++++----------
>  OvmfPkg/Library/NvVarsFileLib/NvVarsFileLib.c        |  166 ++--
>  OvmfPkg/Library/NvVarsFileLib/NvVarsFileLib.h        |  122 +--
>  OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c |    8 +-
>  OvmfPkg/PlatformPei/MemDetect.c                      |    2 +-
>  OvmfPkg/QemuVideoDxe/VbeShim.c                       |    2 +-
>  OvmfPkg/SmbiosPlatformDxe/X86Xen.c                   |  196 ++--
>  OvmfPkg/VirtioRngDxe/VirtioRng.h                     |   92 +-
>  OvmfPkg/XenBusDxe/EventChannel.c                     |    2 +-
>  OvmfPkg/XenBusDxe/XenStore.c                         |    2 +-
>  OvmfPkg/XenPvBlkDxe/BlockIo.c                        |    2 +-
>  14 files changed, 818 insertions(+), 818 deletions(-)
> 
> -- 
> 2.9.2
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel