From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D019E1A1DF9 for ; Fri, 9 Sep 2016 17:17:21 -0700 (PDT) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP; 09 Sep 2016 17:17:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,307,1470726000"; d="scan'208";a="6531877" Received: from baldridg-mobl.amr.corp.intel.com (HELO localhost) ([10.252.143.18]) by fmsmga005.fm.intel.com with ESMTP; 09 Sep 2016 17:17:21 -0700 MIME-Version: 1.0 To: Laszlo Ersek , "edk2-devel-01" Message-ID: <147346664092.5020.12745236576049038837@jljusten-ivb> From: Jordan Justen In-Reply-To: <20160909232840.2353-1-lersek@redhat.com> References: <20160909232840.2353-1-lersek@redhat.com> User-Agent: alot/0.3.7 Date: Fri, 09 Sep 2016 17:17:20 -0700 Subject: Re: [PATCH 0/3] OvmfPkg: cosmetic fixes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Sep 2016 00:17:22 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Thanks Thomas and Laszlo. Series Reviewed-by: Jordan Justen On 2016-09-09 16:28:37, Laszlo Ersek wrote: > Patch #3 was submitted by Thomas originally, and it was good, but it > showed me that "OvmfPkg/Library/NvVarsFileLib/FsAccess.c" had LF line > terminators actually. So I ran the following command, and went through > the output: > = > file $(find OvmfPkg/ -type f) | sort -t : -k 2b > = > The command found the following types: > = > #1 ASCII text, with CRLF line terminators > #2 C source, ASCII text > #3 C source, ASCII text, with CRLF line terminators > #4 C source, UTF-8 Unicode text, with CRLF line terminators > #5 POSIX shell script, ASCII text executable > #6 Python script, ASCII text executable, with CRLF line terminators > #7 a /usr/bin/env bash script, ASCII text executable > = > From these, types #2 and #4 are problematic, so I added two patches in > front of Thomas's to eliminate those file types (by converting the > files). > = > (I also ran the command on ArmVirtPkg, it was fine.) > = > Public branch: . > = > Cc: Jordan Justen > Cc: Thomas Huth > = > Thanks > Laszlo > = > Laszlo Ersek (2): > OvmfPkg/IndustryStandard: make "Xen/grant_table.h" pure ASCII > OvmfPkg: convert C files with LF line terminators to CRLF > = > Thomas Huth (1): > OvmfPkg: Fix typing errors > = > OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 2 +- > OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c | 4 +- > OvmfPkg/Include/IndustryStandard/Xen/grant_table.h | 2 +- > OvmfPkg/Library/NvVarsFileLib/FsAccess.c | 1034 ++++++++++--= -------- > OvmfPkg/Library/NvVarsFileLib/NvVarsFileLib.c | 166 ++-- > OvmfPkg/Library/NvVarsFileLib/NvVarsFileLib.h | 122 +-- > OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 8 +- > OvmfPkg/PlatformPei/MemDetect.c | 2 +- > OvmfPkg/QemuVideoDxe/VbeShim.c | 2 +- > OvmfPkg/SmbiosPlatformDxe/X86Xen.c | 196 ++-- > OvmfPkg/VirtioRngDxe/VirtioRng.h | 92 +- > OvmfPkg/XenBusDxe/EventChannel.c | 2 +- > OvmfPkg/XenBusDxe/XenStore.c | 2 +- > OvmfPkg/XenPvBlkDxe/BlockIo.c | 2 +- > 14 files changed, 818 insertions(+), 818 deletions(-) > = > -- = > 2.9.2 > = > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel