From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: edk2-devel@lists.01.org, liming.gao@intel.com
Cc: leif.lindholm@linaro.org, vishalo@qti.qualcomm.com,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [PATCH v2 0/3] MdePkg/BaseMemoryLibOptDxe: generic and ARM/AARCH64 fixes
Date: Mon, 19 Sep 2016 09:13:48 +0100 [thread overview]
Message-ID: <1474272831-20840-1-git-send-email-ard.biesheuvel@linaro.org> (raw)
Some pending fixes for BaseMemoryLib* and BaseMemoryLibOptDxe, now resent
as a single series.
Patch #1 fixes an arithmetic bug in BaseMemoryLibOptDxe for ARM, which renders
it unusable at the moment.
Patch #2 adds some asserts that are mentioned in the respective comment blocks
but are missing from the code.
Patch #3 fixes a performance regressions observed by moving from the (soon to be
deprecated) BaseMemoryLibStm in ArmPkg to BaseMemoryLibOptDxe. The culprit has
been identified to be CompareGuid(), which needlessly uses unaligned accessors
(since this library can only be used in a context where unaligned accesses are
allowed)
Ard Biesheuvel (3):
MdePkg/BaseMemoryLibOptDxe ARM: fix arithmetic bugs in CompareMem()
MdePkg/BaseMemoryLib*: add missing ASSERT()s
MdePkg/BaseMemoryLibOptDxe ARM|AARCH64: implement accelerated GUID
functions
MdePkg/Library/BaseMemoryLib/MemLibGuid.c | 8 ++
MdePkg/Library/BaseMemoryLibMmx/MemLibGuid.c | 8 ++
MdePkg/Library/BaseMemoryLibOptDxe/AArch64/CompareGuid.S | 40 ++++++
MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareGuid.S | 66 +++++++++
MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareGuid.asm | 69 +++++++++
MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareMem.S | 4 +-
MdePkg/Library/BaseMemoryLibOptDxe/Arm/MemLibGuid.c | 152 ++++++++++++++++++++
MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf | 7 +-
MdePkg/Library/BaseMemoryLibOptDxe/MemLibGuid.c | 8 ++
MdePkg/Library/BaseMemoryLibOptPei/MemLibGuid.c | 8 ++
MdePkg/Library/BaseMemoryLibRepStr/MemLibGuid.c | 8 ++
MdePkg/Library/BaseMemoryLibSse2/MemLibGuid.c | 8 ++
MdePkg/Library/PeiMemoryLib/MemLibGuid.c | 8 ++
MdePkg/Library/UefiMemoryLib/MemLibGuid.c | 8 ++
14 files changed, 399 insertions(+), 3 deletions(-)
create mode 100644 MdePkg/Library/BaseMemoryLibOptDxe/AArch64/CompareGuid.S
create mode 100644 MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareGuid.S
create mode 100644 MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareGuid.asm
create mode 100644 MdePkg/Library/BaseMemoryLibOptDxe/Arm/MemLibGuid.c
--
2.7.4
next reply other threads:[~2016-09-19 8:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 8:13 Ard Biesheuvel [this message]
2016-09-19 8:13 ` [PATCH v2 1/3] MdePkg/BaseMemoryLibOptDxe ARM: fix arithmetic bugs in CompareMem() Ard Biesheuvel
2016-09-19 8:13 ` [PATCH v2 2/3] MdePkg/BaseMemoryLib*: add missing ASSERT()s Ard Biesheuvel
2016-09-20 2:00 ` Wu, Hao A
2016-09-20 8:38 ` Ard Biesheuvel
2016-09-20 12:02 ` Wu, Hao A
2016-09-20 12:16 ` Ard Biesheuvel
2016-09-20 12:40 ` Ard Biesheuvel
2016-09-21 1:27 ` Gao, Liming
2016-09-19 8:13 ` [PATCH v2 3/3] MdePkg/BaseMemoryLibOptDxe ARM|AARCH64: implement accelerated GUID functions Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474272831-20840-1-git-send-email-ard.biesheuvel@linaro.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox