[PATCH] ShellPkg: Remove current working dir path ".; " from 'path' variable

[PATCH] ShellPkg: Remove current working dir path ".; " from 'path' variable

[Tapan Shah]

As per ECR 1349, latest UEFI Shell 2.2 specification has removed current working directory
path ".;" from a default 'path' environment variable as current working directory always
search first in system.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Tapan Shah <tapandshah@hpe.com>
---
 ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
index a97361c..b65676b 100644
--- a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
+++ b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
@@ -1227,10 +1227,8 @@ ShellCommandAddMapItemAndUpdatePath(
     ASSERT((NewPath == NULL && NewPathSize == 0) || (NewPath != NULL));
     if (OriginalPath != NULL) {
       StrnCatGrow(&NewPath, &NewPathSize, OriginalPath, 0);
-    } else {
-      StrnCatGrow(&NewPath, &NewPathSize, L".\\", 0);
+      StrnCatGrow(&NewPath, &NewPathSize, L";", 0);
     }
-    StrnCatGrow(&NewPath, &NewPathSize, L";", 0);
     StrnCatGrow(&NewPath, &NewPathSize, Name, 0);
     StrnCatGrow(&NewPath, &NewPathSize, L"\\efi\\tools\\;", 0);
     StrnCatGrow(&NewPath, &NewPathSize, Name, 0);
-- 
1.9.5.msysgit.0

Re: [PATCH] ShellPkg: Remove current working dir path ".; " from 'path' variable

[Carsey, Jaben]

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
And commited.

> -----Original Message-----
> From: Tapan Shah [mailto:tapandshah@hpe.com]
> Sent: Wednesday, September 21, 2016 2:30 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Tapan Shah
> <tapandshah@hpe.com>
> Subject: [PATCH] ShellPkg: Remove current working dir path ".;" from 'path'
> variable
> Importance: High
> 
> As per ECR 1349, latest UEFI Shell 2.2 specification has removed current
> working directory
> path ".;" from a default 'path' environment variable as current working
> directory always
> search first in system.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Tapan Shah <tapandshah@hpe.com>
> ---
>  ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
> b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
> index a97361c..b65676b 100644
> --- a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
> +++ b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
> @@ -1227,10 +1227,8 @@ ShellCommandAddMapItemAndUpdatePath(
>      ASSERT((NewPath == NULL && NewPathSize == 0) || (NewPath != NULL));
>      if (OriginalPath != NULL) {
>        StrnCatGrow(&NewPath, &NewPathSize, OriginalPath, 0);
> -    } else {
> -      StrnCatGrow(&NewPath, &NewPathSize, L".\\", 0);
> +      StrnCatGrow(&NewPath, &NewPathSize, L";", 0);
>      }
> -    StrnCatGrow(&NewPath, &NewPathSize, L";", 0);
>      StrnCatGrow(&NewPath, &NewPathSize, Name, 0);
>      StrnCatGrow(&NewPath, &NewPathSize, L"\\efi\\tools\\;", 0);
>      StrnCatGrow(&NewPath, &NewPathSize, Name, 0);
> --
> 1.9.5.msysgit.0