[PATCH 0/2] MdeModulePkg:CapsuleUpdate: Correct INF usage

[PATCH 0/2] MdeModulePkg:CapsuleUpdate: Correct INF usage

[Jiewen Yao]

These 2 patches fix the INF PCD/PPI/Protocol usage in INF file.
No real code impact.

They are separated here just for eacy code review.
They will be merged into original capsule solution, in final check in.

Cc: Feng Tian <feng.tian@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>

Jiewen Yao (2):
  MdeModulePkg:SystemBiosUpdate: Correct INF PCD/protocol usage.
  MdeModulePkg:RecoveryModuleLoadPei: Correct INF PPI usage.

 MdeModulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadPei.inf       | 6 ++----
 MdeModulePkg/Universal/SystemBiosUpdate/SystemBiosReportDxe.inf     | 4 ++--
 MdeModulePkg/Universal/SystemBiosUpdate/SystemBiosUpdateDxe.inf     | 4 ++--
 3 files changed, 6 insertions(+), 8 deletions(-)

-- 
2.7.4.windows.1

[PATCH 1/2] MdeModulePkg:SystemBiosUpdate: Correct INF PCD/protocol usage.

[Jiewen Yao]

Cc: Feng Tian <feng.tian@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
---
 MdeModulePkg/Universal/SystemBiosUpdate/SystemBiosReportDxe.inf | 4 ++--
 MdeModulePkg/Universal/SystemBiosUpdate/SystemBiosUpdateDxe.inf | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/MdeModulePkg/Universal/SystemBiosUpdate/SystemBiosReportDxe.inf b/MdeModulePkg/Universal/SystemBiosUpdate/SystemBiosReportDxe.inf
index 9cda2ee..79a367d 100644
--- a/MdeModulePkg/Universal/SystemBiosUpdate/SystemBiosReportDxe.inf
+++ b/MdeModulePkg/Universal/SystemBiosUpdate/SystemBiosReportDxe.inf
@@ -53,10 +53,10 @@
 
 [Pcd]
   gEfiMdeModulePkgTokenSpaceGuid.PcdEdkiiSystemFmpCapsuleImageTypeIdGuid  ## CONSUMES
-  gEfiMdeModulePkgTokenSpaceGuid.PcdEdkiiSystemFirmwareImageDescriptor
+  gEfiMdeModulePkgTokenSpaceGuid.PcdEdkiiSystemFirmwareImageDescriptor    ## CONSUMES
 
 [Protocols]
-  gEfiFirmwareManagementProtocolGuid
+  gEfiFirmwareManagementProtocolGuid     ## PRODUCES
 
 [Depex]
   gEfiVariableArchProtocolGuid
diff --git a/MdeModulePkg/Universal/SystemBiosUpdate/SystemBiosUpdateDxe.inf b/MdeModulePkg/Universal/SystemBiosUpdate/SystemBiosUpdateDxe.inf
index 9e65641..f24800f 100644
--- a/MdeModulePkg/Universal/SystemBiosUpdate/SystemBiosUpdateDxe.inf
+++ b/MdeModulePkg/Universal/SystemBiosUpdate/SystemBiosUpdateDxe.inf
@@ -57,10 +57,10 @@
 
 [Pcd]
   gEfiMdeModulePkgTokenSpaceGuid.PcdEdkiiSystemFmpCapsuleImageTypeIdGuid  ## CONSUMES
-  gEfiMdeModulePkgTokenSpaceGuid.PcdEdkiiSystemFirmwareImageDescriptor
+  gEfiMdeModulePkgTokenSpaceGuid.PcdEdkiiSystemFirmwareImageDescriptor    ## CONSUMES
 
 [Protocols]
-  gEfiFirmwareManagementProtocolGuid
+  gEfiFirmwareManagementProtocolGuid     ## PRODUCES
 
 [Depex]
   gEfiVariableArchProtocolGuid
-- 
2.7.4.windows.1

[PATCH 2/2] MdeModulePkg:RecoveryModuleLoadPei: Correct INF PPI usage.

[Jiewen Yao]

Cc: Feng Tian <feng.tian@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
---
 .../Universal/RecoveryModuleLoadPei/RecoveryModuleLoadPei.inf       | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/MdeModulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadPei.inf b/MdeModulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadPei.inf
index 2f3bd7a..dd5d705 100644
--- a/MdeModulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadPei.inf
+++ b/MdeModulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadPei.inf
@@ -49,10 +49,8 @@
   PrintLib
 
 [Ppis]
-  gEfiPeiMasterBootModePpiGuid                  # PPI ALWAYS_PRODUCED
-  gEfiPeiBootInRecoveryModePpiGuid              # PPI SOMETIMES_PRODUCED
-  gEfiPeiRecoveryModulePpiGuid
-  gEfiPeiDeviceRecoveryModulePpiGuid
+  gEfiPeiRecoveryModulePpiGuid            ## PRODUCES
+  gEfiPeiDeviceRecoveryModulePpiGuid      ## CONSUMES
 
 [Guids]
   gEfiFmpCapsuleGuid                      ## SOMETIMES_CONSUMES ## GUID
-- 
2.7.4.windows.1

Re: [PATCH 0/2] MdeModulePkg:CapsuleUpdate: Correct INF usage

[Gao, Liming]

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Yao, Jiewen
> Sent: Saturday, September 24, 2016 2:41 PM
> To: edk2-devel@lists.01.org
> Cc: Tian, Feng <feng.tian@intel.com>; Zeng, Star <star.zeng@intel.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>
> Subject: [PATCH 0/2] MdeModulePkg:CapsuleUpdate: Correct INF usage
> 
> These 2 patches fix the INF PCD/PPI/Protocol usage in INF file.
> No real code impact.
> 
> They are separated here just for eacy code review.
> They will be merged into original capsule solution, in final check in.
> 
> Cc: Feng Tian <feng.tian@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
> 
> Jiewen Yao (2):
>   MdeModulePkg:SystemBiosUpdate: Correct INF PCD/protocol usage.
>   MdeModulePkg:RecoveryModuleLoadPei: Correct INF PPI usage.
> 
> 
> MdeModulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadP
> ei.inf       | 6 ++----
>  MdeModulePkg/Universal/SystemBiosUpdate/SystemBiosReportDxe.inf
> | 4 ++--
>  MdeModulePkg/Universal/SystemBiosUpdate/SystemBiosUpdateDxe.inf
> | 4 ++--
>  3 files changed, 6 insertions(+), 8 deletions(-)
> 
> --
> 2.7.4.windows.1