From: Liming Gao <liming.gao@intel.com>
To: edk2-devel@lists.01.org
Cc: Hao Wu <hao.a.wu@intel.com>
Subject: [Patch] BaseTools Build: Fix build break for clean target in Linux
Date: Thu, 29 Sep 2016 22:47:38 +0800 [thread overview]
Message-ID: <1475160458-16540-1-git-send-email-liming.gao@intel.com> (raw)
From: Hao Wu <hao.a.wu@intel.com>
In Linux, Command needs to be String instead of list when Command run
as shell with True.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
---
BaseTools/Source/Python/build/build.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Python/build/build.py
index b003c67..f17b55c 100644
--- a/BaseTools/Source/Python/build/build.py
+++ b/BaseTools/Source/Python/build/build.py
@@ -265,10 +265,10 @@ def LaunchCommand(Command, WorkingDir):
# It could be a string or sequence. We find that if command is a string in following Popen(),
# ubuntu may fail with an error message that the command is not found.
# So here we may need convert command from string to list instance.
- if not isinstance(Command, list):
- if platform.system() != 'Windows':
+ if platform.system() != 'Windows':
+ if not isinstance(Command, list):
Command = Command.split()
- Command = ' '.join(Command)
+ Command = ' '.join(Command)
Proc = None
EndOfProcedure = None
--
2.8.0.windows.1
next reply other threads:[~2016-09-29 14:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 14:47 Liming Gao [this message]
2016-09-30 1:41 ` [Patch] BaseTools Build: Fix build break for clean target in Linux Wu, Hao A
2016-09-30 4:40 ` Zhu, Yonghong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475160458-16540-1-git-send-email-liming.gao@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox