From: Jordan Justen <jordan.l.justen@intel.com>
To: Liming Gao <liming.gao@intel.com>, edk2-devel@lists.01.org
Subject: Re: [Patch 0/4] BaseTools: Enable optimization to generate fast code in C tools
Date: Fri, 30 Sep 2016 10:46:10 -0700 [thread overview]
Message-ID: <147525757022.2807.16411710990362182934@jljusten-ivb> (raw)
In-Reply-To: <1475158367-13120-1-git-send-email-liming.gao@intel.com>
On 2016-09-29 07:12:43, Liming Gao wrote:
> After enable optimization, C tool build time is reduced by ~50%. Please see
> below example to use LzmaCompress to compress OVMF DXEFV.
>
> Tool Compression time Decompression time
> LzmaCompress (GCC O0) 3.476s 0.204s
> LzmaCompress (GCC Ofast) 1.655s 0.107s
> LzmaCompress (VS Od) 3.047s 0.210s
> LzmaCompress (VS O2) 1.551s 0.126s
>
> Liming Gao (4):
> BaseTools EfiLdrImage: Remove unnecessary exit (0)
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
> BaseTools Makefile: Enable O2 option to replace Od for VS tool chain
I assume these flag changes work fine with the older versions of VS?
If so,
Acked-by: Jordan Justen <jordan.l.justen@intel.com>
> BaseTools GenVtf: Initialize the return point as NULL
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
> BaseTools Makefile: Enable Ofast option for GCC tool chain
If changed to -O2 (Thanks for the suggesion Laszlo):
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
>
> BaseTools/Source/C/EfiLdrImage/EfiLdrImage.c | 1 -
> BaseTools/Source/C/GenVtf/GenVtf.c | 1 +
> BaseTools/Source/C/Makefiles/header.makefile | 6 +++---
> BaseTools/Source/C/Makefiles/ms.app | 2 +-
> BaseTools/Source/C/Makefiles/ms.common | 4 ++--
> 5 files changed, 7 insertions(+), 7 deletions(-)
>
> --
> 2.8.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2016-09-30 17:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 14:12 [Patch 0/4] BaseTools: Enable optimization to generate fast code in C tools Liming Gao
2016-09-29 14:12 ` [Patch 1/4] BaseTools EfiLdrImage: Remove unnecessary exit (0) Liming Gao
2016-09-29 14:12 ` [Patch 2/4] BaseTools Makefile: Enable O2 option to replace Od for VS tool chain Liming Gao
2016-09-29 14:12 ` [Patch 3/4] BaseTools GenVtf: Initialize the return point as NULL Liming Gao
2016-09-29 14:12 ` [Patch 4/4] BaseTools Makefile: Enable Ofast option for GCC tool chain Liming Gao
2016-09-29 18:29 ` Laszlo Ersek
2016-09-30 0:24 ` Gao, Liming
2016-09-30 6:56 ` Gao, Liming
2016-09-30 9:49 ` Laszlo Ersek
2016-09-30 17:46 ` Jordan Justen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=147525757022.2807.16411710990362182934@jljusten-ivb \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox