From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3CD5B1A1E25 for ; Fri, 30 Sep 2016 10:46:11 -0700 (PDT) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP; 30 Sep 2016 10:46:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,273,1473145200"; d="scan'208";a="767627980" Received: from mabrow3x-mobl.amr.corp.intel.com (HELO localhost) ([10.252.130.51]) by FMSMGA003.fm.intel.com with ESMTP; 30 Sep 2016 10:46:11 -0700 MIME-Version: 1.0 To: Liming Gao , edk2-devel@lists.01.org Message-ID: <147525757022.2807.16411710990362182934@jljusten-ivb> From: Jordan Justen In-Reply-To: <1475158367-13120-1-git-send-email-liming.gao@intel.com> References: <1475158367-13120-1-git-send-email-liming.gao@intel.com> User-Agent: alot/0.3.7 Date: Fri, 30 Sep 2016 10:46:10 -0700 Subject: Re: [Patch 0/4] BaseTools: Enable optimization to generate fast code in C tools X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Sep 2016 17:46:11 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2016-09-29 07:12:43, Liming Gao wrote: > After enable optimization, C tool build time is reduced by ~50%. Please s= ee = > below example to use LzmaCompress to compress OVMF DXEFV. > = > Tool Compression time Decompression time > LzmaCompress (GCC O0) 3.476s 0.204s > LzmaCompress (GCC Ofast) 1.655s 0.107s > LzmaCompress (VS Od) 3.047s 0.210s > LzmaCompress (VS O2) 1.551s 0.126s > = > Liming Gao (4): > BaseTools EfiLdrImage: Remove unnecessary exit (0) Reviewed-by: Jordan Justen > BaseTools Makefile: Enable O2 option to replace Od for VS tool chain I assume these flag changes work fine with the older versions of VS? If so, Acked-by: Jordan Justen > BaseTools GenVtf: Initialize the return point as NULL Reviewed-by: Jordan Justen > BaseTools Makefile: Enable Ofast option for GCC tool chain If changed to -O2 (Thanks for the suggesion Laszlo): Reviewed-by: Jordan Justen > = > BaseTools/Source/C/EfiLdrImage/EfiLdrImage.c | 1 - > BaseTools/Source/C/GenVtf/GenVtf.c | 1 + > BaseTools/Source/C/Makefiles/header.makefile | 6 +++--- > BaseTools/Source/C/Makefiles/ms.app | 2 +- > BaseTools/Source/C/Makefiles/ms.common | 4 ++-- > 5 files changed, 7 insertions(+), 7 deletions(-) > = > -- = > 2.8.0.windows.1 > = > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel