public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Michael Kinney <michael.d.kinney@intel.com>
To: edk2-devel@lists.01.org
Subject: [Patch 3/5] QuarkPlatformPkg/PlatformHelperLib: Remove PlatformDebugPortGetChar8()
Date: Thu,  6 Oct 2016 12:12:03 -0700	[thread overview]
Message-ID: <1475781125-1472-4-git-send-email-michael.d.kinney@intel.com> (raw)
In-Reply-To: <1475781125-1472-1-git-send-email-michael.d.kinney@intel.com>

Remove the library function PlatformDebugPortGetChar8() from the
PlatformHelperLib that is no longer used by any modules.

Cc: Kelly Steele <kelly.steele@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
---
 .../Include/Library/PlatformHelperLib.h            | 16 +------------
 .../Library/PlatformHelperLib/PlatformHelperLib.c  | 27 ----------------------
 2 files changed, 1 insertion(+), 42 deletions(-)

diff --git a/QuarkPlatformPkg/Include/Library/PlatformHelperLib.h b/QuarkPlatformPkg/Include/Library/PlatformHelperLib.h
index 7b4119d..cf884e1 100644
--- a/QuarkPlatformPkg/Include/Library/PlatformHelperLib.h
+++ b/QuarkPlatformPkg/Include/Library/PlatformHelperLib.h
@@ -1,7 +1,7 @@
 /** @file
 PlatformHelperLib function prototype definitions.
 
-Copyright (c) 2013 - 2016 Intel Corporation.
+Copyright (c) 2013 - 2016 Intel Corporation.
 
 This program and the accompanying materials
 are licensed and made available under the terms and conditions of the BSD License
@@ -46,20 +46,6 @@ PlatformFindFvFileRawDataSection (
   );
 
 /**
-  Read 8bit character from debug stream.
-
-  Block until character is read.
-
-  @return 8bit character read from debug stream.
-
-**/
-CHAR8
-EFIAPI
-PlatformDebugPortGetChar8 (
-  VOID
-  );
-
-/**
   Find free spi protect register and write to it to protect a flash region.
 
   @param   DirectValue      Value to directly write to register.
diff --git a/QuarkPlatformPkg/Library/PlatformHelperLib/PlatformHelperLib.c b/QuarkPlatformPkg/Library/PlatformHelperLib/PlatformHelperLib.c
index f9ceda4..768ea14 100644
--- a/QuarkPlatformPkg/Library/PlatformHelperLib/PlatformHelperLib.c
+++ b/QuarkPlatformPkg/Library/PlatformHelperLib/PlatformHelperLib.c
@@ -91,33 +91,6 @@ WriteFirstFreeSpiProtect (
 //
 
 /**
-  Read 8bit character from debug stream.
-
-  Block until character is read.
-
-  @return 8bit character read from debug stream.
-
-**/
-CHAR8
-EFIAPI
-PlatformDebugPortGetChar8 (
-  VOID
-  )
-{
-  CHAR8                             Got;
-
-  do {
-    if (SerialPortPoll ()) {
-      if (SerialPortRead ((UINT8 *) &Got, 1) == 1) {
-        break;
-      }
-    }
-  } while (TRUE);
-
-  return Got;
-}
-
-/**
   Clear SPI Protect registers.
 
   @retval EFI_SUCCESS        SPI protect registers cleared.
-- 
2.6.3.windows.1



  parent reply	other threads:[~2016-10-06 19:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-06 19:12 [Patch 0/5] QuarkPlatformPkg: Fix BOOT_IN_RECOVERY_MODE issues Michael Kinney
2016-10-06 19:12 ` [Patch 1/5] QuarkPlatformPkg/ForceRecovery: Add UEFI application to force recovery Michael Kinney
2016-10-06 19:12 ` [Patch 2/5] QuarkPlatformPkg/PlatformInit: Fix recovery detection issues Michael Kinney
2016-10-06 19:12 ` Michael Kinney [this message]
2016-10-06 19:12 ` [Patch 4/5] QuarkPlatformPkg: Add ForceRecovery UEFI application Michael Kinney
2016-10-06 19:12 ` [Patch 5/5] QuarkPlatformPkg/RecoveryOemHookLib: Remove RecoveryOemHookLib Michael Kinney
2016-10-07 19:26 ` [Patch 0/5] QuarkPlatformPkg: Fix BOOT_IN_RECOVERY_MODE issues Steele, Kelly
2016-10-07 21:02   ` Steele, Kelly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1475781125-1472-4-git-send-email-michael.d.kinney@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox