* [PATCH] ArmPlatformPkg/PlatformPeiLib: allow patch PCDs for FV base address/size
@ 2016-10-07 15:14 Ard Biesheuvel
2016-10-07 15:15 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2016-10-07 15:14 UTC (permalink / raw)
To: edk2-devel; +Cc: leif.lindholm, Ard Biesheuvel
Allow patchable or dynamic PCDs to be used for PcdFvBaseAddress and
PcdFvBaseSize, so that platforms whose UEFI image may be loaded anywhere
in memory can use PlatformPeiLib.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf b/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf
index 314789d0a990..2363d9aa966e 100644
--- a/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf
+++ b/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf
@@ -39,15 +39,6 @@ [Ppis]
gEfiPeiMasterBootModePpiGuid # PPI ALWAYS_PRODUCED
gEfiPeiBootInRecoveryModePpiGuid # PPI SOMETIMES_PRODUCED
-[FixedPcd]
- gArmTokenSpaceGuid.PcdFdBaseAddress
- gArmTokenSpaceGuid.PcdFdSize
-
+[Pcd]
gArmTokenSpaceGuid.PcdFvBaseAddress
gArmTokenSpaceGuid.PcdFvSize
-
- gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize
- gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize
-
-[depex]
- TRUE
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ArmPlatformPkg/PlatformPeiLib: allow patch PCDs for FV base address/size
2016-10-07 15:14 [PATCH] ArmPlatformPkg/PlatformPeiLib: allow patch PCDs for FV base address/size Ard Biesheuvel
@ 2016-10-07 15:15 ` Ard Biesheuvel
2016-10-07 15:51 ` Leif Lindholm
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2016-10-07 15:15 UTC (permalink / raw)
To: edk2-devel-01; +Cc: Leif Lindholm, Ard Biesheuvel
On 7 October 2016 at 16:14, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> Allow patchable or dynamic PCDs to be used for PcdFvBaseAddress and
> PcdFvBaseSize, so that platforms whose UEFI image may be loaded anywhere
> in memory can use PlatformPeiLib.
>
... and also, drop some references to PCDs that are in fact not used.
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf b/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf
> index 314789d0a990..2363d9aa966e 100644
> --- a/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf
> +++ b/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf
> @@ -39,15 +39,6 @@ [Ppis]
> gEfiPeiMasterBootModePpiGuid # PPI ALWAYS_PRODUCED
> gEfiPeiBootInRecoveryModePpiGuid # PPI SOMETIMES_PRODUCED
>
> -[FixedPcd]
> - gArmTokenSpaceGuid.PcdFdBaseAddress
> - gArmTokenSpaceGuid.PcdFdSize
> -
> +[Pcd]
> gArmTokenSpaceGuid.PcdFvBaseAddress
> gArmTokenSpaceGuid.PcdFvSize
> -
> - gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize
> - gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize
> -
> -[depex]
> - TRUE
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ArmPlatformPkg/PlatformPeiLib: allow patch PCDs for FV base address/size
2016-10-07 15:15 ` Ard Biesheuvel
@ 2016-10-07 15:51 ` Leif Lindholm
0 siblings, 0 replies; 3+ messages in thread
From: Leif Lindholm @ 2016-10-07 15:51 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel-01
On Fri, Oct 07, 2016 at 04:15:36PM +0100, Ard Biesheuvel wrote:
> On 7 October 2016 at 16:14, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> > Allow patchable or dynamic PCDs to be used for PcdFvBaseAddress and
> > PcdFvBaseSize, so that platforms whose UEFI image may be loaded anywhere
> > in memory can use PlatformPeiLib.
> >
>
> ... and also, drop some references to PCDs that are in fact not used.
>
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > ---
> > ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf | 11 +----------
> > 1 file changed, 1 insertion(+), 10 deletions(-)
> >
> > diff --git a/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf b/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf
> > index 314789d0a990..2363d9aa966e 100644
> > --- a/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf
> > +++ b/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf
> > @@ -39,15 +39,6 @@ [Ppis]
> > gEfiPeiMasterBootModePpiGuid # PPI ALWAYS_PRODUCED
> > gEfiPeiBootInRecoveryModePpiGuid # PPI SOMETIMES_PRODUCED
> >
> > -[FixedPcd]
> > - gArmTokenSpaceGuid.PcdFdBaseAddress
> > - gArmTokenSpaceGuid.PcdFdSize
> > -
> > +[Pcd]
> > gArmTokenSpaceGuid.PcdFvBaseAddress
> > gArmTokenSpaceGuid.PcdFvSize
> > -
> > - gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize
> > - gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize
> > -
> > -[depex]
> > - TRUE
So, especially the depex drop makes me prefer seeing the cleanup as a
separate patch.
Otherwise, looks good to me.
/
Leif
> > --
> > 2.7.4
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-07 15:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-07 15:14 [PATCH] ArmPlatformPkg/PlatformPeiLib: allow patch PCDs for FV base address/size Ard Biesheuvel
2016-10-07 15:15 ` Ard Biesheuvel
2016-10-07 15:51 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox