public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Tapan Shah <tapandshah@hpe.com>
To: edk2-devel@lists.01.org
Cc: jaben.carsey@intel.com, Tapan Shah <tapandshah@hpe.com>
Subject: [PATCH] ShellPkg:‘cd \’ command fails to go back to the root directory of a file system
Date: Fri,  7 Oct 2016 15:59:34 -0500	[thread overview]
Message-ID: <1475873974-3896-1-git-send-email-tapandshah@hpe.com> (raw)

Allows cd command to go back to the root directory when 'cd \' executed in system.

This change prevents last PathRemoveLastItem() call which truncates '\' from 'fs0:\'
in desired root path which is required to set CWD to the root directory.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Tapan Shah <tapandshah@hpe.com>
---
 ShellPkg/Library/UefiShellLevel2CommandsLib/Cd.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Cd.c b/ShellPkg/Library/UefiShellLevel2CommandsLib/Cd.c
index 2e51b4c..0967bc7 100644
--- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Cd.c
+++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Cd.c
@@ -1,6 +1,7 @@
 /** @file
   Main file for attrib shell level 2 function.
 
+  (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
   (C) Copyright 2015 Hewlett-Packard Development Company, L.P.<BR>
   Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
@@ -164,7 +165,16 @@ ShellCommandRunCd (
               StrCpyS (Cwd, StrSize (Directory) / sizeof (CHAR16) + 1, Directory);
               StrCatS (Cwd, StrSize (Directory) / sizeof (CHAR16) + 1, L"\\");
               Drive = GetFullyQualifiedPath (Cwd);
-              while (PathRemoveLastItem (Drive));
+              while (PathRemoveLastItem (Drive)) {
+                //
+                // Check if Drive contains 'fsx:\' only or still points to a sub-directory.
+                // Don't remove trailing '\' from Drive if it points to the root directory.
+                //
+                Path = StrStr (Drive, L":\\");
+                if ((Path != NULL) && (*(Path + 2) == CHAR_NULL)) {
+                  break;
+                }
+              }
               FreePool (Cwd);
             }
           }
-- 
1.9.5.msysgit.0



             reply	other threads:[~2016-10-07 20:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-07 20:59 Tapan Shah [this message]
2016-10-12 17:25 ` [PATCH] ShellPkg:‘cd \’ command fails to go back to the root directory of a file system Carsey, Jaben

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1475873974-3896-1-git-send-email-tapandshah@hpe.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox