From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eu-smtp-delivery-143.mimecast.com (eu-smtp-delivery-143.mimecast.com [207.82.80.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5C7881A1E10 for ; Mon, 17 Oct 2016 01:55:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=gQMmjiW0C/i/7qlW7nyVvvsVUU6aX5LdwBs/zVR7v0w=; b=QBnJ71gTXYKz3EnyrPpHDuUfRwq4yUSkfGiaspmKtskTgaqy03KpP62+Zqgo0azApBBNBGVx/vbkZkfLT1kQUv0ndqsS6FJuCTOZ4MSPTuWM5l7kTcVqrbgidKPGCkVIAEknVf7VfKphYrlckxIpxMHE0yjEZzhClNyGCqX9iDU= Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01lp0239.outbound.protection.outlook.com [213.199.154.239]) (Using TLS) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-40-QxLlIgD4OdqMsikORiwO3g-1; Mon, 17 Oct 2016 09:55:29 +0100 Received: from DB6PR0801CA0002.eurprd08.prod.outlook.com (10.165.173.140) by VI1PR08MB1117.eurprd08.prod.outlook.com (10.166.45.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.659.11; Mon, 17 Oct 2016 08:55:27 +0000 Received: from DB3FFO11FD005.protection.gbl (2a01:111:f400:7e04::171) by DB6PR0801CA0002.outlook.office365.com (2603:10a6:4:2::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.12 via Frontend Transport; Mon, 17 Oct 2016 08:55:27 +0000 Received: from nebula.arm.com (217.140.96.140) by DB3FFO11FD005.mail.protection.outlook.com (10.47.216.94) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.669.7 via Frontend Transport; Mon, 17 Oct 2016 08:55:26 +0000 Received: from dennis-ws.asiapac.arm.com (10.1.2.79) by mail.arm.com (10.1.106.66) with Microsoft SMTP Server id 14.3.294.0; Mon, 17 Oct 2016 09:55:07 +0100 From: Dennis Chen To: CC: , Dennis Chen , Ard Biesheuvel , Leif Lindholm , "Laszlo Ersek" Date: Mon, 17 Oct 2016 16:54:51 +0800 Message-ID: <1476694491-29933-1-git-send-email-dennis.chen@arm.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:217.140.96.140; IPV:CAL; SCL:-1; CTRY:GB; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(189002)(199003)(50986999)(77096005)(5660300001)(47776003)(50466002)(229853001)(2351001)(48376002)(626004)(110136003)(106466001)(5003940100001)(4326007)(26826002)(36756003)(6666003)(586003)(33646002)(356003)(104016004)(246002)(2906002)(6916009)(189998001)(7846002)(8936002)(86362001)(87936001)(50226002)(8676002)(11100500001)(305945005)(92566002)(19580395003)(19580405001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB1117; H:nebula.arm.com; FPR:; SPF:Pass; PTR:fw-tnat.cambridge.arm.com; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; DB3FFO11FD005; 1:mb5R7Z5g2fZYEERpxmo/l3biXvp08tVGeIClIdfOysF5g6ziRTZgfKBSgZthbd0Ts1q7vlFifcch8Njf35z7frHNNbP9oYCgBIuhH5eQJ/ECl2HohplcGtHF+8TqzhfBmMywinQ9SjiyNlctjtwqZlkLgCreql1sv8lO6pjoYpRsehCXfqtt0UKdz71jBo7Zvs1wciifL2S+24k/CdQzVU8TbYGnqJZ1mRHbV4VTrpIklSw4yiK9vWTR8fg7wfaEmS1xJWTddvtPG9fB4YdqVjzQV+fj/QizPf8puf0FrX8rucljxBXp42iepzgOVq3czshDAUM2MitlmCLgHnPk8ZJadztLoT5MlL/5HX/DupIQFaKVK4rX3kiosPcinYQl+qa+OauxKjEPM2Tzjbpi5UbuoKaUmvqZlkQKpgEZzHPN4Y15HAvJXpWG+J3Dx18qOXmBmL36WqRN5re5uXoHmg3qgkLx3wpgLvT6p8/f76P5gzKYYCS3zozkGdp1mr9NJU8yamCYiuzu1yG1qTkVp1Avt/q6zvJ3B5JbwPGmAP6m0V97X7dDi6C8hk9L/yn0utnh/5kAu/KvS451KZfQkcDNY+/a5FkjxLG2Av/OLb0= X-MS-Office365-Filtering-Correlation-Id: 8face0e8-60ae-4c82-2d3b-08d3f66b570a X-Microsoft-Exchange-Diagnostics: 1; VI1PR08MB1117; 2:D0xifalSa6FSTOCCUFmd2ItQakp5GcHaMEEd4TA+F+e6ZthZNoozhEEDcbaht0C3DnZrigqNYa6qd9K0hUqYDn6grjTJ1rEgCEM8UYnxCCSE+1TE0BXECdbKDT5BqWDc7vtgmQnu8zB77xuBIulfxMyCqZBc7lCxQfV7lxnYqvP5xLpGQxIot4WdnfL6q8gS8aKFe9Ou89v1gfRg/6kFbQ==; 3:JnFMViUiXE0ivspxLDLKf/k3YwBjZQcN89C59h0KyM3MnmZtoxmuy2/Vw2+GOKL53xiMfhCTcVTkw8PTLufDczxQoRQCjUNex+xpW0MXM82rCiARH83Lrxj7KuJtY/Ev2W66c1EXxKg7d+rOvoQMNbTQI9jGtayjO8Qp2nh9B53kZRyx3/0jXN/X2EA3Sweluw860/4bmo69Cz1PnITjjcS+6pqD84lKfGF90cxO9znAbH2kR8KT37aI+QFo7For6a9hhRKT0XnS2cZYp3iMU4Kjmn9kRXLFP3DWVczGKhc=; 25:avX7a4Z5KR72nYM7eA519rCdCVYKXiqyzD1Q9UJxKF/dC4HSt/CzAuMo5uW76W+RcCkbx1wtEZ+oAMgqTIfhsn7GAUrydJYI/9TodP65qap1PnzBl0lLT7Mc4cdSLU3Lobvw8uWqijC3nB35WoLrU3+6+h7bIwlxYaR8ye6zx5ZrdMiMWkIjVcqBOSF471MKqX/W4J0STgIuHZtD3LWmpUrAJ2xYDUB8h5tFTBG6+5+dX/jCcCkRLW9/Q1+D1704X4Ay/GsITomIfPEtfCfEtHfaJpNTuoP4Jq81lkS6v2f742mkuOQni+n0bp3FJURJBn8nE676vPzyEjSLCm4A3+/VJUpgsgSDSsoUxw4dXXJV2Aj7cAzXo7IKPwhw3PC8cEb2v+tSDh9JLsDU8+Y/aTa8tQ1lZGY3BEgmsNxJ5sJd8gfOx7fYEgS7VP3LOaBY X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(8251501002); SRVR:VI1PR08MB1117; X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; VI1PR08MB1117; 31:vLJiTdHss7ccpW7PxSzcfa3oIo1UC2ysJAnXlyVMVb+1KiPS17HzyOtTYDfLOl6o4+2HqSLv50lvEQ9DtQZWdnosLMxki2iLgGAH8RhKJRBVIavqDOZs8kVbchrnQlMA1dau7zuq6EO8xFCc0UVmNoZaLYAKbyNBchnyNl4Za219RkCdJrFaoCznZMi+tb6Y4k5+OCyDRucVaE6O89KARjkJT2eoFfUVa4Ib4lqb81lWldKxdnsYidbHqLwoY6sO; 20:GAkTKRvMyF47GQ/ssiEpc4cV9oYuFt2BZM8WEbpcPFa7znWUy8EiB0QQV6q12ngJr+ZF+kV1XI8C9WteOLszysZsCUDetypm+h7MNtpOQ8WQPG7woCZsHkOh2pnsXzXCz39RXLtpQuL4ETd549JhIHMPFW7HSbd9SYmA999g/sFWAXjzHSmN9v2tdxZfYmMQbXZ88ZZ7VxKXz0egwvs6siWF4Eo7LUANco6OWqqXC9j1Vdk071DcIFOlxomUR0Dz NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(13024025)(13023025)(5005006)(8121501046)(13020025)(13013025)(10201501046)(3002001)(6055026); SRVR:VI1PR08MB1117; BCL:0; PCL:0; RULEID:; SRVR:VI1PR08MB1117; X-Microsoft-Exchange-Diagnostics: 1; VI1PR08MB1117; 4:/vkoSuXAglFUCowVBspoR8CwqCZ1gfJfDdSAqk2LlHCsheNp0r1FPh1DoalhjJnMC6Kt8XxTEbxQMlBuORc7sB/xSWCIkIfGRcgMSlx8+0/3eUwg0Z0eYh+CPvWrkBnlh/rKvHmpi/CKTBo+teX2Yn3dVM6lMkyQIKw7a92FuEnBoyJkvwueTShI9j33ikyGhqP2C4YQSNuqPi8eSIfr4wlJ/cvD1zFkUU+xDsdbYpNHtuWDnWIPfxhQM3zYqDaYLoCJKtfNUxeUjlwLFs2QOZGuuPH3s/C416iMKwkyqYBidZn6mX31gpBHHa57o/1iSMr16bIHAyS74aPnpfVSSCR2S76RW0s8OG08/JrKHS4sVR45kJirQC+wmCfRXHjXX8Kawc0PZ60xQfF0Mxn5xI/MBjkrNmMQH9btTROtIP8qIgFUMjer08fMZs11fA6xPAV0Mc+3URFo7RTXuxBN8Ipbb9nNDP/xD/JnBcU4R07wIRBNTvWFWGns48Sx1undabjC3b7/uNCLDj8W8UQVorB+mjAmTfTMmrgBN35wokM= X-Forefront-PRVS: 0098BA6C6C X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR08MB1117; 23:nmvo88f9Ii16yGzLV2KwE892jFUZoXqr6uMWS4W5I?= =?us-ascii?Q?zDfTL1ik0wkmqWmNZB4kw8PJ9xR0vhc1c/+sRq9oVNLQstFZ7pRgc0e+cHRI?= =?us-ascii?Q?o7O06tNeccD8mTzSCd1vBidkWbQiscAt4raYbyN9RLe/toWyuSMxwSbAjk76?= =?us-ascii?Q?cbDC/eA8lF9txd8ALIKtK2o0iRs+tUkhPFA+0S+CMzeoz1ZZUI+IGqtndADy?= =?us-ascii?Q?z6sDm7eEKyBHE8yh01lzKgORSUOUfAz5aKMvhTiduMJfFqYGMn3+oh3ukutm?= =?us-ascii?Q?xTD0tGEperFI4oIN82do/Cl7fJ7mxvIgU0WTSK7Zgb8cBtBXLg0T+VnHPupN?= =?us-ascii?Q?mnFrsUCcLt3QVo8j0FvolCjveGq65vi1zZGnjNE7s6Lnwctb/4OjsLgNAH01?= =?us-ascii?Q?VkQoJFJAjNs3eEA3Jm0x46mBHqIZuevVOWdWLUwg8eazot/e3SHysGAy009m?= =?us-ascii?Q?nqJaHkOos1VWeALtWAuQwOg86ZED/ZfzaWIEWPE4U4UaDhZhW/Ca5yctlKNs?= =?us-ascii?Q?cx552sXcG7NFz3c/6lyswu6p+QpzG1kcpoBhBIMBAynUQekqaApxvSMrf73t?= =?us-ascii?Q?E8r5jfRNweqRrVPyB7VLQ19UEB91zSIFkQMbfqmvn9K7zlwbWdDW73uCytBC?= =?us-ascii?Q?ZCRbunnwwVcWnemLOaVRvCLeMPDvS/r5tuD4nVo5PwnOMzJDhkyhK/cOQxXn?= =?us-ascii?Q?bxEaByd3HNYRbSuGHYx+VSN+KSnWmfMiO+lCR7GFIxzd0eSXYhCl2E6vqxy6?= =?us-ascii?Q?iI6DrjWmHitFkoEwvJqUMOpzA+uA5r/HKIafxxkpwYLIWqdGrLJez2kS5wiQ?= =?us-ascii?Q?4RDFkhlfGRuR8WKf8SXQ5v/4daxRqMQwNAJP8d+WjEcRsB5RSE7kgT3ngeKx?= =?us-ascii?Q?2S04JSg61irZzJXVKM5LEuipOCYL2g4ZaBuheXRMgp9CEWuGDX1ikJSa28y2?= =?us-ascii?Q?OQ2/getfFdaUhf2OoYL1S47wDTu78CQabw/Zrd6me6Ar+iFCOBcy4IirwFlx?= =?us-ascii?Q?tzGvPKyOpLb+f9nrbJwNFFzejUiIjyFCHJJzlq5jjBIhA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; VI1PR08MB1117; 6:lw59/xyb13Q1e6SxfG853DTzak+gPuiFsUPflK6O6wO/GkapqC6dh7z0RZXoIDr0nF1/I/HKIin4nxbavxo9glwdL5T01O3WUUWpkKa0TDgdfgfjz41X5UVQhFetj26ljB1zaThoOTeJX1U2JGOfGDcPBRE1teXODmj7rdHxygRRWzaQ5oLEjMRXQLXk3zkK+qIfllPt1iRyw9/nEInGtLD+19YzWv0A8VNHOO4wz0fcB6DfDdoLzJfsU6aVicSmqiWwLruRXXC9ZZTPkAWro6f+dpgqvwG0Age0VjfaUDsuDf4CZQs+yQ8yOOwnKndjZoD1ZKNax3VblQYt/cJJfhG6P5lzC0FDmJUyVxQWIi0=; 5:fmxa6PLAousrmkgYJs7te0tkzIac9tJIU99BwPs9IdfLs9cYGNP84h3yV2NbDIfa4dxAoQ5gfgKzqIaC7G5Pp11RrWJaFdW6apCuFwE5Fmqg1UFDQv2sDWQ01yFN2zTYJ0d7DbF62ujf1QLnQhIsGQAXl/Xy4dNcER27CSLUWqA=; 24:ZE9zk4jp+n5ALNMiUEAyKOibkEpmqSN1cW/ae4o4oTqLLKscwxERMQa0K7Q9Bo8gQXT/8+4x0me7YjkNH0UgFHd4v7En1ejaHVpFz6DUJtw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR08MB1117; 7:8lSNKygQozlMODl78yosRqIE+unAJ/oTXuLO1nEk/h0fcNWYIxX6eYGKQd4DSkugoDmaxmQsKSBt9nYD3G9pKQShLlgEFQaDL53Zi7WiBfWqt3zQ2W8hW0/L68UysFTAE595SLRQW9zAd0SWQQp6kdD+mFnhq7Lp+CYBBKqZae3RRBMOF7VBxg87lPpigJnoV69acpIk7gx2uiMJYVZ7aw91wNp/tqi/YQfrapJ5KJFlTBI93BePxUCISZ9aNZvwm8lVWjn4FxF8G7DQiGQ3Ap61zZxsaPa2ei1LmNPS+GHCK2wdt4/1cUIkqtKQ1cr1doqxOIoGfV56GVkg2Q2tETUK3NhtJ6sZwQ+8w0R5tEA= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2016 08:55:26.9250 (UTC) X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[217.140.96.140]; Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB1117 X-MC-Unique: QxLlIgD4OdqMsikORiwO3g-1 Subject: [PATCH] ArmVirtPkg: Drop the nonsense ASSERT() statement X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2016 08:55:32 -0000 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Since All the GIC base address variables now are 64-bit, given that a UNIT64 var cannot exceed MAX_UNIT64, it doesn't make sense to continue keep them in the codes, so this patch just simply drop those ASSERT() statements as it should be. Contributed-under: TianoCore Contribution Agreement 1.0 Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Laszlo Ersek Signed-off-by: Dennis Chen --- ArmVirtPkg/Library/ArmVirtGicArchLib/ArmVirtGicArchLib.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/ArmVirtPkg/Library/ArmVirtGicArchLib/ArmVirtGicArchLib.c b/Arm= VirtPkg/Library/ArmVirtGicArchLib/ArmVirtGicArchLib.c index 64afc4d..7a312e5 100644 --- a/ArmVirtPkg/Library/ArmVirtGicArchLib/ArmVirtGicArchLib.c +++ b/ArmVirtPkg/Library/ArmVirtGicArchLib/ArmVirtGicArchLib.c @@ -79,11 +79,9 @@ ArmVirtGicArchLibConstructor ( =20 // RegProp[0..1] =3D=3D { GICD base, GICD size } DistBase =3D SwapBytes64 (Reg[0]); - ASSERT (DistBase < MAX_UINT32); =20 // RegProp[2..3] =3D=3D { GICR base, GICR size } RedistBase =3D SwapBytes64 (Reg[2]); - ASSERT (RedistBase < MAX_UINT32); =20 PcdSet64 (PcdGicDistributorBase, DistBase); PcdSet64 (PcdGicRedistributorsBase, RedistBase); @@ -117,8 +115,6 @@ ArmVirtGicArchLibConstructor ( =20 DistBase =3D SwapBytes64 (Reg[0]); CpuBase =3D SwapBytes64 (Reg[2]); - ASSERT (DistBase < MAX_UINT32); - ASSERT (CpuBase < MAX_UINT32); =20 PcdSet64 (PcdGicDistributorBase, DistBase); PcdSet64 (PcdGicInterruptInterfaceBase, CpuBase); --=20 2.7.4