From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B667D1A1E30 for ; Mon, 17 Oct 2016 09:40:12 -0700 (PDT) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP; 17 Oct 2016 09:40:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,357,1473145200"; d="scan'208";a="890847771" Received: from ahjahagi-mobl1.amr.corp.intel.com (HELO localhost) ([10.252.140.179]) by orsmga003.jf.intel.com with ESMTP; 17 Oct 2016 09:40:13 -0700 MIME-Version: 1.0 To: Yonghong Zhu , edk2-devel@lists.01.org Message-ID: <147672241192.943.11101366099892161885@jljusten-ivb> From: Jordan Justen In-Reply-To: <1476692918-10716-2-git-send-email-yonghong.zhu@intel.com> Cc: "Liming Gao" References: <1476692918-10716-1-git-send-email-yonghong.zhu@intel.com> <1476692918-10716-2-git-send-email-yonghong.zhu@intel.com> User-Agent: alot/0.3.7 Date: Mon, 17 Oct 2016 09:40:11 -0700 Subject: Re: [Patch 1/3] BaseTools: Update PatchCheck for max length of subject and message line X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2016 16:40:12 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2016-10-17 01:28:36, Yonghong Zhu wrote: > This patch update PatchCheck.py: > 1. The subject line of the commit message should be < 72 characters. > 2. The other lines of the commit message should be < 76 characters. > = > Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=3D113 > = Can you remove the blank line after 'Fixes:'? The end of the commit message has various tags, like Fixes, Cc, Contributed-under, Signed-off-by, Reviewed-by, etc. They can be one tag per line and grouped together. Patch 1 Reviewed-by: Jordan Justen > Cc: Liming Gao > Cc: Jordan Justen > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Yonghong Zhu > --- > BaseTools/Scripts/PatchCheck.py | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > = > diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchChe= ck.py > index 455c130..07fca68 100755 > --- a/BaseTools/Scripts/PatchCheck.py > +++ b/BaseTools/Scripts/PatchCheck.py > @@ -1,9 +1,9 @@ > ## @file > # Check a patch for various format issues > # > -# Copyright (c) 2015, Intel Corporation. All rights reserved.
> +# Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
> # > # This program and the accompanying materials are licensed and made > # available under the terms and conditions of the BSD License which > # accompanies this distribution. The full text of the license may be > # found at http://opensource.org/licenses/bsd-license.php > @@ -14,11 +14,11 @@ > # > = > from __future__ import print_function > = > VersionNumber =3D '0.1' > -__copyright__ =3D "Copyright (c) 2015, Intel Corporation All rights res= erved." > +__copyright__ =3D "Copyright (c) 2015 - 2016, Intel Corporation All rig= hts reserved." > = > import email > import argparse > import os > import re > @@ -195,11 +195,11 @@ class CommitMessageCheck: > = > if count <=3D 0: > self.error('Empty commit message!') > return > = > - if count >=3D 1 and len(lines[0]) > 76: > + if count >=3D 1 and len(lines[0]) >=3D 72: > self.error('First line of commit message (subject line) ' + > 'is too long.') > = > if count >=3D 1 and len(lines[0].strip()) =3D=3D 0: > self.error('First line of commit message (subject line) ' + > @@ -208,11 +208,11 @@ class CommitMessageCheck: > if count >=3D 2 and lines[1].strip() !=3D '': > self.error('Second line of commit message should be ' + > 'empty.') > = > for i in range(2, count): > - if (len(lines[i]) > 76 and > + if (len(lines[i]) >=3D 76 and > len(lines[i].split()) > 1 and > not lines[i].startswith('git-svn-id:')): > self.error('Line %d of commit message is too long.' % (i= + 1)) > = > last_sig_line =3D None > -- = > 2.6.1.windows.1 > = > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel