From: Jordan Justen <jordan.l.justen@intel.com>
To: Gary Lin <glin@suse.com>, edk2-devel@lists.01.org
Cc: "Andrew Fish" <afish@apple.com>, Laszlo Ersek <lersek@redhat.com>,
Subject: Re: [PATCH 08/33] EmulatorPkg: Fix typos in comments and variables
Date: Wed, 19 Oct 2016 13:37:47 -0700 [thread overview]
Message-ID: <147690946737.18651.17915111261589019699@jljusten-ivb> (raw)
In-Reply-To: <20161019070138.16424-9-glin@suse.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Pushed EmulatorPkg and OvmfPkg patches.
On 2016-10-19 00:01:13, Gary Lin wrote:
> - Predfined -> Predefined
> - minimue -> minimum
> - predeined -> predefined
> - excute -> execute
> - availible -> available
> - discontiguous -> discontinuous
> - permenent -> permanent
> - immediatly -> immediately
> - environmemt -> environment
> - Seperator -> Separator
> - remmeber -> remember
> - initailized -> initialized
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Gary Lin <glin@suse.com>
> ---
> EmulatorPkg/FirmwareVolumePei/FirmwareVolumePei.c | 2 +-
> EmulatorPkg/Include/Ppi/EmuThunk.h | 2 +-
> EmulatorPkg/Library/EmuBdsLib/BdsPlatform.c | 8 +++----
> EmulatorPkg/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 4 ++--
> EmulatorPkg/Sec/Ia32/TempRam.c | 8 +++----
> EmulatorPkg/Unix/Host/Host.c | 24 ++++++++++----------
> EmulatorPkg/Unix/Host/Host.h | 4 ++--
> 7 files changed, 26 insertions(+), 26 deletions(-)
>
> diff --git a/EmulatorPkg/FirmwareVolumePei/FirmwareVolumePei.c b/EmulatorPkg/FirmwareVolumePei/FirmwareVolumePei.c
> index 91d1197..a7f548b 100644
> --- a/EmulatorPkg/FirmwareVolumePei/FirmwareVolumePei.c
> +++ b/EmulatorPkg/FirmwareVolumePei/FirmwareVolumePei.c
> @@ -33,7 +33,7 @@ Routine Description:
> Perform a call-back into the SEC simulator to get address of the Firmware Hub
>
> Arguments:
> - FfsHeader - Ffs Header availible to every PEIM
> + FfsHeader - Ffs Header available to every PEIM
> PeiServices - General purpose services available to every PEIM.
>
> Returns:
> diff --git a/EmulatorPkg/Include/Ppi/EmuThunk.h b/EmulatorPkg/Include/Ppi/EmuThunk.h
> index 7788d7b..61e90bf 100644
> --- a/EmulatorPkg/Include/Ppi/EmuThunk.h
> +++ b/EmulatorPkg/Include/Ppi/EmuThunk.h
> @@ -25,7 +25,7 @@
>
> Routine Description:
> This service is called from Index == 0 until it returns EFI_UNSUPPORTED.
> - It allows discontiguous memory regions to be supported by the emulator.
> + It allows discontinuous memory regions to be supported by the emulator.
>
> Arguments:
> Index - Which memory region to use
> diff --git a/EmulatorPkg/Library/EmuBdsLib/BdsPlatform.c b/EmulatorPkg/Library/EmuBdsLib/BdsPlatform.c
> index 46d2a7e..3580d36 100644
> --- a/EmulatorPkg/Library/EmuBdsLib/BdsPlatform.c
> +++ b/EmulatorPkg/Library/EmuBdsLib/BdsPlatform.c
> @@ -92,7 +92,7 @@ Routine Description:
>
> Arguments:
>
> - PlatformConsole - Predfined platform default console device array.
> + PlatformConsole - Predefined platform default console device array.
>
> Returns:
>
> @@ -113,7 +113,7 @@ Returns:
>
> //
> // Have chance to connect the platform default console,
> - // the platform default console is the minimue device group
> + // the platform default console is the minimum device group
> // the platform should support
> //
> while (PlatformConsole[Index].DevicePath != NULL) {
> @@ -149,7 +149,7 @@ PlatformBdsConnectSequence (
>
> Routine Description:
>
> - Connect with predeined platform connect sequence,
> + Connect with predefined platform connect sequence,
> the OEM/IBV can customize with their own connect sequence.
>
> Arguments:
> @@ -288,7 +288,7 @@ PlatformBdsPolicyBehavior (
>
> Routine Description:
>
> - The function will excute with as the platform policy, current policy
> + The function will execute with as the platform policy, current policy
> is driven by boot mode. IBV/OEM can customize this code for their specific
> policy action.
>
> diff --git a/EmulatorPkg/PlatformSmbiosDxe/PlatformSmbiosDxe.c b/EmulatorPkg/PlatformSmbiosDxe/PlatformSmbiosDxe.c
> index 2c75f85..a7ea3a4 100644
> --- a/EmulatorPkg/PlatformSmbiosDxe/PlatformSmbiosDxe.c
> +++ b/EmulatorPkg/PlatformSmbiosDxe/PlatformSmbiosDxe.c
> @@ -126,11 +126,11 @@ PlatfomrSmbiosDriverEntryPoint (
> // Phase 3 - Create tables from scratch
>
> // Create Type 13 record from EFI Variables
> - // Do we need this record for EFI as the info is availible from EFI varaibles
> + // Do we need this record for EFI as the info is available from EFI varaibles
> // Also language types don't always match between EFI and SMBIOS
> // CreateSmbiosLanguageInformation (1, gSmbiosLangToEfiLang);
>
> CreatePlatformSmbiosMemoryRecords ();
>
> return EFI_SUCCESS;
> -}
> \ No newline at end of file
> +}
> diff --git a/EmulatorPkg/Sec/Ia32/TempRam.c b/EmulatorPkg/Sec/Ia32/TempRam.c
> index 525fb95..931e066 100644
> --- a/EmulatorPkg/Sec/Ia32/TempRam.c
> +++ b/EmulatorPkg/Sec/Ia32/TempRam.c
> @@ -36,7 +36,7 @@ SecTemporaryRamSupport (
> )
> {
> //
> - // Migrate the whole temporary memory to permenent memory.
> + // Migrate the whole temporary memory to permanent memory.
> //
> CopyMem (
> (VOID*)(UINTN)PermanentMemoryBase,
> @@ -46,14 +46,14 @@ SecTemporaryRamSupport (
>
> //
> // SecSwitchStack function must be invoked after the memory migration
> - // immediatly, also we need fixup the stack change caused by new call into
> - // permenent memory.
> + // immediately, also we need fixup the stack change caused by new call into
> + // permanent memory.
> //
> SecSwitchStack ((UINT32) TemporaryMemoryBase, (UINT32) PermanentMemoryBase);
>
> //
> // We need *not* fix the return address because currently,
> - // The PeiCore is excuted in flash.
> + // The PeiCore is executed in flash.
> //
>
> //
> diff --git a/EmulatorPkg/Unix/Host/Host.c b/EmulatorPkg/Unix/Host/Host.c
> index 977fe87..f84b22f 100644
> --- a/EmulatorPkg/Unix/Host/Host.c
> +++ b/EmulatorPkg/Unix/Host/Host.c
> @@ -87,7 +87,7 @@ Routine Description:
> Arguments:
> Argc - Number of command line arguments
> Argv - Array of command line argument strings
> - Envp - Array of environmemt variable strings
> + Envp - Array of environment variable strings
>
> Returns:
> 0 - Normal exit
> @@ -175,7 +175,7 @@ main (
> //
> // Allocate space for gSystemMemory Array
> //
> - gSystemMemoryCount = CountSeperatorsInString (MemorySizeStr, '!') + 1;
> + gSystemMemoryCount = CountSeparatorsInString (MemorySizeStr, '!') + 1;
> gSystemMemory = AllocateZeroPool (gSystemMemoryCount * sizeof (EMU_SYSTEM_MEMORY));
> if (gSystemMemory == NULL) {
> printf ("ERROR : Can not allocate memory for system. Exiting.\n");
> @@ -184,7 +184,7 @@ main (
> //
> // Allocate space for gSystemMemory Array
> //
> - gFdInfoCount = CountSeperatorsInString (FirmwareVolumesStr, '!') + 1;
> + gFdInfoCount = CountSeparatorsInString (FirmwareVolumesStr, '!') + 1;
> gFdInfo = AllocateZeroPool (gFdInfoCount * sizeof (EMU_FD_INFO));
> if (gFdInfo == NULL) {
> printf ("ERROR : Can not allocate memory for fd info. Exiting.\n");
> @@ -249,7 +249,7 @@ main (
> );
> } else {
> //
> - // Open the FD and remmeber where it got mapped into our processes address space
> + // Open the FD and remember where it got mapped into our processes address space
> // Maps Read Only
> //
> Status = MapFile (
> @@ -614,7 +614,7 @@ SecLoadFromCore (
>
> Routine Description:
> This service is called from Index == 0 until it returns EFI_UNSUPPORTED.
> - It allows discontiguous memory regions to be supported by the emulator.
> + It allows discontinuous memory regions to be supported by the emulator.
> It uses gSystemMemory[] and gSystemMemoryCount that were created by
> parsing the host environment variable EFI_MEMORY_SIZE.
> The size comes from the varaible and the address comes from the call to
> @@ -703,7 +703,7 @@ EfiSystemMemoryRange (
>
> Routine Description:
> Since the SEC is the only Unix program in stack it must export
> - an interface to do POSIX calls. gUnix is initailized in UnixThunk.c.
> + an interface to do POSIX calls. gUnix is initialized in UnixThunk.c.
>
> Arguments:
> InterfaceSize - sizeof (EFI_WIN_NT_THUNK_PROTOCOL);
> @@ -830,26 +830,26 @@ SecUnixFdAddress (
> /*++
>
> Routine Description:
> - Count the number of seperators in String
> + Count the number of separators in String
>
> Arguments:
> String - String to process
> - Seperator - Item to count
> + Separator - Item to count
>
> Returns:
> - Number of Seperator in String
> + Number of Separator in String
>
> **/
> UINTN
> -CountSeperatorsInString (
> +CountSeparatorsInString (
> IN const CHAR16 *String,
> - IN CHAR16 Seperator
> + IN CHAR16 Separator
> )
> {
> UINTN Count;
>
> for (Count = 0; *String != '\0'; String++) {
> - if (*String == Seperator) {
> + if (*String == Separator) {
> Count++;
> }
> }
> diff --git a/EmulatorPkg/Unix/Host/Host.h b/EmulatorPkg/Unix/Host/Host.h
> index aff7c36..9d6d36e 100644
> --- a/EmulatorPkg/Unix/Host/Host.h
> +++ b/EmulatorPkg/Unix/Host/Host.h
> @@ -255,9 +255,9 @@ AsciiToUnicode (
> );
>
> UINTN
> -CountSeperatorsInString (
> +CountSeparatorsInString (
> IN const CHAR16 *String,
> - IN CHAR16 Seperator
> + IN CHAR16 Separator
> );
>
> EFI_STATUS
> --
> 2.10.1
>
next prev parent reply other threads:[~2016-10-19 20:37 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 7:01 [PATCH 00/33] Fix typos in comments and variables Gary Lin
2016-10-19 7:01 ` [PATCH 01/33] ArmPkg: Fix typos in comments Gary Lin
2016-10-19 15:09 ` Ard Biesheuvel
2016-10-19 15:15 ` Laszlo Ersek
2016-10-19 15:33 ` Leif Lindholm
2016-10-19 7:01 ` [PATCH 02/33] BaseTools: Fix typos in comments and variables Gary Lin
2016-10-19 7:30 ` Gao, Liming
2016-10-19 7:36 ` Zhu, Yonghong
2016-10-19 7:01 ` [PATCH 03/33] CorebootPayloadPkg: Fix typos in comments Gary Lin
2016-10-26 18:50 ` Ma, Maurice
2016-10-19 7:01 ` [PATCH 04/33] CorebootModulePkg: " Gary Lin
2016-10-26 18:41 ` Ma, Maurice
2016-10-19 7:01 ` [PATCH 05/33] CryptoPkg: " Gary Lin
2016-10-26 3:00 ` Long, Qin
2016-10-19 7:01 ` [PATCH 06/33] DuetPkg: " Gary Lin
2016-10-19 7:46 ` Ni, Ruiyu
2016-10-19 7:01 ` [PATCH 07/33] EdkCompatibilityPkg: " Gary Lin
2016-10-19 8:19 ` Gao, Liming
2016-10-19 7:01 ` [PATCH 08/33] EmulatorPkg: Fix typos in comments and variables Gary Lin
2016-10-19 20:37 ` Jordan Justen [this message]
2016-10-20 8:16 ` Laszlo Ersek
2016-10-19 7:01 ` [PATCH 09/33] EmbeddedPkg: Fix typos in comments Gary Lin
2016-10-19 15:09 ` Ard Biesheuvel
2016-10-19 7:01 ` [PATCH 10/33] IntelFrameworkModulePkg: " Gary Lin
2016-10-20 1:08 ` Fan, Jeff
2016-10-19 7:01 ` [PATCH 11/33] IntelFrameworkPkg: " Gary Lin
2016-10-20 1:08 ` Fan, Jeff
2016-10-19 7:01 ` [PATCH 12/33] IntelFspPkg: " Gary Lin
2016-10-19 7:06 ` Yao, Jiewen
2016-10-19 7:01 ` [PATCH 13/33] IntelFspWrapperPkg: " Gary Lin
2016-10-19 7:08 ` Yao, Jiewen
2016-10-19 7:01 ` [PATCH 14/33] IntelFsp2Pkg: " Gary Lin
2016-10-19 7:06 ` Yao, Jiewen
2016-10-19 7:12 ` Mudusuru, Giri P
2016-10-19 7:01 ` [PATCH 15/33] IntelFsp2WrapperPkg: Fix a typo in the comment Gary Lin
2016-10-19 7:07 ` Yao, Jiewen
2016-10-19 7:11 ` Mudusuru, Giri P
2016-10-19 7:01 ` [PATCH 16/33] MdeModulePkg: BootManagerMenuApp: Fix typos in comments Gary Lin
2016-10-19 8:20 ` Tian, Feng
2016-10-19 7:01 ` [PATCH 17/33] MdeModulePkg/Bus: " Gary Lin
2016-10-19 7:01 ` [PATCH 18/33] MdeModulePkg/Core: " Gary Lin
2016-10-19 8:20 ` Tian, Feng
2016-10-19 7:01 ` [PATCH 19/33] MdeModulePkg/Include: " Gary Lin
2016-10-19 7:01 ` [PATCH 20/33] MdeModulePkg/Library: Fix typos in comments and variables Gary Lin
2016-10-19 7:01 ` [PATCH 21/33] MdeModulePkg/Universal: Fix typos in comments Gary Lin
2016-10-19 7:01 ` [PATCH 22/33] MdePkg: " Gary Lin
2016-10-19 8:21 ` Gao, Liming
2016-10-19 7:01 ` [PATCH 23/33] NetworkPkg: " Gary Lin
2016-10-19 7:21 ` Fu, Siyuan
2016-10-26 0:53 ` Fu, Siyuan
2016-10-19 7:01 ` [PATCH 24/33] Nt32Pkg: Fix typos in comments and variables Gary Lin
2016-10-19 7:50 ` Ni, Ruiyu
2016-10-19 7:01 ` [PATCH 25/33] OptionRomPkg: Fix typos in comments Gary Lin
2016-10-19 7:51 ` Ni, Ruiyu
2016-10-19 7:01 ` [PATCH 26/33] OvmfPkg: " Gary Lin
2016-10-19 7:01 ` [PATCH 27/33] QuarkPlatformPkg: " Gary Lin
2016-10-25 20:53 ` Kinney, Michael D
2016-10-19 7:01 ` [PATCH 28/33] QuarkSocPkg: " Gary Lin
2016-10-25 21:00 ` Kinney, Michael D
2016-10-19 7:01 ` [PATCH 29/33] SecurityPkg: " Gary Lin
2016-10-27 1:29 ` Zhang, Chao B
2016-11-14 3:12 ` Zhang, Chao B
2016-11-14 4:03 ` Gary Lin
2016-11-14 6:24 ` Gao, Liming
2016-11-14 8:30 ` Gary Lin
2016-10-19 7:01 ` [PATCH 30/33] ShellPkg: Fix typos in comments and variables Gary Lin
2016-10-19 7:51 ` Ni, Ruiyu
2016-10-19 20:29 ` Carsey, Jaben
2016-10-20 1:55 ` Gary Lin
2016-10-19 7:01 ` [PATCH 31/33] SourceLevelDebugPkg: Fix typos in comments Gary Lin
2016-10-19 7:46 ` Wu, Hao A
2016-10-19 7:01 ` [PATCH 32/33] UefiCpuPkg: " Gary Lin
2016-10-20 1:58 ` Fan, Jeff
2016-10-20 2:08 ` Gary Lin
2016-10-20 2:45 ` Fan, Jeff
2016-10-19 7:01 ` [PATCH 33/33] Vlv2TbltDevicePkg: " Gary Lin
2016-10-24 1:33 ` Wei, David
2016-10-19 7:28 ` [PATCH 00/33] Fix typos in comments and variables Zeng, Star
2016-10-19 14:50 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=147690946737.18651.17915111261589019699@jljusten-ivb \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox