From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C2DC51A1E56 for ; Wed, 19 Oct 2016 13:37:58 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 19 Oct 2016 13:37:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,367,1473145200"; d="scan'208";a="1056277366" Received: from jessica1-mobl.amr.corp.intel.com (HELO localhost) ([10.252.136.91]) by fmsmga001.fm.intel.com with ESMTP; 19 Oct 2016 13:37:48 -0700 MIME-Version: 1.0 To: Gary Lin , edk2-devel@lists.01.org Message-ID: <147690946737.18651.17915111261589019699@jljusten-ivb> From: Jordan Justen In-Reply-To: <20161019070138.16424-9-glin@suse.com> Cc: "Andrew Fish" , Laszlo Ersek , References: <20161019070138.16424-1-glin@suse.com> <20161019070138.16424-9-glin@suse.com> User-Agent: alot/0.3.7 Date: Wed, 19 Oct 2016 13:37:47 -0700 Subject: Re: [PATCH 08/33] EmulatorPkg: Fix typos in comments and variables X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2016 20:37:59 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jordan Justen Pushed EmulatorPkg and OvmfPkg patches. On 2016-10-19 00:01:13, Gary Lin wrote: > - Predfined -> Predefined > - minimue -> minimum > - predeined -> predefined > - excute -> execute > - availible -> available > - discontiguous -> discontinuous > - permenent -> permanent > - immediatly -> immediately > - environmemt -> environment > - Seperator -> Separator > - remmeber -> remember > - initailized -> initialized > = > Cc: Jordan Justen > Cc: Andrew Fish > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Gary Lin > --- > EmulatorPkg/FirmwareVolumePei/FirmwareVolumePei.c | 2 +- > EmulatorPkg/Include/Ppi/EmuThunk.h | 2 +- > EmulatorPkg/Library/EmuBdsLib/BdsPlatform.c | 8 +++---- > EmulatorPkg/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 4 ++-- > EmulatorPkg/Sec/Ia32/TempRam.c | 8 +++---- > EmulatorPkg/Unix/Host/Host.c | 24 ++++++++++-------= --- > EmulatorPkg/Unix/Host/Host.h | 4 ++-- > 7 files changed, 26 insertions(+), 26 deletions(-) > = > diff --git a/EmulatorPkg/FirmwareVolumePei/FirmwareVolumePei.c b/Emulator= Pkg/FirmwareVolumePei/FirmwareVolumePei.c > index 91d1197..a7f548b 100644 > --- a/EmulatorPkg/FirmwareVolumePei/FirmwareVolumePei.c > +++ b/EmulatorPkg/FirmwareVolumePei/FirmwareVolumePei.c > @@ -33,7 +33,7 @@ Routine Description: > Perform a call-back into the SEC simulator to get address of the Firmw= are Hub > = > Arguments: > - FfsHeader - Ffs Header availible to every PEIM > + FfsHeader - Ffs Header available to every PEIM > PeiServices - General purpose services available to every PEIM. > = > Returns: > diff --git a/EmulatorPkg/Include/Ppi/EmuThunk.h b/EmulatorPkg/Include/Ppi= /EmuThunk.h > index 7788d7b..61e90bf 100644 > --- a/EmulatorPkg/Include/Ppi/EmuThunk.h > +++ b/EmulatorPkg/Include/Ppi/EmuThunk.h > @@ -25,7 +25,7 @@ > = > Routine Description: > This service is called from Index =3D=3D 0 until it returns EFI_UNSUPP= ORTED. > - It allows discontiguous memory regions to be supported by the emulator. > + It allows discontinuous memory regions to be supported by the emulator. > = > Arguments: > Index - Which memory region to use > diff --git a/EmulatorPkg/Library/EmuBdsLib/BdsPlatform.c b/EmulatorPkg/Li= brary/EmuBdsLib/BdsPlatform.c > index 46d2a7e..3580d36 100644 > --- a/EmulatorPkg/Library/EmuBdsLib/BdsPlatform.c > +++ b/EmulatorPkg/Library/EmuBdsLib/BdsPlatform.c > @@ -92,7 +92,7 @@ Routine Description: > = > Arguments: > = > - PlatformConsole - Predfined platform default console device ar= ray. > + PlatformConsole - Predefined platform default console device a= rray. > = > Returns: > = > @@ -113,7 +113,7 @@ Returns: > = > // > // Have chance to connect the platform default console, > - // the platform default console is the minimue device group > + // the platform default console is the minimum device group > // the platform should support > // > while (PlatformConsole[Index].DevicePath !=3D NULL) { > @@ -149,7 +149,7 @@ PlatformBdsConnectSequence ( > = > Routine Description: > = > - Connect with predeined platform connect sequence, > + Connect with predefined platform connect sequence, > the OEM/IBV can customize with their own connect sequence. > = > Arguments: > @@ -288,7 +288,7 @@ PlatformBdsPolicyBehavior ( > = > Routine Description: > = > - The function will excute with as the platform policy, current policy > + The function will execute with as the platform policy, current policy > is driven by boot mode. IBV/OEM can customize this code for their spec= ific > policy action. > = > diff --git a/EmulatorPkg/PlatformSmbiosDxe/PlatformSmbiosDxe.c b/Emulator= Pkg/PlatformSmbiosDxe/PlatformSmbiosDxe.c > index 2c75f85..a7ea3a4 100644 > --- a/EmulatorPkg/PlatformSmbiosDxe/PlatformSmbiosDxe.c > +++ b/EmulatorPkg/PlatformSmbiosDxe/PlatformSmbiosDxe.c > @@ -126,11 +126,11 @@ PlatfomrSmbiosDriverEntryPoint ( > // Phase 3 - Create tables from scratch = > = > // Create Type 13 record from EFI Variables > - // Do we need this record for EFI as the info is availible from EFI va= raibles > + // Do we need this record for EFI as the info is available from EFI va= raibles > // Also language types don't always match between EFI and SMBIOS > // CreateSmbiosLanguageInformation (1, gSmbiosLangToEfiLang); > = > CreatePlatformSmbiosMemoryRecords (); > = > return EFI_SUCCESS; > -} > \ No newline at end of file > +} > diff --git a/EmulatorPkg/Sec/Ia32/TempRam.c b/EmulatorPkg/Sec/Ia32/TempRa= m.c > index 525fb95..931e066 100644 > --- a/EmulatorPkg/Sec/Ia32/TempRam.c > +++ b/EmulatorPkg/Sec/Ia32/TempRam.c > @@ -36,7 +36,7 @@ SecTemporaryRamSupport ( > ) > { > // > - // Migrate the whole temporary memory to permenent memory. > + // Migrate the whole temporary memory to permanent memory. > // > CopyMem ( > (VOID*)(UINTN)PermanentMemoryBase, > @@ -46,14 +46,14 @@ SecTemporaryRamSupport ( > = > // > // SecSwitchStack function must be invoked after the memory migration > - // immediatly, also we need fixup the stack change caused by new call = into > - // permenent memory. > + // immediately, also we need fixup the stack change caused by new call= into > + // permanent memory. > // > SecSwitchStack ((UINT32) TemporaryMemoryBase, (UINT32) PermanentMemory= Base); > = > // > // We need *not* fix the return address because currently, > - // The PeiCore is excuted in flash. > + // The PeiCore is executed in flash. > // > = > // > diff --git a/EmulatorPkg/Unix/Host/Host.c b/EmulatorPkg/Unix/Host/Host.c > index 977fe87..f84b22f 100644 > --- a/EmulatorPkg/Unix/Host/Host.c > +++ b/EmulatorPkg/Unix/Host/Host.c > @@ -87,7 +87,7 @@ Routine Description: > Arguments: > Argc - Number of command line arguments > Argv - Array of command line argument strings > - Envp - Array of environmemt variable strings > + Envp - Array of environment variable strings > = > Returns: > 0 - Normal exit > @@ -175,7 +175,7 @@ main ( > // > // Allocate space for gSystemMemory Array > // > - gSystemMemoryCount =3D CountSeperatorsInString (MemorySizeStr, '!') += 1; > + gSystemMemoryCount =3D CountSeparatorsInString (MemorySizeStr, '!') += 1; > gSystemMemory =3D AllocateZeroPool (gSystemMemoryCount * sizeof = (EMU_SYSTEM_MEMORY)); > if (gSystemMemory =3D=3D NULL) { > printf ("ERROR : Can not allocate memory for system. Exiting.\n"); > @@ -184,7 +184,7 @@ main ( > // > // Allocate space for gSystemMemory Array > // > - gFdInfoCount =3D CountSeperatorsInString (FirmwareVolumesStr, '!') + = 1; > + gFdInfoCount =3D CountSeparatorsInString (FirmwareVolumesStr, '!') + = 1; > gFdInfo =3D AllocateZeroPool (gFdInfoCount * sizeof (EMU_FD_INFO= )); > if (gFdInfo =3D=3D NULL) { > printf ("ERROR : Can not allocate memory for fd info. Exiting.\n"); > @@ -249,7 +249,7 @@ main ( > ); > } else { > // > - // Open the FD and remmeber where it got mapped into our processes= address space > + // Open the FD and remember where it got mapped into our processes= address space > // Maps Read Only > // > Status =3D MapFile ( > @@ -614,7 +614,7 @@ SecLoadFromCore ( > = > Routine Description: > This service is called from Index =3D=3D 0 until it returns EFI_UNSUPP= ORTED. > - It allows discontiguous memory regions to be supported by the emulator. > + It allows discontinuous memory regions to be supported by the emulator. > It uses gSystemMemory[] and gSystemMemoryCount that were created by > parsing the host environment variable EFI_MEMORY_SIZE. > The size comes from the varaible and the address comes from the call to > @@ -703,7 +703,7 @@ EfiSystemMemoryRange ( > = > Routine Description: > Since the SEC is the only Unix program in stack it must export > - an interface to do POSIX calls. gUnix is initailized in UnixThunk.c. > + an interface to do POSIX calls. gUnix is initialized in UnixThunk.c. > = > Arguments: > InterfaceSize - sizeof (EFI_WIN_NT_THUNK_PROTOCOL); > @@ -830,26 +830,26 @@ SecUnixFdAddress ( > /*++ > = > Routine Description: > - Count the number of seperators in String > + Count the number of separators in String > = > Arguments: > String - String to process > - Seperator - Item to count > + Separator - Item to count > = > Returns: > - Number of Seperator in String > + Number of Separator in String > = > **/ > UINTN > -CountSeperatorsInString ( > +CountSeparatorsInString ( > IN const CHAR16 *String, > - IN CHAR16 Seperator > + IN CHAR16 Separator > ) > { > UINTN Count; > = > for (Count =3D 0; *String !=3D '\0'; String++) { > - if (*String =3D=3D Seperator) { > + if (*String =3D=3D Separator) { > Count++; > } > } > diff --git a/EmulatorPkg/Unix/Host/Host.h b/EmulatorPkg/Unix/Host/Host.h > index aff7c36..9d6d36e 100644 > --- a/EmulatorPkg/Unix/Host/Host.h > +++ b/EmulatorPkg/Unix/Host/Host.h > @@ -255,9 +255,9 @@ AsciiToUnicode ( > ); > = > UINTN > -CountSeperatorsInString ( > +CountSeparatorsInString ( > IN const CHAR16 *String, > - IN CHAR16 Seperator > + IN CHAR16 Separator > ); > = > EFI_STATUS > -- = > 2.10.1 >=20