public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch] NetworkPkg: Coding style refine for IpSecDxe
@ 2016-10-20  1:49 Jiaxin Wu
  2016-10-20  8:09 ` Bi, Dandan
  0 siblings, 1 reply; 2+ messages in thread
From: Jiaxin Wu @ 2016-10-20  1:49 UTC (permalink / raw)
  To: edk2-devel; +Cc: Bi Dandan, Fu Siyuan

Cc: Bi Dandan <dandan.bi@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
---
 NetworkPkg/IpSecDxe/IkeCommon.c | 10 +++++-----
 NetworkPkg/IpSecDxe/IkeCommon.h | 10 +++++-----
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/NetworkPkg/IpSecDxe/IkeCommon.c b/NetworkPkg/IpSecDxe/IkeCommon.c
index b1e4321..c5fbfab 100644
--- a/NetworkPkg/IpSecDxe/IkeCommon.c
+++ b/NetworkPkg/IpSecDxe/IkeCommon.c
@@ -199,22 +199,22 @@ IkePayloadFree (
 }
 
 /**
   Generate an new SPI.
   
-  @param[in]      IkeSaSession   Pointer to IKEV2_SA_SESSION related to this Child SA 
-                                 Session.
-  @param[in out]  SpiValue       Pointer to the new generated SPI value. 
+  @param[in]       IkeSaSession   Pointer to IKEV2_SA_SESSION related to this Child SA 
+                                  Session.
+  @param[in, out]  SpiValue       Pointer to the new generated SPI value. 
                               
   @retval EFI_SUCCESS         The operation performs successfully.
   @retval Otherwise           The operation is failed.
 
 **/
 EFI_STATUS
 IkeGenerateSpi (
-  IN  IKEV2_SA_SESSION         *IkeSaSession,
-  OUT UINT32                   *SpiValue
+  IN     IKEV2_SA_SESSION         *IkeSaSession,
+  IN OUT UINT32                   *SpiValue
   )
 {
   EFI_STATUS   Status;
 
   Status = EFI_SUCCESS;
diff --git a/NetworkPkg/IpSecDxe/IkeCommon.h b/NetworkPkg/IpSecDxe/IkeCommon.h
index 7f7fd4d..eb7e913 100644
--- a/NetworkPkg/IpSecDxe/IkeCommon.h
+++ b/NetworkPkg/IpSecDxe/IkeCommon.h
@@ -130,22 +130,22 @@ IkePayloadFree (
   );
 
 /**
   Generate an new SPI.
   
-  @param[in]      IkeSaSession   Pointer to IKEV2_SA_SESSION related to this Child SA 
-                                 Session.
-  @param[in out]  SpiValue       Pointer to the new generated SPI value. 
+  @param[in]       IkeSaSession   Pointer to IKEV2_SA_SESSION related to this Child SA 
+                                  Session.
+  @param[in, out]  SpiValue       Pointer to the new generated SPI value. 
                               
   @retval EFI_SUCCESS         The operation performs successfully.
   @retval Otherwise           The operation is failed.
 
 **/
 EFI_STATUS
 IkeGenerateSpi (
-  IN  IKEV2_SA_SESSION         *IkeSaSession,
-  OUT UINT32                   *SpiValue
+  IN     IKEV2_SA_SESSION         *IkeSaSession,
+  IN OUT UINT32                   *SpiValue
   );
 
 /**
   Generate a random data for IV
 
-- 
1.9.5.msysgit.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Patch] NetworkPkg: Coding style refine for IpSecDxe
  2016-10-20  1:49 [Patch] NetworkPkg: Coding style refine for IpSecDxe Jiaxin Wu
@ 2016-10-20  8:09 ` Bi, Dandan
  0 siblings, 0 replies; 2+ messages in thread
From: Bi, Dandan @ 2016-10-20  8:09 UTC (permalink / raw)
  To: Wu, Jiaxin, edk2-devel@lists.01.org; +Cc: Fu, Siyuan

Reviewed-by: Dandan Bi <dandan.bi@intel.com>

Thanks,
Dandan

-----Original Message-----
From: Wu, Jiaxin 
Sent: Thursday, October 20, 2016 9:50 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan.bi@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>
Subject: [Patch] NetworkPkg: Coding style refine for IpSecDxe

Cc: Bi Dandan <dandan.bi@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
---
 NetworkPkg/IpSecDxe/IkeCommon.c | 10 +++++-----  NetworkPkg/IpSecDxe/IkeCommon.h | 10 +++++-----
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/NetworkPkg/IpSecDxe/IkeCommon.c b/NetworkPkg/IpSecDxe/IkeCommon.c index b1e4321..c5fbfab 100644
--- a/NetworkPkg/IpSecDxe/IkeCommon.c
+++ b/NetworkPkg/IpSecDxe/IkeCommon.c
@@ -199,22 +199,22 @@ IkePayloadFree (
 }
 
 /**
   Generate an new SPI.
   
-  @param[in]      IkeSaSession   Pointer to IKEV2_SA_SESSION related to this Child SA 
-                                 Session.
-  @param[in out]  SpiValue       Pointer to the new generated SPI value. 
+  @param[in]       IkeSaSession   Pointer to IKEV2_SA_SESSION related to this Child SA 
+                                  Session.
+  @param[in, out]  SpiValue       Pointer to the new generated SPI value. 
                               
   @retval EFI_SUCCESS         The operation performs successfully.
   @retval Otherwise           The operation is failed.
 
 **/
 EFI_STATUS
 IkeGenerateSpi (
-  IN  IKEV2_SA_SESSION         *IkeSaSession,
-  OUT UINT32                   *SpiValue
+  IN     IKEV2_SA_SESSION         *IkeSaSession,
+  IN OUT UINT32                   *SpiValue
   )
 {
   EFI_STATUS   Status;
 
   Status = EFI_SUCCESS;
diff --git a/NetworkPkg/IpSecDxe/IkeCommon.h b/NetworkPkg/IpSecDxe/IkeCommon.h index 7f7fd4d..eb7e913 100644
--- a/NetworkPkg/IpSecDxe/IkeCommon.h
+++ b/NetworkPkg/IpSecDxe/IkeCommon.h
@@ -130,22 +130,22 @@ IkePayloadFree (
   );
 
 /**
   Generate an new SPI.
   
-  @param[in]      IkeSaSession   Pointer to IKEV2_SA_SESSION related to this Child SA 
-                                 Session.
-  @param[in out]  SpiValue       Pointer to the new generated SPI value. 
+  @param[in]       IkeSaSession   Pointer to IKEV2_SA_SESSION related to this Child SA 
+                                  Session.
+  @param[in, out]  SpiValue       Pointer to the new generated SPI value. 
                               
   @retval EFI_SUCCESS         The operation performs successfully.
   @retval Otherwise           The operation is failed.
 
 **/
 EFI_STATUS
 IkeGenerateSpi (
-  IN  IKEV2_SA_SESSION         *IkeSaSession,
-  OUT UINT32                   *SpiValue
+  IN     IKEV2_SA_SESSION         *IkeSaSession,
+  IN OUT UINT32                   *SpiValue
   );
 
 /**
   Generate a random data for IV
 
--
1.9.5.msysgit.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-10-20  8:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-20  1:49 [Patch] NetworkPkg: Coding style refine for IpSecDxe Jiaxin Wu
2016-10-20  8:09 ` Bi, Dandan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox