public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch] MdePkg BaseMemoryLibOptDxe: Add function comment for InternalMemCompareGuid
@ 2016-10-20  5:59 Liming Gao
  2016-10-20  9:14 ` Ard Biesheuvel
  0 siblings, 1 reply; 2+ messages in thread
From: Liming Gao @ 2016-10-20  5:59 UTC (permalink / raw)
  To: edk2-devel; +Cc: Ard Biesheuvel

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
---
 MdePkg/Library/BaseMemoryLibOptDxe/Arm/MemLibGuid.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/MdePkg/Library/BaseMemoryLibOptDxe/Arm/MemLibGuid.c b/MdePkg/Library/BaseMemoryLibOptDxe/Arm/MemLibGuid.c
index 8f1e50b..47386e9 100644
--- a/MdePkg/Library/BaseMemoryLibOptDxe/Arm/MemLibGuid.c
+++ b/MdePkg/Library/BaseMemoryLibOptDxe/Arm/MemLibGuid.c
@@ -15,6 +15,19 @@
 
 #include "MemLibInternals.h"
 
+/**
+  Internal function to compare two GUIDs.
+
+  This function compares Guid1 to Guid2.  If the GUIDs are identical then TRUE is returned.
+  If there are any bit differences in the two GUIDs, then FALSE is returned.
+
+  @param  Guid1       A pointer to a 128 bit GUID.
+  @param  Guid2       A pointer to a 128 bit GUID.
+
+  @retval TRUE        Guid1 and Guid2 are identical.
+  @retval FALSE       Guid1 and Guid2 are not identical.
+
+**/
 BOOLEAN
 EFIAPI
 InternalMemCompareGuid (
-- 
2.8.0.windows.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Patch] MdePkg BaseMemoryLibOptDxe: Add function comment for InternalMemCompareGuid
  2016-10-20  5:59 [Patch] MdePkg BaseMemoryLibOptDxe: Add function comment for InternalMemCompareGuid Liming Gao
@ 2016-10-20  9:14 ` Ard Biesheuvel
  0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2016-10-20  9:14 UTC (permalink / raw)
  To: Liming Gao; +Cc: edk2-devel-01

On 20 October 2016 at 06:59, Liming Gao <liming.gao@intel.com> wrote:
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Liming Gao <liming.gao@intel.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  MdePkg/Library/BaseMemoryLibOptDxe/Arm/MemLibGuid.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/MdePkg/Library/BaseMemoryLibOptDxe/Arm/MemLibGuid.c b/MdePkg/Library/BaseMemoryLibOptDxe/Arm/MemLibGuid.c
> index 8f1e50b..47386e9 100644
> --- a/MdePkg/Library/BaseMemoryLibOptDxe/Arm/MemLibGuid.c
> +++ b/MdePkg/Library/BaseMemoryLibOptDxe/Arm/MemLibGuid.c
> @@ -15,6 +15,19 @@
>
>  #include "MemLibInternals.h"
>
> +/**
> +  Internal function to compare two GUIDs.
> +
> +  This function compares Guid1 to Guid2.  If the GUIDs are identical then TRUE is returned.
> +  If there are any bit differences in the two GUIDs, then FALSE is returned.
> +
> +  @param  Guid1       A pointer to a 128 bit GUID.
> +  @param  Guid2       A pointer to a 128 bit GUID.
> +
> +  @retval TRUE        Guid1 and Guid2 are identical.
> +  @retval FALSE       Guid1 and Guid2 are not identical.
> +
> +**/
>  BOOLEAN
>  EFIAPI
>  InternalMemCompareGuid (
> --
> 2.8.0.windows.1
>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-10-20  9:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-20  5:59 [Patch] MdePkg BaseMemoryLibOptDxe: Add function comment for InternalMemCompareGuid Liming Gao
2016-10-20  9:14 ` Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox