From: Jordan Justen <jordan.l.justen@intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
"edk2-devel-01" <edk2-devel@lists.01.org>
Cc: "Anthony PERARD" <anthony.perard@citrix.com>,
"Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
"Gary Lin" <glin@suse.com>,
"Leif Lindholm" <leif.lindholm@linaro.org>,
"Liming Gao" <liming.gao@intel.com>,
"Michael D Kinney" <michael.d.kinney@intel.com>,
"Michael Zimmermann" <sigmaepsilon92@gmail.com>
Subject: Re: [PATCH 00/19] OvmfPkg, ArmVirtPkg: leave deprecated interfaces behind
Date: Mon, 24 Oct 2016 11:48:49 -0700 [thread overview]
Message-ID: <147733492929.16732.5437018314542639857@jljusten-ivb> (raw)
In-Reply-To: <20161021212737.15974-1-lersek@redhat.com>
Series Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
On 2016-10-21 14:27:18, Laszlo Ersek wrote:
> This series intends to solve the following BZs:
>
> <https://bugzilla.tianocore.org/show_bug.cgi?id=166> -- OvmfPkg: Add
> the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC
> files
>
> <https://bugzilla.tianocore.org/show_bug.cgi?id=165> -- ArmVirtPkg:
> Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package
> DSC files
>
> Public branch:
> <https://github.com/lersek/edk2/commits/no_deprec_ovmf_bz166_armvirt_bz165>.
>
> The DISABLE_NEW_DEPRECATED_INTERFACES feature test macro disables the
> following MdePkg library class APIs:
>
> BaseLib:
> - StrCpy, StrnCpy, StrCat, StrnCat, UnicodeStrToAsciiStr,
> - AsciiStrCpy, AsciiStrnCpy, AsciiStrCat, AsciiStrnCat,
> AsciiStrToUnicodeStr.
>
> PcdLib:
> - PcdSet8, PcdSet16, PcdSet32, PcdSet64, PcdSetPtr, PcdSetBool,
> - PcdSetEx8, PcdSetEx16, PcdSetEx32, PcdSetEx64, PcdSetExPtr,
> PcdSetExBool.
>
> UefiLib:
> - GetVariable, GetEfiGlobalVariable.
>
> The series gradually weans the OvmfPkg and ArmVirtPkg modules off these.
> For the 32-bit ARM builds of ArmVirtPkg platforms, I had to dip my toes
> into ArmPkg a little bit, due to dependencies.
>
> I couldn't build-test some changes (for example, the only compiler
> toolchains I have access to at the moment are GCC48 for Ia32/X64, and
> GCC5 for ARM/AARCH64). Some changes I could build, but not functionally
> test (Xen en bloc, 32-bit ARM, RAM-emulated variables in OVMF, -bios
> flag). For all of these, I liberally sprinkled the patches with Cc's and
> Notes sections, asking for help. I did make an honest effort to build
> the ArmVirt and OVMF platforms in as many configurations (-D ...) as I
> could think of, perusing the various !if directives in the DSC files.
>
> I recommend the "--word-diff" option of git-show, as a tool to assist
> with the review.
>
> Cc: Anthony PERARD <anthony.perard@citrix.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Gary Lin <glin@suse.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Michael Zimmermann <sigmaepsilon92@gmail.com>
>
> Thanks
> Laszlo
>
> Laszlo Ersek (19):
> MdePkg/DebugLib.h: add ASSERT_RETURN_ERROR()
> OvmfPkg/XenBusDxe: eliminate AsciiStrCpy() calls
> OvmfPkg/XenBusDxe: eliminate AsciiStrCat() calls
> OvmfPkg/EmuVariableFvbRuntimeDxe: eliminate unchecked PcdSetXX() calls
> OvmfPkg/PlatformBootManagerLib: eliminate unchecked PcdSetXX() calls
> OvmfPkg/SmbiosVersionLib: eliminate unchecked PcdSetXX() calls
> OvmfPkg/PlatformDxe: eliminate unchecked PcdSetXX() calls
> OvmfPkg/PlatformPei: eliminate unchecked PcdSetXX() calls
> OvmfPkg/QemuFlashFvbServicesRuntimeDxe: eliminate unchecked PcdSetXX()
> calls
> OvmfPkg: disable deprecated interfaces
> ArmVirtPkg/ArmVirtGicArchLib: eliminate unchecked PcdSetXX() calls
> ArmVirtPkg/ArmVirtPL031FdtClientLib: eliminate unchecked PcdSetXX()
> calls
> ArmVirtPkg/ArmVirtPlatformLib: eliminate unchecked PcdSetXX() calls
> ArmVirtPkg/ArmVirtTimerFdtClientLib: eliminate unchecked PcdSetXX()
> calls
> ArmVirtPkg/FdtPciPcdProducerLib: eliminate unchecked PcdSetXX() calls
> ArmVirtPkg/PlatformBootManagerLib: eliminate unchecked PcdSetXX()
> calls
> ArmPkg/ArmDisassemblerLib: replace AsciiStrCat() with AsciiStrCatS()
> ArmPkg/DefaultExceptionHandlerLib: replace AsciiStrCat() with
> AsciiStrCatS()
> ArmVirtPkg: disable deprecated interfaces
>
> ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c | 22 +++++-----
> ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c | 20 ++++-----
> ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c | 5 ++-
> ArmVirtPkg/ArmVirt.dsc.inc | 6 +++
> ArmVirtPkg/Library/ArmVirtGicArchLib/ArmVirtGicArchLib.c | 13 ++++--
> ArmVirtPkg/Library/ArmVirtPL031FdtClientLib/ArmVirtPL031FdtClientLib.c | 4 +-
> ArmVirtPkg/Library/ArmVirtPlatformLib/Virt.c | 18 ++++----
> ArmVirtPkg/Library/ArmVirtTimerFdtClientLib/ArmVirtTimerFdtClientLib.c | 13 ++++--
> ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.c | 10 +++--
> ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 6 ++-
> MdePkg/Include/Library/DebugLib.h | 27 ++++++++++++
> OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.c | 12 ++++--
> OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 14 +++++--
> OvmfPkg/Library/SmbiosVersionLib/DetectSmbiosVersionLib.c | 10 +++--
> OvmfPkg/OvmfPkgIa32.dsc | 7 ++++
> OvmfPkg/OvmfPkgIa32X64.dsc | 7 ++++
> OvmfPkg/OvmfPkgX64.dsc | 7 ++++
> OvmfPkg/PlatformDxe/Platform.c | 8 +++-
> OvmfPkg/PlatformPei/MemDetect.c | 11 +++--
> OvmfPkg/PlatformPei/Platform.c | 44 +++++++++++++-------
> OvmfPkg/PlatformPei/Xen.c | 5 ++-
> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c | 13 ++++--
> OvmfPkg/XenBusDxe/XenBusDxe.inf | 1 +
> OvmfPkg/XenBusDxe/XenStore.c | 22 +++++-----
> 24 files changed, 213 insertions(+), 92 deletions(-)
>
> --
> 2.9.2
>
next prev parent reply other threads:[~2016-10-24 18:49 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 21:27 [PATCH 00/19] OvmfPkg, ArmVirtPkg: leave deprecated interfaces behind Laszlo Ersek
2016-10-21 21:27 ` [PATCH 01/19] MdePkg/DebugLib.h: add ASSERT_RETURN_ERROR() Laszlo Ersek
2016-10-24 20:59 ` Laszlo Ersek
2016-10-24 23:05 ` Kinney, Michael D
2016-10-25 7:54 ` Laszlo Ersek
2016-10-25 10:32 ` Gao, Liming
2016-10-27 2:53 ` Kinney, Michael D
2016-10-25 8:22 ` Zeng, Star
2016-10-25 8:33 ` Laszlo Ersek
2016-10-21 21:27 ` [PATCH 02/19] OvmfPkg/XenBusDxe: eliminate AsciiStrCpy() calls Laszlo Ersek
2016-10-24 4:44 ` Gary Lin
2016-10-21 21:27 ` [PATCH 03/19] OvmfPkg/XenBusDxe: eliminate AsciiStrCat() calls Laszlo Ersek
2016-10-24 4:44 ` Gary Lin
2016-10-21 21:27 ` [PATCH 04/19] OvmfPkg/EmuVariableFvbRuntimeDxe: eliminate unchecked PcdSetXX() calls Laszlo Ersek
2016-10-24 4:45 ` Gary Lin
2016-10-21 21:27 ` [PATCH 05/19] OvmfPkg/PlatformBootManagerLib: " Laszlo Ersek
2016-10-24 4:45 ` Gary Lin
2016-10-21 21:27 ` [PATCH 06/19] OvmfPkg/SmbiosVersionLib: " Laszlo Ersek
2016-10-24 8:00 ` Ard Biesheuvel
2016-10-21 21:27 ` [PATCH 07/19] OvmfPkg/PlatformDxe: " Laszlo Ersek
2016-10-21 21:27 ` [PATCH 08/19] OvmfPkg/PlatformPei: " Laszlo Ersek
2016-10-24 4:45 ` Gary Lin
2016-10-24 11:51 ` Laszlo Ersek
2016-10-21 21:27 ` [PATCH 09/19] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: " Laszlo Ersek
2016-10-21 21:27 ` [PATCH 10/19] OvmfPkg: disable deprecated interfaces Laszlo Ersek
2016-10-21 21:27 ` [PATCH 11/19] ArmVirtPkg/ArmVirtGicArchLib: eliminate unchecked PcdSetXX() calls Laszlo Ersek
2016-10-24 8:00 ` Ard Biesheuvel
2016-10-21 21:27 ` [PATCH 12/19] ArmVirtPkg/ArmVirtPL031FdtClientLib: " Laszlo Ersek
2016-10-24 8:00 ` Ard Biesheuvel
2016-10-21 21:27 ` [PATCH 13/19] ArmVirtPkg/ArmVirtPlatformLib: " Laszlo Ersek
2016-10-24 7:59 ` Ard Biesheuvel
2016-10-21 21:27 ` [PATCH 14/19] ArmVirtPkg/ArmVirtTimerFdtClientLib: " Laszlo Ersek
2016-10-24 7:59 ` Ard Biesheuvel
2016-10-21 21:27 ` [PATCH 15/19] ArmVirtPkg/FdtPciPcdProducerLib: " Laszlo Ersek
2016-10-24 7:59 ` Ard Biesheuvel
2016-10-21 21:27 ` [PATCH 16/19] ArmVirtPkg/PlatformBootManagerLib: " Laszlo Ersek
2016-10-24 7:58 ` Ard Biesheuvel
2016-10-21 21:27 ` [PATCH 17/19] ArmPkg/ArmDisassemblerLib: replace AsciiStrCat() with AsciiStrCatS() Laszlo Ersek
2016-10-24 7:58 ` Ard Biesheuvel
2016-10-24 18:47 ` Jordan Justen
2016-10-24 19:54 ` Laszlo Ersek
2016-10-21 21:27 ` [PATCH 18/19] ArmPkg/DefaultExceptionHandlerLib: " Laszlo Ersek
2016-10-24 7:57 ` Ard Biesheuvel
2016-10-24 11:52 ` Laszlo Ersek
2016-10-21 21:27 ` [PATCH 19/19] ArmVirtPkg: disable deprecated interfaces Laszlo Ersek
2016-10-25 8:25 ` Laszlo Ersek
2016-10-25 8:28 ` Ard Biesheuvel
2016-10-24 8:04 ` [PATCH 00/19] OvmfPkg, ArmVirtPkg: leave deprecated interfaces behind Ard Biesheuvel
2016-10-24 11:50 ` Laszlo Ersek
2016-10-25 8:26 ` Laszlo Ersek
2016-10-25 8:45 ` Laszlo Ersek
2016-10-25 8:49 ` Ard Biesheuvel
2016-10-24 18:48 ` Jordan Justen [this message]
2016-10-25 9:07 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=147733492929.16732.5437018314542639857@jljusten-ivb \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox