From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AFD2A1A1E3A for ; Mon, 24 Oct 2016 11:49:09 -0700 (PDT) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP; 24 Oct 2016 11:48:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,542,1473145200"; d="scan'208";a="23177116" Received: from jlmcguir-mobl2.amr.corp.intel.com (HELO localhost) ([10.252.135.104]) by orsmga005.jf.intel.com with ESMTP; 24 Oct 2016 11:48:49 -0700 MIME-Version: 1.0 To: Laszlo Ersek , "edk2-devel-01" Message-ID: <147733492929.16732.5437018314542639857@jljusten-ivb> From: Jordan Justen In-Reply-To: <20161021212737.15974-1-lersek@redhat.com> Cc: "Anthony PERARD" , "Ard Biesheuvel" , "Gary Lin" , "Leif Lindholm" , "Liming Gao" , "Michael D Kinney" , "Michael Zimmermann" References: <20161021212737.15974-1-lersek@redhat.com> User-Agent: alot/0.3.7 Date: Mon, 24 Oct 2016 11:48:49 -0700 Subject: Re: [PATCH 00/19] OvmfPkg, ArmVirtPkg: leave deprecated interfaces behind X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Oct 2016 18:49:09 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Series Reviewed-by: Jordan Justen On 2016-10-21 14:27:18, Laszlo Ersek wrote: > This series intends to solve the following BZs: > = > -- OvmfPkg: Add > the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC > files > = > -- ArmVirtPkg: > Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package > DSC files > = > Public branch: > . > = > The DISABLE_NEW_DEPRECATED_INTERFACES feature test macro disables the > following MdePkg library class APIs: > = > BaseLib: > - StrCpy, StrnCpy, StrCat, StrnCat, UnicodeStrToAsciiStr, > - AsciiStrCpy, AsciiStrnCpy, AsciiStrCat, AsciiStrnCat, > AsciiStrToUnicodeStr. > = > PcdLib: > - PcdSet8, PcdSet16, PcdSet32, PcdSet64, PcdSetPtr, PcdSetBool, > - PcdSetEx8, PcdSetEx16, PcdSetEx32, PcdSetEx64, PcdSetExPtr, > PcdSetExBool. > = > UefiLib: > - GetVariable, GetEfiGlobalVariable. > = > The series gradually weans the OvmfPkg and ArmVirtPkg modules off these. > For the 32-bit ARM builds of ArmVirtPkg platforms, I had to dip my toes > into ArmPkg a little bit, due to dependencies. > = > I couldn't build-test some changes (for example, the only compiler > toolchains I have access to at the moment are GCC48 for Ia32/X64, and > GCC5 for ARM/AARCH64). Some changes I could build, but not functionally > test (Xen en bloc, 32-bit ARM, RAM-emulated variables in OVMF, -bios > flag). For all of these, I liberally sprinkled the patches with Cc's and > Notes sections, asking for help. I did make an honest effort to build > the ArmVirt and OVMF platforms in as many configurations (-D ...) as I > could think of, perusing the various !if directives in the DSC files. > = > I recommend the "--word-diff" option of git-show, as a tool to assist > with the review. > = > Cc: Anthony PERARD > Cc: Ard Biesheuvel > Cc: Gary Lin > Cc: Jordan Justen > Cc: Leif Lindholm > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Michael Zimmermann > = > Thanks > Laszlo > = > Laszlo Ersek (19): > MdePkg/DebugLib.h: add ASSERT_RETURN_ERROR() > OvmfPkg/XenBusDxe: eliminate AsciiStrCpy() calls > OvmfPkg/XenBusDxe: eliminate AsciiStrCat() calls > OvmfPkg/EmuVariableFvbRuntimeDxe: eliminate unchecked PcdSetXX() calls > OvmfPkg/PlatformBootManagerLib: eliminate unchecked PcdSetXX() calls > OvmfPkg/SmbiosVersionLib: eliminate unchecked PcdSetXX() calls > OvmfPkg/PlatformDxe: eliminate unchecked PcdSetXX() calls > OvmfPkg/PlatformPei: eliminate unchecked PcdSetXX() calls > OvmfPkg/QemuFlashFvbServicesRuntimeDxe: eliminate unchecked PcdSetXX() > calls > OvmfPkg: disable deprecated interfaces > ArmVirtPkg/ArmVirtGicArchLib: eliminate unchecked PcdSetXX() calls > ArmVirtPkg/ArmVirtPL031FdtClientLib: eliminate unchecked PcdSetXX() > calls > ArmVirtPkg/ArmVirtPlatformLib: eliminate unchecked PcdSetXX() calls > ArmVirtPkg/ArmVirtTimerFdtClientLib: eliminate unchecked PcdSetXX() > calls > ArmVirtPkg/FdtPciPcdProducerLib: eliminate unchecked PcdSetXX() calls > ArmVirtPkg/PlatformBootManagerLib: eliminate unchecked PcdSetXX() > calls > ArmPkg/ArmDisassemblerLib: replace AsciiStrCat() with AsciiStrCatS() > ArmPkg/DefaultExceptionHandlerLib: replace AsciiStrCat() with > AsciiStrCatS() > ArmVirtPkg: disable deprecated interfaces > = > ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c = | 22 +++++----- > ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c = | 20 ++++----- > ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c = | 5 ++- > ArmVirtPkg/ArmVirt.dsc.inc = | 6 +++ > ArmVirtPkg/Library/ArmVirtGicArchLib/ArmVirtGicArchLib.c = | 13 ++++-- > ArmVirtPkg/Library/ArmVirtPL031FdtClientLib/ArmVirtPL031FdtClientLib.c = | 4 +- > ArmVirtPkg/Library/ArmVirtPlatformLib/Virt.c = | 18 ++++---- > ArmVirtPkg/Library/ArmVirtTimerFdtClientLib/ArmVirtTimerFdtClientLib.c = | 13 ++++-- > ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.c = | 10 +++-- > ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c = | 6 ++- > MdePkg/Include/Library/DebugLib.h = | 27 ++++++++++++ > OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.c = | 12 ++++-- > OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c = | 14 +++++-- > OvmfPkg/Library/SmbiosVersionLib/DetectSmbiosVersionLib.c = | 10 +++-- > OvmfPkg/OvmfPkgIa32.dsc = | 7 ++++ > OvmfPkg/OvmfPkgIa32X64.dsc = | 7 ++++ > OvmfPkg/OvmfPkgX64.dsc = | 7 ++++ > OvmfPkg/PlatformDxe/Platform.c = | 8 +++- > OvmfPkg/PlatformPei/MemDetect.c = | 11 +++-- > OvmfPkg/PlatformPei/Platform.c = | 44 +++++++++++++------- > OvmfPkg/PlatformPei/Xen.c = | 5 ++- > OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c = | 13 ++++-- > OvmfPkg/XenBusDxe/XenBusDxe.inf = | 1 + > OvmfPkg/XenBusDxe/XenStore.c = | 22 +++++----- > 24 files changed, 213 insertions(+), 92 deletions(-) > = > -- = > 2.9.2 >=20