From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jordan.l.justen@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id C0FCB1A1E43
 for <edk2-devel@lists.01.org>; Tue, 25 Oct 2016 09:46:19 -0700 (PDT)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by orsmga101.jf.intel.com with ESMTP; 25 Oct 2016 09:46:20 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,546,1473145200"; d="scan'208";a="23868614"
Received: from jlmcguir-mobl2.amr.corp.intel.com (HELO localhost)
 ([10.252.135.104])
 by orsmga004.jf.intel.com with ESMTP; 25 Oct 2016 09:46:19 -0700
MIME-Version: 1.0
To: Laszlo Ersek <lersek@redhat.com>, "edk2-devel-01" <edk2-devel@lists.01.org>
Message-ID: <147741397897.26016.3788436900040258320@jljusten-ivb>
From: Jordan Justen <jordan.l.justen@intel.com>
In-Reply-To: <20161025143831.14482-1-lersek@redhat.com>
Cc: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
References: <20161025143831.14482-1-lersek@redhat.com>
User-Agent: alot/0.3.7
Date: Tue, 25 Oct 2016 09:46:18 -0700
Subject: Re: [PATCH] OvmfPkg/XenConsoleSerialPortLib: don't include <Uefi/UefiBaseType.h>
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Oct 2016 16:46:19 -0000
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

On 2016-10-25 07:38:31, Laszlo Ersek wrote:
> XenConsoleSerialPortLib is a BASE type library instance, without being
> restricted to UEFI client modules. (For example, the
> "ArmVirtPkg/ArmVirtXen.dsc" platform builds this library instance into
> "ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf", which is a SEC type
> module.) For such library instances, including <Uefi/UefiBaseType.h> is
> not right.
> =

> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c | 1 -
>  1 file changed, 1 deletion(-)
> =

> diff --git a/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPort=
Lib.c b/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c
> index 295696312413..4a63b860476d 100644
> --- a/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c
> +++ b/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c
> @@ -15,7 +15,6 @@
>  **/
>  =

>  #include <Base.h>
> -#include <Uefi/UefiBaseType.h>
>  =

>  #include <Library/BaseLib.h>
>  #include <Library/SerialPortLib.h>
> -- =

> 2.9.2
>=20