public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Michael Kinney <michael.d.kinney@intel.com>
To: edk2-devel@lists.01.org
Subject: [Patch] QuarkSocPkg/Library: Remove extra UefiBaseType.h includes
Date: Wed, 26 Oct 2016 20:14:54 -0700	[thread overview]
Message-ID: <1477538094-10676-1-git-send-email-michael.d.kinney@intel.com> (raw)

Based on Laszlo Ersek work to add ASSERT_RETURN_ERORR():

  https://lists.01.org/pipermail/edk2-devel/2016-October/003132.html

Laszlo also discovered libraries of type BASE that include
UefiBaseType.h that should not include that file:

  https://lists.01.org/pipermail/edk2-devel/2016-October/003308.html

This change removes the extra #include of <Uefi/UefiBaseType.h>
from QNCSmmLib.c.

Cc: Kelly Steele <kelly.steele@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
---
 QuarkSocPkg/QuarkNorthCluster/Library/QNCSmmLib/QNCSmmLib.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/QuarkSocPkg/QuarkNorthCluster/Library/QNCSmmLib/QNCSmmLib.c b/QuarkSocPkg/QuarkNorthCluster/Library/QNCSmmLib/QNCSmmLib.c
index 075d45f..5f2722a 100644
--- a/QuarkSocPkg/QuarkNorthCluster/Library/QNCSmmLib/QNCSmmLib.c
+++ b/QuarkSocPkg/QuarkNorthCluster/Library/QNCSmmLib/QNCSmmLib.c
@@ -1,7 +1,7 @@
 /** @file
 QNC Smm Library Services that implements SMM Region access, S/W SMI generation and detection.
 
-Copyright (c) 2013-2015 Intel Corporation.
+Copyright (c) 2013-2016 Intel Corporation.
 
 This program and the accompanying materials
 are licensed and made available under the terms and conditions of the BSD License
@@ -19,7 +19,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #include <Library/DebugLib.h>
 #include <Library/PcdLib.h>
 #include <Library/IoLib.h>
-#include <Uefi/UefiBaseType.h>
 #include <Library/QNCAccessLib.h>
 
 #define BOOT_SERVICE_SOFTWARE_SMI_DATA          0
-- 
2.6.3.windows.1



             reply	other threads:[~2016-10-27  3:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-27  3:14 Michael Kinney [this message]
2016-10-28  3:01 ` [Patch] QuarkSocPkg/Library: Remove extra UefiBaseType.h includes Gao, Liming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477538094-10676-1-git-send-email-michael.d.kinney@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox