[Patch] QuarkSocPkg/Library: Remove extra UefiBaseType.h includes

[Patch] QuarkSocPkg/Library: Remove extra UefiBaseType.h includes

[Michael Kinney]

Based on Laszlo Ersek work to add ASSERT_RETURN_ERORR():

  https://lists.01.org/pipermail/edk2-devel/2016-October/003132.html

Laszlo also discovered libraries of type BASE that include
UefiBaseType.h that should not include that file:

  https://lists.01.org/pipermail/edk2-devel/2016-October/003308.html

This change removes the extra #include of <Uefi/UefiBaseType.h>
from QNCSmmLib.c.

Cc: Kelly Steele <kelly.steele@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
---
 QuarkSocPkg/QuarkNorthCluster/Library/QNCSmmLib/QNCSmmLib.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/QuarkSocPkg/QuarkNorthCluster/Library/QNCSmmLib/QNCSmmLib.c b/QuarkSocPkg/QuarkNorthCluster/Library/QNCSmmLib/QNCSmmLib.c
index 075d45f..5f2722a 100644
--- a/QuarkSocPkg/QuarkNorthCluster/Library/QNCSmmLib/QNCSmmLib.c
+++ b/QuarkSocPkg/QuarkNorthCluster/Library/QNCSmmLib/QNCSmmLib.c
@@ -1,7 +1,7 @@
 /** @file
 QNC Smm Library Services that implements SMM Region access, S/W SMI generation and detection.
 
-Copyright (c) 2013-2015 Intel Corporation.
+Copyright (c) 2013-2016 Intel Corporation.
 
 This program and the accompanying materials
 are licensed and made available under the terms and conditions of the BSD License
@@ -19,7 +19,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #include <Library/DebugLib.h>
 #include <Library/PcdLib.h>
 #include <Library/IoLib.h>
-#include <Uefi/UefiBaseType.h>
 #include <Library/QNCAccessLib.h>
 
 #define BOOT_SERVICE_SOFTWARE_SMI_DATA          0
-- 
2.6.3.windows.1

Re: [Patch] QuarkSocPkg/Library: Remove extra UefiBaseType.h includes

[Gao, Liming]

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Michael Kinney
> Sent: Thursday, October 27, 2016 11:15 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [Patch] QuarkSocPkg/Library: Remove extra UefiBaseType.h
> includes
> 
> Based on Laszlo Ersek work to add ASSERT_RETURN_ERORR():
> 
>   https://lists.01.org/pipermail/edk2-devel/2016-October/003132.html
> 
> Laszlo also discovered libraries of type BASE that include
> UefiBaseType.h that should not include that file:
> 
>   https://lists.01.org/pipermail/edk2-devel/2016-October/003308.html
> 
> This change removes the extra #include of <Uefi/UefiBaseType.h>
> from QNCSmmLib.c.
> 
> Cc: Kelly Steele <kelly.steele@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
> ---
>  QuarkSocPkg/QuarkNorthCluster/Library/QNCSmmLib/QNCSmmLib.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git
> a/QuarkSocPkg/QuarkNorthCluster/Library/QNCSmmLib/QNCSmmLib.c
> b/QuarkSocPkg/QuarkNorthCluster/Library/QNCSmmLib/QNCSmmLib.c
> index 075d45f..5f2722a 100644
> --- a/QuarkSocPkg/QuarkNorthCluster/Library/QNCSmmLib/QNCSmmLib.c
> +++ b/QuarkSocPkg/QuarkNorthCluster/Library/QNCSmmLib/QNCSmmLib.c
> @@ -1,7 +1,7 @@
>  /** @file
>  QNC Smm Library Services that implements SMM Region access, S/W SMI
> generation and detection.
> 
> -Copyright (c) 2013-2015 Intel Corporation.
> +Copyright (c) 2013-2016 Intel Corporation.
> 
>  This program and the accompanying materials
>  are licensed and made available under the terms and conditions of the BSD
> License
> @@ -19,7 +19,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY
> KIND, EITHER EXPRESS OR IMPLIED.
>  #include <Library/DebugLib.h>
>  #include <Library/PcdLib.h>
>  #include <Library/IoLib.h>
> -#include <Uefi/UefiBaseType.h>
>  #include <Library/QNCAccessLib.h>
> 
>  #define BOOT_SERVICE_SOFTWARE_SMI_DATA          0
> --
> 2.6.3.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel