public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Yonghong Zhu <yonghong.zhu@intel.com>
To: edk2-devel@lists.01.org
Cc: Liming Gao <liming.gao@intel.com>
Subject: [Patch] BaseTools: Fix a bug for ExpandMacros to support mixed case ENV var
Date: Fri, 28 Oct 2016 12:42:46 +0800	[thread overview]
Message-ID: <1477629766-39008-1-git-send-email-yonghong.zhu@intel.com> (raw)

os.environ contains all environment variables uppercase on Windows which
cause the key in the self.MacroDictionary is uppercase, but the real
variable name maybe mixed case, eg:WINSDK81x86, then we can't find the
variable in the self.MacroDictionary.

Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
---
 BaseTools/Source/Python/Common/ToolDefClassObject.py | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/BaseTools/Source/Python/Common/ToolDefClassObject.py b/BaseTools/Source/Python/Common/ToolDefClassObject.py
index 5dd505c..a71c616 100644
--- a/BaseTools/Source/Python/Common/ToolDefClassObject.py
+++ b/BaseTools/Source/Python/Common/ToolDefClassObject.py
@@ -234,17 +234,20 @@ class ToolDefClassObject(object):
     # @param Value:   The string with unreplaced macros
     #
     # @retval Value:  The string which has been replaced with real value
     #
     def ExpandMacros(self, Value):
+        # os.environ contains all environment variables uppercase on Windows which cause the key in the self.MacroDictionary is uppercase, but Ref may not
         EnvReference = gEnvRefPattern.findall(Value)
         for Ref in EnvReference:
-            if Ref not in self.MacroDictionary:
+            if Ref not in self.MacroDictionary and Ref.upper() not in self.MacroDictionary:
                 Value = Value.replace(Ref, "")
             else:
-                Value = Value.replace(Ref, self.MacroDictionary[Ref])
- 
+                if Ref in self.MacroDictionary:
+                    Value = Value.replace(Ref, self.MacroDictionary[Ref])
+                else:
+                    Value = Value.replace(Ref, self.MacroDictionary[Ref.upper()])
 
         MacroReference = gMacroRefPattern.findall(Value)
         for Ref in MacroReference:
             if Ref not in self.MacroDictionary:
                 return False, Ref
-- 
2.6.1.windows.1



             reply	other threads:[~2016-10-28  4:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-28  4:42 Yonghong Zhu [this message]
2016-11-01  9:38 ` [Patch] BaseTools: Fix a bug for ExpandMacros to support mixed case ENV var Gao, Liming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477629766-39008-1-git-send-email-yonghong.zhu@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox