From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: edk2-devel@lists.01.org, leif.lindholm@linaro.org
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [PATCH 4/5] ArmPkg/CpuDxe: set DmaBufferAlignment according to CWG
Date: Mon, 31 Oct 2016 18:13:09 +0000 [thread overview]
Message-ID: <1477937590-10361-5-git-send-email-ard.biesheuvel@linaro.org> (raw)
In-Reply-To: <1477937590-10361-1-git-send-email-ard.biesheuvel@linaro.org>
The DmaBufferAlignment currently defaults to 4, which is dangerously
small and may result in lost data on platform that perform non-coherent
DMA. So instead, take the CWG value from the cache info registers.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
ArmPkg/Drivers/CpuDxe/CpuDxe.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ArmPkg/Drivers/CpuDxe/CpuDxe.c b/ArmPkg/Drivers/CpuDxe/CpuDxe.c
index d089cb2d119f..ddc64fd255a0 100644
--- a/ArmPkg/Drivers/CpuDxe/CpuDxe.c
+++ b/ArmPkg/Drivers/CpuDxe/CpuDxe.c
@@ -225,7 +225,7 @@ EFI_CPU_ARCH_PROTOCOL mCpu = {
CpuGetTimerValue,
CpuSetMemoryAttributes,
0, // NumberOfTimers
- 4, // DmaBufferAlignment
+ 2048, // DmaBufferAlignment
};
EFI_STATUS
@@ -239,6 +239,8 @@ CpuDxeInitialize (
InitializeExceptions (&mCpu);
+ mCpu.DmaBufferAlignment = ArmCacheWritebackGranule ();
+
Status = gBS->InstallMultipleProtocolInterfaces (
&mCpuHandle,
&gEfiCpuArchProtocolGuid, &mCpu,
--
2.7.4
next prev parent reply other threads:[~2016-10-31 18:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 18:13 [PATCH 0/5] EmbeddedPkg: generic support for reusing PCI drivers for platform devices Ard Biesheuvel
2016-10-31 18:13 ` [PATCH 1/5] EmbeddedPkg: introduce platform PCI I/O protocol Ard Biesheuvel
2016-11-01 21:54 ` Leif Lindholm
2016-11-02 13:29 ` Ard Biesheuvel
2016-11-02 15:42 ` Leif Lindholm
2016-10-31 18:13 ` [PATCH 2/5] EmbeddedPkg: introduce platform PCI I/O registration library Ard Biesheuvel
2016-11-01 21:57 ` Leif Lindholm
2016-11-02 13:30 ` Ard Biesheuvel
2016-11-02 15:39 ` Leif Lindholm
2016-11-07 14:54 ` Evan Lloyd
2016-10-31 18:13 ` [PATCH 3/5] EmbeddedPkg: implement generic platform PCI I/O driver Ard Biesheuvel
2016-11-01 22:22 ` Leif Lindholm
2016-11-02 13:39 ` Ard Biesheuvel
2016-11-02 16:05 ` Leif Lindholm
2016-10-31 18:13 ` Ard Biesheuvel [this message]
2016-11-01 22:32 ` [PATCH 4/5] ArmPkg/CpuDxe: set DmaBufferAlignment according to CWG Leif Lindholm
2016-11-02 13:40 ` Ard Biesheuvel
2016-11-02 16:10 ` Leif Lindholm
2016-11-02 16:17 ` Ard Biesheuvel
2016-11-02 16:21 ` Leif Lindholm
2016-11-02 16:23 ` Ard Biesheuvel
2016-10-31 18:13 ` [PATCH 5/5] EmbeddedPkg/PlatformPciIoDxe: add support for non-coherent DMA Ard Biesheuvel
2016-11-01 22:43 ` Leif Lindholm
2016-11-02 13:43 ` Ard Biesheuvel
2016-11-02 16:17 ` Leif Lindholm
2016-11-01 21:45 ` [PATCH 0/5] EmbeddedPkg: generic support for reusing PCI drivers for platform devices Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477937590-10361-5-git-send-email-ard.biesheuvel@linaro.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox