From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CD0D081CF3 for ; Thu, 3 Nov 2016 00:24:05 -0700 (PDT) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 03 Nov 2016 00:24:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,585,1473145200"; d="scan'208";a="897185248" Received: from shwdeopenpsi014.ccr.corp.intel.com ([10.239.9.34]) by orsmga003.jf.intel.com with ESMTP; 03 Nov 2016 00:24:06 -0700 From: Hao Wu To: edk2-devel@lists.01.org Cc: Hao Wu , Liming Gao , Yonghong Zhu Date: Thu, 3 Nov 2016 15:22:46 +0800 Message-Id: <1478157783-9368-37-git-send-email-hao.a.wu@intel.com> X-Mailer: git-send-email 1.9.5.msysgit.0 In-Reply-To: <1478157783-9368-1-git-send-email-hao.a.wu@intel.com> References: <1478157783-9368-1-git-send-email-hao.a.wu@intel.com> Subject: [PATCH v2 36/53] BaseTools/Split: Fix potential memory and resource leak X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Nov 2016 07:24:05 -0000 Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/Split/Split.c | 41 +++++++++++++++++++++++++++------------- 1 file changed, 28 insertions(+), 13 deletions(-) diff --git a/BaseTools/Source/C/Split/Split.c b/BaseTools/Source/C/Split/Split.c index d723ed0..7ab66be 100644 --- a/BaseTools/Source/C/Split/Split.c +++ b/BaseTools/Source/C/Split/Split.c @@ -223,14 +223,15 @@ Returns: --*/ { EFI_STATUS Status = EFI_SUCCESS; + INTN ReturnStatus = STATUS_SUCCESS; FILE *In; CHAR8 *InputFileName = NULL; CHAR8 *OutputDir = NULL; CHAR8 *OutFileName1 = NULL; CHAR8 *OutFileName2 = NULL; UINT64 SplitValue = (UINT64) -1; - FILE *Out1; - FILE *Out2; + FILE *Out1 = NULL; + FILE *Out2 = NULL; CHAR8 *OutName1 = NULL; CHAR8 *OutName2 = NULL; CHAR8 *CurrentDir = NULL; @@ -366,7 +367,8 @@ Returns: OutName1 = (CHAR8*)malloc(strlen(InputFileName) + 16); if (OutName1 == NULL) { Warning (NULL, 0, 0, NULL, "Memory Allocation Fail."); - return STATUS_ERROR; + ReturnStatus = STATUS_ERROR; + goto Finish; } strcpy (OutName1, InputFileName); strcat (OutName1, "1"); @@ -377,7 +379,8 @@ Returns: OutName2 = (CHAR8*)malloc(strlen(InputFileName) + 16); if (OutName2 == NULL) { Warning (NULL, 0, 0, NULL, "Memory Allocation Fail."); - return STATUS_ERROR; + ReturnStatus = STATUS_ERROR; + goto Finish; } strcpy (OutName2, InputFileName); strcat (OutName2, "2"); @@ -389,20 +392,23 @@ Returns: //OutputDirSpecified = TRUE; if (chdir(OutputDir) != 0) { Warning (NULL, 0, 0, NULL, "Change dir to OutputDir Fail."); - return STATUS_ERROR; + ReturnStatus = STATUS_ERROR; + goto Finish; } } CurrentDir = (CHAR8*)getcwd((CHAR8*)0, 0); if (EFI_ERROR(CreateDir(&OutFileName1))) { Error (OutFileName1, 0, 5, "Create Dir for File1 Fail.", NULL); - return STATUS_ERROR; + ReturnStatus = STATUS_ERROR; + goto Finish; } chdir(CurrentDir); if (EFI_ERROR(CreateDir(&OutFileName2))) { Error (OutFileName2, 0, 5, "Create Dir for File2 Fail.", NULL); - return STATUS_ERROR; + ReturnStatus = STATUS_ERROR; + goto Finish; } chdir(CurrentDir); free(CurrentDir); @@ -411,14 +417,16 @@ Returns: if (Out1 == NULL) { // ("Unable to open file \"%s\"\n", OutFileName1); Error (OutFileName1, 0, 1, "File open failure", NULL); - return STATUS_ERROR; + ReturnStatus = STATUS_ERROR; + goto Finish; } Out2 = fopen (LongFilePath (OutFileName2), "wb"); if (Out2 == NULL) { // ("Unable to open file \"%s\"\n", OutFileName2); Error (OutFileName2, 0, 1, "File open failure", NULL); - return STATUS_ERROR; + ReturnStatus = STATUS_ERROR; + goto Finish; } for (Index = 0; Index < SplitValue; Index++) { @@ -439,15 +447,22 @@ Returns: fputc (CharC, Out2); } +Finish: if (OutName1 != NULL) { free(OutName1); } if (OutName2 != NULL) { free(OutName2); } - fclose (In); - fclose (Out1); - fclose (Out2); + if (In != NULL) { + fclose (In); + } + if (Out1 != NULL) { + fclose (Out1); + } + if (Out2 != NULL) { + fclose (Out2); + } - return STATUS_SUCCESS; + return ReturnStatus; } -- 1.9.5.msysgit.0