From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x22f.google.com (mail-wm0-x22f.google.com [IPv6:2a00:1450:400c:c09::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 19B6C81CF5 for ; Thu, 3 Nov 2016 04:40:53 -0700 (PDT) Received: by mail-wm0-x22f.google.com with SMTP id p190so327237850wmp.1 for ; Thu, 03 Nov 2016 04:40:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=EGvqslQdTGYgf/5lhRNe+71eb6ymaE5MA70tk9845ac=; b=HQqST3xrGiZEw6rGro/+MFuN2jhU+/RqxE1CuGEG4PWofDnGfEeLAhC/+YKzUiVHqy rAX4CN84P0N766r+iMoMCaRhKScbINhxaW5KzHQkxnXdD3PCpIzeGjcnB3w4AvWqjQ8h ELmCgx0rgz7SytggkEeF5Vp8KCqard9n9cLKY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=EGvqslQdTGYgf/5lhRNe+71eb6ymaE5MA70tk9845ac=; b=gL+GOixjClYlbQhdwqa1qiykgzdInlBkv7L2TV7Hek8+v2Rk6ZBoDqMbQhJsmsKik4 WagcFQbVnYn0ig+xS+bPHGCGiKowlLbpAJN46AwYTyWMI1cmHYgAupttDqkx4L+RiGE/ SO7jhorv0CRoJT8HhB8CE+9k5INLOoPk1XR3OxEbFKcGy5Byi1acib8XswkJKBQyPSkw lO/liuENILGOTZpmux/cfi4Xsr6bBe5Ao54rlvNYt7ILPlYgDYq85fTzxU7kIkk2n8rY HFv0yFggd4QVGXwCOrIIT6RdcVhAW4LvKPC2iVIVtY5T1HPUr+96s3/RjRK17eqx0q4A 8XYg== X-Gm-Message-State: ABUngvdeLMbOPvewoiupHKLPMJEwiDmkI9P7l3LuR8IC7e3Yj4ieBcBDOxWxw+WYQ4b70W21 X-Received: by 10.194.138.232 with SMTP id qt8mr6833223wjb.131.1478173253014; Thu, 03 Nov 2016 04:40:53 -0700 (PDT) Received: from localhost.localdomain ([105.151.153.127]) by smtp.gmail.com with ESMTPSA id hb5sm8081181wjc.5.2016.11.03.04.40.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 03 Nov 2016 04:40:51 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org, leif.lindholm@linaro.org, michael.d.kinney@intel.com, afish@apple.com Cc: mw@semihalf.com, feng.tian@intel.com, star.zeng@intel.com, Ard Biesheuvel Date: Thu, 3 Nov 2016 11:40:34 +0000 Message-Id: <1478173239-22270-1-git-send-email-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.7.4 Subject: [PATCH v2 0/5] MdeModulePkg: add support for non-discoverable devices X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Nov 2016 11:40:53 -0000 This v2 is based on 'EmbeddedPkg: generic support for reusing PCI drivers for platform devices' [0] but it has seen some updates that justified changing the name, and at Leif's request, it now targets MdeModulePkg not EmbeddedPkg. The rationale for this series is the fact that many ARM platforms implement some form of PCI 'emulation', to allow non-discoverable devices that implement standardized host controller interfaces (i.e., EHCI, AHCI) to be controlled by the generic EDK2 drivers, which are layered on top of the PCI I/O protocols (even though the respective host controller specifications don't mandate that) There are a couple of problems with that approach: - Most implementations are based on the original code created for BeagleBoard, which is a 32-bit platform. Unlike x86, which usually does not perform PCI DMA above 4 GB, the ARM ecosystem is much more heterogeneous, and platforms that have memory both above and below the 4 GB mark may ship with, e.g., EHCI controllers that do not implement 64-bit DMA addressing. - Implementations depend on the DmaLib library class in EmbeddedPkg, of which coherent and non-coherent implementations exists. However, both types of devices may appear on a single platform, requiring several instances of the same driver. - Existing implementations do not follow the UEFI driver model, but instantiate a fixed number of PCI I/O protocol handles, and bring up all the devices when doing so. However, the UEFI philosophy is to only instantiate (and thus initialize) devices that are involved in booting. So instead, let's define a base protocol that simply asserts the presence of a certain kind of device at a certain memory offset, allowing platforms to instantiate any number of these statically, and leave it to post-DXE driver dispatch to actually bind the drivers as usual. This is implemented in patch #1. Note that it includes an AMBA device type, which we intend to use in the future to move ARM AMBA drivers to the UEFI driver model as well (i.e., LCD controller, SD/MMC controller) Patch #2 implements a utility library to register non-discoverable devices. Patch #3 implements the UEFI driver that instantiates PCI I/O protocol handles for non-discoverable devices that we know can be driven by a generic driver in EDK2. The initial version implements coherent DMA only. Patch #4 implements non-coherent DMA for the driver added in patch #3. Patch #5 is included for reference. It ports the BeagleBoard platform to the new driver stack. [0] https://lists.01.org/pipermail/edk2-devel/2016-October/003842.html Ard Biesheuvel (5): MdeModulePkg: introduce non-discoverable device protocol MdeModule: introduce helper library to register non-discoverable devices MdeModulePkg: implement generic PCI I/O driver for non-discoverable devices MdeModulePkg/NonDiscoverablePciDeviceDxe: add support for non-coherent DMA Omap35xxPkg/PciEmulation: port to new non-discoverable device infrastructure BeagleBoardPkg/BeagleBoardPkg.dsc | 2 + BeagleBoardPkg/BeagleBoardPkg.fdf | 1 + MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/ComponentName.c | 75 ++ MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.c | 208 ++++ MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.inf | 44 + MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c | 994 ++++++++++++++++++++ MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.h | 82 ++ MdeModulePkg/Include/Library/NonDiscoverableDeviceRegistrationLib.h | 47 + MdeModulePkg/Include/Protocol/NonDiscoverableDevice.h | 88 ++ MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.c | 119 +++ MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf | 34 + MdeModulePkg/MdeModulePkg.dec | 7 + MdeModulePkg/MdeModulePkg.dsc | 3 + Omap35xxPkg/Omap35xxPkg.dsc | 2 +- Omap35xxPkg/PciEmulation/PciEmulation.c | 571 +---------- Omap35xxPkg/PciEmulation/PciEmulation.h | 292 ------ Omap35xxPkg/PciEmulation/PciEmulation.inf | 16 +- Omap35xxPkg/PciEmulation/PciRootBridgeIo.c | 306 ------ 18 files changed, 1728 insertions(+), 1163 deletions(-) create mode 100644 MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/ComponentName.c create mode 100644 MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.c create mode 100644 MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.inf create mode 100644 MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c create mode 100644 MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.h create mode 100644 MdeModulePkg/Include/Library/NonDiscoverableDeviceRegistrationLib.h create mode 100644 MdeModulePkg/Include/Protocol/NonDiscoverableDevice.h create mode 100644 MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.c create mode 100644 MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf delete mode 100644 Omap35xxPkg/PciEmulation/PciEmulation.h delete mode 100644 Omap35xxPkg/PciEmulation/PciRootBridgeIo.c -- 2.7.4