Re: [PATCH v2] OvmfPkg/ResetVector: Depend on PCD values of the page tables.

[Jordan Justen <jordan.l.justen@intel.com>]

On 2016-11-03 15:55:10, Laszlo Ersek wrote:
> Hi Marvin,
> 
> On 11/03/16 20:18, Marvin Häuser wrote:
> > Currently, the values of the page tables' address and size are
> > hard-coded in the ResetVector. This patch replaces this with a PCD
> > dependency for the NASM Reset Vector. The ASM Reset Vector remains
> > using a hard-coded value due to the lack of C preprocessing.
> > 
> > Checks for the size have been added to alert the developer to rewrite
> > the ASM according to the new size, if it has been changed.
> > 
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com>
> > ---
> >  OvmfPkg/ResetVector/Ia32/PageTables64.asm | 23 ++++++++++----------
> >  OvmfPkg/ResetVector/ResetVector.inf       |  5 +++++
> >  OvmfPkg/ResetVector/ResetVector.nasmb     |  7 ++++++
> >  OvmfPkg/ResetVector/ResetVectorCode.asm   | 16 ++++++++++++++
> >  4 files changed, 39 insertions(+), 12 deletions(-)
> 
> I'll soon send a modified / simplified version of your patch (keeping
> your authorship and S-o-b in the first place of course). I find that
> simpler than struggling with an explanation :) I hope you're fine with this.
> 

Marvin's v3 seemed okay, but of course, it should be a series,
together with his separate patch that removes the unused
ResetVectorCode.asm file.

If your tweaks are minor, you can add my

Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

to both of his patches.

Thanks,

-Jordan