From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B30A081C8B for ; Thu, 3 Nov 2016 16:10:27 -0700 (PDT) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP; 03 Nov 2016 16:10:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,440,1473145200"; d="scan'208";a="27307344" Received: from poojakri-mobl.amr.corp.intel.com (HELO localhost) ([10.252.132.157]) by orsmga005.jf.intel.com with ESMTP; 03 Nov 2016 16:10:29 -0700 MIME-Version: 1.0 To: Laszlo Ersek , =?utf-8?q?Marvin_H=C3=A4user?= Message-ID: <147821462919.32367.3606962514472585517@jljusten-ivb> From: Jordan Justen In-Reply-To: <79c821b0-1b1e-e148-e0ae-ee55e83cee48@redhat.com> Cc: "edk2-devel@lists.01.org" References: <79c821b0-1b1e-e148-e0ae-ee55e83cee48@redhat.com> User-Agent: alot/0.3.7 Date: Thu, 03 Nov 2016 16:10:29 -0700 Subject: Re: [PATCH v2] OvmfPkg/ResetVector: Depend on PCD values of the page tables. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Nov 2016 23:10:27 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2016-11-03 15:55:10, Laszlo Ersek wrote: > Hi Marvin, > = > On 11/03/16 20:18, Marvin H=C3=A4user wrote: > > Currently, the values of the page tables' address and size are > > hard-coded in the ResetVector. This patch replaces this with a PCD > > dependency for the NASM Reset Vector. The ASM Reset Vector remains > > using a hard-coded value due to the lack of C preprocessing. > > = > > Checks for the size have been added to alert the developer to rewrite > > the ASM according to the new size, if it has been changed. > > = > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Marvin Haeuser > > --- > > OvmfPkg/ResetVector/Ia32/PageTables64.asm | 23 ++++++++++---------- > > OvmfPkg/ResetVector/ResetVector.inf | 5 +++++ > > OvmfPkg/ResetVector/ResetVector.nasmb | 7 ++++++ > > OvmfPkg/ResetVector/ResetVectorCode.asm | 16 ++++++++++++++ > > 4 files changed, 39 insertions(+), 12 deletions(-) > = > I'll soon send a modified / simplified version of your patch (keeping > your authorship and S-o-b in the first place of course). I find that > simpler than struggling with an explanation :) I hope you're fine with th= is. > = Marvin's v3 seemed okay, but of course, it should be a series, together with his separate patch that removes the unused ResetVectorCode.asm file. If your tweaks are minor, you can add my Reviewed-by: Jordan Justen to both of his patches. Thanks, -Jordan