From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 31BA981CF0 for ; Thu, 3 Nov 2016 16:53:01 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP; 03 Nov 2016 16:53:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,589,1473145200"; d="scan'208";a="27187603" Received: from poojakri-mobl.amr.corp.intel.com (HELO localhost) ([10.252.132.157]) by fmsmga006.fm.intel.com with ESMTP; 03 Nov 2016 16:53:01 -0700 MIME-Version: 1.0 To: Laszlo Ersek , =?utf-8?q?Marvin_H=C3=A4user?= , "edk2-devel@lists.01.org" Message-ID: <147821718109.366.15906806000523319024@jljusten-ivb> From: Jordan Justen In-Reply-To: <7f435960-702c-d608-310a-5bb8bb6cbe1a@redhat.com> References: <7f435960-702c-d608-310a-5bb8bb6cbe1a@redhat.com> User-Agent: alot/0.3.7 Date: Thu, 03 Nov 2016 16:53:01 -0700 Subject: Re: [PATCH] OvmfPkg/ResetVector: Remove the unused ASM ResetVector. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Nov 2016 23:53:01 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2016-11-03 16:46:18, Laszlo Ersek wrote: > On 11/03/16 22:40, Marvin H=C3=A4user wrote: > > Remove the ResetVector.asm file as it is no longer referenced since > > the switch to ResetVector.nasmb. > > = > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Marvin Haeuser > > --- > > OvmfPkg/ResetVector/ResetVectorCode.asm | 53 -------------------- > > 1 file changed, 53 deletions(-) > = > Reviewed-by: Laszlo Ersek > = > Jordan, do you think you could commit this patch? It's 00:46 here. :/ > = Sure. I'll commit this one, and we can sort out the second patch tomorrow. Thanks, -Jordan > = > > diff --git a/OvmfPkg/ResetVector/ResetVectorCode.asm b/OvmfPkg/ResetVec= tor/ResetVectorCode.asm > > deleted file mode 100644 > > index 052c821f212c..000000000000 > > --- a/OvmfPkg/ResetVector/ResetVectorCode.asm > > +++ /dev/null > > @@ -1,53 +0,0 @@ > > -;---------------------------------------------------------------------= --------- > > -; @file > > -; This file includes all other code files to assemble the reset vector= code > > -; > > -; Copyright (c) 2008 - 2013, Intel Corporation. All rights reserved. > > -; This program and the accompanying materials > > -; are licensed and made available under the terms and conditions of th= e BSD License > > -; which accompanies this distribution. The full text of the license m= ay be found at > > -; http://opensource.org/licenses/bsd-license.php > > -; > > -; THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > > -; WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR= IMPLIED. > > -; > > -;---------------------------------------------------------------------= --------- > > - > > -%ifdef ARCH_IA32 > > - %ifdef ARCH_X64 > > - %error "Only one of ARCH_IA32 or ARCH_X64 can be defined." > > - %endif > > -%elifdef ARCH_X64 > > -%else > > - %error "Either ARCH_IA32 or ARCH_X64 must be defined." > > -%endif > > - > > -%include "CommonMacros.inc" > > - > > -%include "PostCodes.inc" > > - > > -%ifdef DEBUG_NONE > > - %include "DebugDisabled.asm" > > -%elifdef DEBUG_PORT80 > > - %include "Port80Debug.asm" > > -%elifdef DEBUG_SERIAL > > - %include "SerialDebug.asm" > > -%else > > - %error "No debug type was specified." > > -%endif > > - > > -%include "Ia32/SearchForBfvBase.asm" > > -%include "Ia32/SearchForSecEntry.asm" > > - > > -%ifdef ARCH_X64 > > -%include "Ia32/Flat32ToFlat64.asm" > > -%include "Ia32/PageTables64.asm" > > -%endif > > - > > -%include "Ia16/Real16ToFlat32.asm" > > -%include "Ia16/Init16.asm" > > - > > -%include "Main.asm" > > - > > -%include "Ia16/ResetVectorVtf0.asm" > > - > > = > = > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel