* [PATCH v2] CryptoPkg/BaseCryptLib: Make comments consistent with the function
@ 2016-11-10 9:08 Dandan Bi
2016-11-11 0:54 ` Long, Qin
0 siblings, 1 reply; 2+ messages in thread
From: Dandan Bi @ 2016-11-10 9:08 UTC (permalink / raw)
To: edk2-devel
V2: Correct the unaligned parameter name in BaseCryptLib.h.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
CryptoPkg/Include/Library/BaseCryptLib.h | 4 ++--
CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c | 2 +-
CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/CryptoPkg/Include/Library/BaseCryptLib.h b/CryptoPkg/Include/Library/BaseCryptLib.h
index 45dac3b..0004493 100644
--- a/CryptoPkg/Include/Library/BaseCryptLib.h
+++ b/CryptoPkg/Include/Library/BaseCryptLib.h
@@ -1114,11 +1114,11 @@ HmacSha1Update (
If HmacSha1Context is NULL, then return FALSE.
If HashValue is NULL, then return FALSE.
If this interface is not supported, then return FALSE.
@param[in, out] HmacSha1Context Pointer to the HMAC-SHA1 context.
- @param[out] HashValue Pointer to a buffer that receives the HMAC-SHA1 digest
+ @param[out] HmacValue Pointer to a buffer that receives the HMAC-SHA1 digest
value (20 bytes).
@retval TRUE HMAC-SHA1 digest computation succeeded.
@retval FALSE HMAC-SHA1 digest computation failed.
@retval FALSE This interface is not supported.
@@ -1232,11 +1232,11 @@ HmacSha256Update (
If HmacSha256Context is NULL, then return FALSE.
If HashValue is NULL, then return FALSE.
If this interface is not supported, then return FALSE.
@param[in, out] HmacSha256Context Pointer to the HMAC-SHA256 context.
- @param[out] HashValue Pointer to a buffer that receives the HMAC-SHA256 digest
+ @param[out] HmacValue Pointer to a buffer that receives the HMAC-SHA256 digest
value (32 bytes).
@retval TRUE HMAC-SHA256 digest computation succeeded.
@retval FALSE HMAC-SHA256 digest computation failed.
@retval FALSE This interface is not supported.
diff --git a/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c b/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c
index 5d349dc..e17ef29 100644
--- a/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c
+++ b/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c
@@ -162,11 +162,11 @@ HmacSha256Update (
If HmacSha256Context is NULL, then return FALSE.
If HashValue is NULL, then return FALSE.
@param[in, out] HmacSha256Context Pointer to the HMAC-SHA256 context.
- @param[out] HashValue Pointer to a buffer that receives the HMAC-SHA256 digest
+ @param[out] HmacValue Pointer to a buffer that receives the HMAC-SHA256 digest
value (32 bytes).
@retval TRUE HMAC-SHA256 digest computation succeeded.
@retval FALSE HMAC-SHA256 digest computation failed.
diff --git a/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c b/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c
index 48704e1..35abdda 100644
--- a/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c
+++ b/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c
@@ -107,11 +107,11 @@ HmacSha256Update (
Completes computation of the HMAC-SHA256 digest value.
Return FALSE to indicate this interface is not supported.
@param[in, out] HmacSha256Context Pointer to the HMAC-SHA256 context.
- @param[out] HashValue Pointer to a buffer that receives the HMAC-SHA256 digest
+ @param[out] HmacValue Pointer to a buffer that receives the HMAC-SHA256 digest
value (32 bytes).
@retval FALSE This interface is not supported.
**/
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] CryptoPkg/BaseCryptLib: Make comments consistent with the function
2016-11-10 9:08 [PATCH v2] CryptoPkg/BaseCryptLib: Make comments consistent with the function Dandan Bi
@ 2016-11-11 0:54 ` Long, Qin
0 siblings, 0 replies; 2+ messages in thread
From: Long, Qin @ 2016-11-11 0:54 UTC (permalink / raw)
To: Bi, Dandan, edk2-devel@lists.01.org
Reviewed-by: Qin Long <qin.long@intel.com>
Best Regards & Thanks,
LONG, Qin
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Dandan Bi
> Sent: Thursday, November 10, 2016 5:09 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH v2] CryptoPkg/BaseCryptLib: Make comments
> consistent with the function
>
> V2: Correct the unaligned parameter name in BaseCryptLib.h.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> CryptoPkg/Include/Library/BaseCryptLib.h | 4 ++--
> CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c | 2 +-
> CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/CryptoPkg/Include/Library/BaseCryptLib.h
> b/CryptoPkg/Include/Library/BaseCryptLib.h
> index 45dac3b..0004493 100644
> --- a/CryptoPkg/Include/Library/BaseCryptLib.h
> +++ b/CryptoPkg/Include/Library/BaseCryptLib.h
> @@ -1114,11 +1114,11 @@ HmacSha1Update (
> If HmacSha1Context is NULL, then return FALSE.
> If HashValue is NULL, then return FALSE.
> If this interface is not supported, then return FALSE.
>
> @param[in, out] HmacSha1Context Pointer to the HMAC-SHA1 context.
> - @param[out] HashValue Pointer to a buffer that receives the HMAC-
> SHA1 digest
> + @param[out] HmacValue Pointer to a buffer that receives the
> HMAC-SHA1 digest
> value (20 bytes).
>
> @retval TRUE HMAC-SHA1 digest computation succeeded.
> @retval FALSE HMAC-SHA1 digest computation failed.
> @retval FALSE This interface is not supported.
> @@ -1232,11 +1232,11 @@ HmacSha256Update (
> If HmacSha256Context is NULL, then return FALSE.
> If HashValue is NULL, then return FALSE.
> If this interface is not supported, then return FALSE.
>
> @param[in, out] HmacSha256Context Pointer to the HMAC-SHA256
> context.
> - @param[out] HashValue Pointer to a buffer that receives the
> HMAC-SHA256 digest
> + @param[out] HmacValue Pointer to a buffer that receives the
> HMAC-SHA256 digest
> value (32 bytes).
>
> @retval TRUE HMAC-SHA256 digest computation succeeded.
> @retval FALSE HMAC-SHA256 digest computation failed.
> @retval FALSE This interface is not supported.
> diff --git a/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c
> b/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c
> index 5d349dc..e17ef29 100644
> --- a/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c
> +++ b/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c
> @@ -162,11 +162,11 @@ HmacSha256Update (
>
> If HmacSha256Context is NULL, then return FALSE.
> If HashValue is NULL, then return FALSE.
>
> @param[in, out] HmacSha256Context Pointer to the HMAC-SHA256
> context.
> - @param[out] HashValue Pointer to a buffer that receives the
> HMAC-SHA256 digest
> + @param[out] HmacValue Pointer to a buffer that receives the
> HMAC-SHA256 digest
> value (32 bytes).
>
> @retval TRUE HMAC-SHA256 digest computation succeeded.
> @retval FALSE HMAC-SHA256 digest computation failed.
>
> diff --git a/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c
> b/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c
> index 48704e1..35abdda 100644
> --- a/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c
> +++ b/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c
> @@ -107,11 +107,11 @@ HmacSha256Update (
> Completes computation of the HMAC-SHA256 digest value.
>
> Return FALSE to indicate this interface is not supported.
>
> @param[in, out] HmacSha256Context Pointer to the HMAC-SHA256
> context.
> - @param[out] HashValue Pointer to a buffer that receives the
> HMAC-SHA256 digest
> + @param[out] HmacValue Pointer to a buffer that receives the
> HMAC-SHA256 digest
> value (32 bytes).
>
> @retval FALSE This interface is not supported.
>
> **/
> --
> 1.9.5.msysgit.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-11 0:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-10 9:08 [PATCH v2] CryptoPkg/BaseCryptLib: Make comments consistent with the function Dandan Bi
2016-11-11 0:54 ` Long, Qin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox